diff options
author | Jakub Jelinek <jakub@redhat.com> | 2020-03-26 10:10:21 +0100 |
---|---|---|
committer | Jakub Jelinek <jakub@redhat.com> | 2020-03-26 10:10:21 +0100 |
commit | 10ea09ee846eaa345161a3a3f519b3780d6101fa (patch) | |
tree | fa1093ef2fea98dbc89a5336b18885639f2addfe /gcc/testsuite/g++.dg | |
parent | dab932d1519ba07fb4c49e6849ee7ceb02c0d603 (diff) | |
download | gcc-10ea09ee846eaa345161a3a3f519b3780d6101fa.zip gcc-10ea09ee846eaa345161a3a3f519b3780d6101fa.tar.gz gcc-10ea09ee846eaa345161a3a3f519b3780d6101fa.tar.bz2 |
gimplify: Fix -fcompare-debug differences caused by gimplify_body [PR94281]
The following testcase FAILs, because gimplify_body adds a GIMPLE_NOP only
when there are no statements in the function and with -g there is a
DEBUG_BEGIN_STMT, so it doesn't add it and due to -fno-tree-dce that never
gets removed afterwards. Similarly, if the body seq after gimplification
contains some DEBUG_BEGIN_STMTs plus a single gbind, then we could behave
differently between -g0 and -g, by using that gbind as the body in the -g0
case and not in the -g case.
This patch fixes that by ignoring DEBUG_BEGIN_STMTs (other debug stmts can't
appear at this point yet thankfully) during decisions and if we pick the
single gbind and there are DEBUG_BEGIN_STMTs next to it, it moves them into
the gbind.
While debugging this, I found also a bug in the gimple_seq_last_nondebug_stmt
function, for a seq that has a single non-DEBUG_BEGIN_STMT statement
followed by one or more DEBUG_BEGIN_STMTs it would return NULL rather than
the first statement.
2020-03-26 Jakub Jelinek <jakub@redhat.com>
PR debug/94281
* gimple.h (gimple_seq_first_nondebug_stmt): New function.
(gimple_seq_last_nondebug_stmt): Don't return NULL if seq contains
a single non-debug stmt followed by one or more debug stmts.
* gimplify.c (gimplify_body): Use gimple_seq_first_nondebug_stmt
instead of gimple_seq_first_stmt, use gimple_seq_first_nondebug_stmt
and gimple_seq_last_nondebug_stmt instead of gimple_seq_first and
gimple_seq_last to check if outer_stmt gbind could be reused and
if yes and it is surrounded by any debug stmts, move them into the
gbind body.
* g++.dg/debug/pr94281.C: New test.
Diffstat (limited to 'gcc/testsuite/g++.dg')
-rw-r--r-- | gcc/testsuite/g++.dg/debug/pr94281.C | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/gcc/testsuite/g++.dg/debug/pr94281.C b/gcc/testsuite/g++.dg/debug/pr94281.C new file mode 100644 index 0000000..0638691 --- /dev/null +++ b/gcc/testsuite/g++.dg/debug/pr94281.C @@ -0,0 +1,11 @@ +// PR debug/94281 +// { dg-do compile } +// { dg-options "-O1 -fno-tree-dce -fipa-icf -fno-tree-forwprop -fcompare-debug" } + +void fn1() +{ +} +void fn2() +{ + ; +} |