diff options
| author | Manuel López-Ibáñez <manu@gcc.gnu.org> | 2015-06-29 16:25:26 +0000 |
|---|---|---|
| committer | Manuel López-Ibáñez <manu@gcc.gnu.org> | 2015-06-29 16:25:26 +0000 |
| commit | da2e71c999f964c6b76581d8dd96c8f9bc48624d (patch) | |
| tree | 37d706419594766fd97ec27e029b3959e40e8aa6 /gcc/function.c | |
| parent | 77f3f9bf9eaec6f7095f711024d76a342655863b (diff) | |
| download | gcc-da2e71c999f964c6b76581d8dd96c8f9bc48624d.zip gcc-da2e71c999f964c6b76581d8dd96c8f9bc48624d.tar.gz gcc-da2e71c999f964c6b76581d8dd96c8f9bc48624d.tar.bz2 | |
Wunused-parameter warnings are given from cgraph::finalize_function,
which is the middle-end. This is an oddity compared to other
-Wunused-* warnings. Moreover, Fortran has its own definition of
-Wunused-parameter that conflicts with the middle-end definition.
This patch moves the middle-end part of Wunused-parameter to the C/C++
FEs. I'm not sure if other FEs expected this warning to work. If so,
they do not seem to test for it. Ada, for example, explicitly disables
it.
gcc/ChangeLog:
2015-06-29 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/66605
* cgraphunit.c (cgraph_node::finalize_function): Do not call
do_warn_unused_parameter.
* function.c (do_warn_unused_parameter): Move from here.
* function.h (do_warn_unused_parameter): Do not declare.
gcc/c-family/ChangeLog:
2015-06-29 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/66605
* c-common.c (do_warn_unused_parameter): Move here.
* c-common.h (do_warn_unused_parameter): Declare.
gcc/ada/ChangeLog:
2015-06-29 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/66605
* gcc-interface/misc.c (gnat_post_options): No need to disable
warn_unused_parameter anymore.
gcc/cp/ChangeLog:
2015-06-29 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/66605
* decl.c (finish_function): Call do_warn_unused_parameter.
gcc/testsuite/ChangeLog:
2015-06-29 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/66605
* gfortran.dg/wunused-parameter.f90: New test.
gcc/c/ChangeLog:
2015-06-29 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/66605
* c-decl.c (finish_function): Call do_warn_unused_parameter.
From-SVN: r225135
Diffstat (limited to 'gcc/function.c')
| -rw-r--r-- | gcc/function.c | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/gcc/function.c b/gcc/function.c index 4389bbd..de0b38f 100644 --- a/gcc/function.c +++ b/gcc/function.c @@ -5210,20 +5210,6 @@ use_return_register (void) diddle_return_value (do_use_return_reg, NULL); } -/* Possibly warn about unused parameters. */ -void -do_warn_unused_parameter (tree fn) -{ - tree decl; - - for (decl = DECL_ARGUMENTS (fn); - decl; decl = DECL_CHAIN (decl)) - if (!TREE_USED (decl) && TREE_CODE (decl) == PARM_DECL - && DECL_NAME (decl) && !DECL_ARTIFICIAL (decl) - && !TREE_NO_WARNING (decl)) - warning (OPT_Wunused_parameter, "unused parameter %q+D", decl); -} - /* Set the location of the insn chain starting at INSN to LOC. */ static void |