aboutsummaryrefslogtreecommitdiff
path: root/gcc/fortran/io.cc
diff options
context:
space:
mode:
authorDavid Malcolm <dmalcolm@redhat.com>2024-10-04 18:31:17 -0400
committerDavid Malcolm <dmalcolm@redhat.com>2024-10-04 18:31:17 -0400
commit385a232229a5b4ee3f4d2a2472bcda28cd8d17b2 (patch)
treeafd52325efdfcefdd7d5d6997672d26f3c9ac0c8 /gcc/fortran/io.cc
parent7d2845da112214f064e7b24531cc67e256b5177e (diff)
downloadgcc-385a232229a5b4ee3f4d2a2472bcda28cd8d17b2.zip
gcc-385a232229a5b4ee3f4d2a2472bcda28cd8d17b2.tar.gz
gcc-385a232229a5b4ee3f4d2a2472bcda28cd8d17b2.tar.bz2
diagnostics: bulletproof opening of SARIF output [PR116978]
Introduce a new RAII class diagnostic_output_file to track ownership of the FILE * for SARIF output. In particular, the .sarif file is now opened immediately, rather than at the end of the compile, and so will fail earlier if the file can't be opened. Doing so fixes a couple of ICEs in -fdiagnostics-format=sarif-file when invoking, say, cc1 directly, rather than from the driver. gcc/ChangeLog: PR other/116978 * diagnostic-format-sarif.cc (sarif_builder::sarif_builder): Gracefully handle "main_input_filename_" being NULL. (sarif_output_format::sarif_output_format): Replace param "base_file_name" with "output_file" and assert that the file was opened successfully and has a non-NULL filename. (sarif_output_format::~sarif_file_output_format): Move responsibility for building the filename and opening the file from here to the creator of the instance. (sarif_output_format::m_base_file_name): Replace with... (sarif_output_format::m_output_file): ...this. (diagnostic_output_format_init_sarif_file): Make "line_maps" param non-const. Gracefully handle "base_file_name" being NULL. Construct the filename and open the file here, rather than in ~sarif_file_output_format, and handle failures immediately here, rather than at the end of the compile. * diagnostic-format-sarif.h: Include "diagnostic-output-file.h". (diagnostic_output_format_init_sarif_file): Make "line_maps" param non-const. * diagnostic-output-file.h: New file. * diagnostic.cc (diagnostic_context::emit_diagnostic): New. (diagnostic_context::emit_diagnostic_va): New. * diagnostic.h (diagnostic_context::emit_diagnostic): New decl. (diagnostic_context::emit_diagnostic_va): New decl. Signed-off-by: David Malcolm <dmalcolm@redhat.com>
Diffstat (limited to 'gcc/fortran/io.cc')
0 files changed, 0 insertions, 0 deletions