diff options
| author | Jason Merrill <jason@redhat.com> | 2006-09-06 21:12:00 -0400 |
|---|---|---|
| committer | Jason Merrill <jason@gcc.gnu.org> | 2006-09-06 21:12:00 -0400 |
| commit | c08cd4c1f169c138784d2a97c47950eed2ae8010 (patch) | |
| tree | fa6902959ab6f3daa9d485ce7bc53e67d2c28f3b /gcc/cp | |
| parent | 6ee3ffe85ea599b1d977615ee31b8421563312c0 (diff) | |
| download | gcc-c08cd4c1f169c138784d2a97c47950eed2ae8010.zip gcc-c08cd4c1f169c138784d2a97c47950eed2ae8010.tar.gz gcc-c08cd4c1f169c138784d2a97c47950eed2ae8010.tar.bz2 | |
re PR c++/27371 (Does not warn about unused function result (__attribute__((warn_unused_result))))
PR c++/27371
* tree-inline.c (copy_result_decl_to_var): New fn.
(declare_return_variable): Use it. Call declare_inline_vars here.
(expand_call_inline): Not here.
* cp/cvt.c (convert_to_void): Strip useless TARGET_EXPR.
* cp/cp-tree.h (TARGET_EXPR_IMPLICIT_P): New macro.
* cp/tree.c (build_cplus_new): Set it.
From-SVN: r116737
Diffstat (limited to 'gcc/cp')
| -rw-r--r-- | gcc/cp/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/cp/cp-tree.h | 6 | ||||
| -rw-r--r-- | gcc/cp/cvt.c | 19 | ||||
| -rw-r--r-- | gcc/cp/tree.c | 1 |
4 files changed, 31 insertions, 0 deletions
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 60d2fb2..9e17cce 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -10,6 +10,11 @@ 2006-09-06 Jason Merrill <jason@redhat.com> + PR c++/27371 + * cvt.c (convert_to_void): Strip useless TARGET_EXPR. + * cp-tree.h (TARGET_EXPR_IMPLICIT_P): New macro. + * tree.c (build_cplus_new): Set it. + PR c++/26696 * cvt.c (convert_to_void): Replace a subexpression with no side effects with void_zero_node. diff --git a/gcc/cp/cp-tree.h b/gcc/cp/cp-tree.h index 3c20afe..f864487 100644 --- a/gcc/cp/cp-tree.h +++ b/gcc/cp/cp-tree.h @@ -55,6 +55,7 @@ struct diagnostic_context; OMP_ATOMIC_DEPENDENT_P (in OMP_ATOMIC) OMP_FOR_GIMPLIFYING_P (in OMP_FOR) BASELINK_QUALIFIED_P (in BASELINK) + TARGET_EXPR_IMPLICIT_P (in TARGET_EXPR) 1: IDENTIFIER_VIRTUAL_P (in IDENTIFIER_NODE) TI_PENDING_TEMPLATE_FLAG. TEMPLATE_PARMS_FOR_INLINE. @@ -3091,6 +3092,11 @@ extern void decl_shadowed_for_var_insert (tree, tree); expression statement. */ #define EXPR_STMT_EXPR(NODE) TREE_OPERAND (EXPR_STMT_CHECK (NODE), 0) +/* True if this TARGET_EXPR was created by build_cplus_new, and so we can + discard it if it isn't useful. */ +#define TARGET_EXPR_IMPLICIT_P(NODE) \ + TREE_LANG_FLAG_0 (TARGET_EXPR_CHECK (NODE)) + /* An enumeration of the kind of tags that C++ accepts. */ enum tag_types { none_type = 0, /* Not a tag type. */ diff --git a/gcc/cp/cvt.c b/gcc/cp/cvt.c index 83b35d6..52b5be4 100644 --- a/gcc/cp/cvt.c +++ b/gcc/cp/cvt.c @@ -892,6 +892,25 @@ convert_to_void (tree expr, const char *implicit) break; } + case TARGET_EXPR: + /* Don't bother with the temporary object returned from a function if + we don't use it and don't need to destroy it. We'll still + allocate space for it in expand_call or declare_return_variable, + but we don't need to track it through all the tree phases. */ + if (0 && TARGET_EXPR_IMPLICIT_P (expr) + && TYPE_HAS_TRIVIAL_DESTRUCTOR (TREE_TYPE (expr))) + { + tree init = TARGET_EXPR_INITIAL (expr); + if (TREE_CODE (init) == AGGR_INIT_EXPR + && !AGGR_INIT_VIA_CTOR_P (init)) + { + tree fn = TREE_OPERAND (init, 0); + expr = build3 (CALL_EXPR, TREE_TYPE (TREE_TYPE (TREE_TYPE (fn))), + fn, TREE_OPERAND (init, 1), NULL_TREE); + } + } + break; + default:; } { diff --git a/gcc/cp/tree.c b/gcc/cp/tree.c index 89941cc..526077a 100644 --- a/gcc/cp/tree.c +++ b/gcc/cp/tree.c @@ -312,6 +312,7 @@ build_cplus_new (tree type, tree init) rval = init; rval = build_target_expr (slot, rval); + TARGET_EXPR_IMPLICIT_P (rval) = 1; return rval; } |