diff options
author | Lewis Hyatt <lhyatt@gmail.com> | 2022-07-01 13:53:34 -0400 |
---|---|---|
committer | Lewis Hyatt <lhyatt@gmail.com> | 2022-07-01 17:33:13 -0400 |
commit | ff64a8c951995cb1214b4d2864a4bd553b60f249 (patch) | |
tree | 6589f5a42a397e511767cbdc0b2c58eb08b7ea75 /gcc/cp/parser.cc | |
parent | 1f76941c09f6f62f4cbf7a9f531ec95268dd2c0a (diff) | |
download | gcc-ff64a8c951995cb1214b4d2864a4bd553b60f249.zip gcc-ff64a8c951995cb1214b4d2864a4bd553b60f249.tar.gz gcc-ff64a8c951995cb1214b4d2864a4bd553b60f249.tar.bz2 |
c++: Minor cleanup in parser.cc
The code to determine whether a given token starts a module directive is
currently repeated in 4 places in parser.cc. I am about to submit a patch
that needs to add it in a 5th place, so since the code is not completely
trivial (needing to check for 3 different token types), it seems worthwhile
to factor this logic into its own function.
gcc/cp/ChangeLog:
* parser.cc (cp_token_is_module_directive): New function
refactoring common code.
(cp_parser_skip_to_closing_parenthesis_1): Use the new function.
(cp_parser_skip_to_end_of_statement): Likewise.
(cp_parser_skip_to_end_of_block_or_statement): Likewise.
(cp_parser_declaration): Likewise.
Diffstat (limited to 'gcc/cp/parser.cc')
-rw-r--r-- | gcc/cp/parser.cc | 26 |
1 files changed, 14 insertions, 12 deletions
diff --git a/gcc/cp/parser.cc b/gcc/cp/parser.cc index 212ed14..6b3763b 100644 --- a/gcc/cp/parser.cc +++ b/gcc/cp/parser.cc @@ -629,6 +629,16 @@ cp_lexer_alloc (void) return lexer; } +/* Return TRUE if token is the start of a module declaration that will be + terminated by a CPP_PRAGMA_EOL token. */ +static inline bool +cp_token_is_module_directive (cp_token *token) +{ + return token->keyword == RID__EXPORT + || token->keyword == RID__MODULE + || token->keyword == RID__IMPORT; +} + /* Create a new main C++ lexer, the lexer that gets tokens from the preprocessor. */ @@ -3833,9 +3843,7 @@ cp_parser_skip_to_closing_parenthesis_1 (cp_parser *parser, break; case CPP_KEYWORD: - if (token->keyword != RID__EXPORT - && token->keyword != RID__MODULE - && token->keyword != RID__IMPORT) + if (!cp_token_is_module_directive (token)) break; /* FALLTHROUGH */ @@ -3936,9 +3944,7 @@ cp_parser_skip_to_end_of_statement (cp_parser* parser) break; case CPP_KEYWORD: - if (token->keyword != RID__EXPORT - && token->keyword != RID__MODULE - && token->keyword != RID__IMPORT) + if (!cp_token_is_module_directive (token)) break; /* FALLTHROUGH */ @@ -4025,9 +4031,7 @@ cp_parser_skip_to_end_of_block_or_statement (cp_parser* parser) break; case CPP_KEYWORD: - if (token->keyword != RID__EXPORT - && token->keyword != RID__MODULE - && token->keyword != RID__IMPORT) + if (!cp_token_is_module_directive (token)) break; /* FALLTHROUGH */ @@ -14958,9 +14962,7 @@ cp_parser_declaration (cp_parser* parser, tree prefix_attrs) else cp_parser_module_export (parser); } - else if (token1->keyword == RID__EXPORT - || token1->keyword == RID__IMPORT - || token1->keyword == RID__MODULE) + else if (cp_token_is_module_directive (token1)) { bool exporting = token1->keyword == RID__EXPORT; cp_token *next = exporting ? token2 : token1; |