diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2020-11-17 09:37:25 +0100 |
|---|---|---|
| committer | Jakub Jelinek <jakub@redhat.com> | 2020-11-17 09:37:25 +0100 |
| commit | 2d8b144a2a61b007f59286731275773f6e167be1 (patch) | |
| tree | ec9410798cbb2815a0d4e9b2080556033274f55e /gcc/c-family | |
| parent | 855ce4cda1a374eb1ce4a24fcde65d4c3d111bcd (diff) | |
| download | gcc-2d8b144a2a61b007f59286731275773f6e167be1.zip gcc-2d8b144a2a61b007f59286731275773f6e167be1.tar.gz gcc-2d8b144a2a61b007f59286731275773f6e167be1.tar.bz2 | |
c: Reject _Atomic type * as last argument to __builtin_*_overflow [PR90628]
During the __builtin_clear_padding implementation, I've noticed we don't
diagnose _Atomic whatever * as last argument to __builtin_*_overflow.
As the storing by that builtin isn't atomic in any way, I think we should
reject it.
2020-11-17 Jakub Jelinek <jakub@redhat.com>
PR c/90628
* c-common.c (check_builtin_function_arguments)
<case BUILT_IN_ADD_OVERFLOW>: Diagnose when last argument is pointer
to _Atomic. For the TYPE_READONLY case, adjust message to be usable
for more builtins and argument positions.
* gcc.dg/builtin-arith-overflow-4.c: New test.
Diffstat (limited to 'gcc/c-family')
| -rw-r--r-- | gcc/c-family/c-common.c | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/gcc/c-family/c-common.c b/gcc/c-family/c-common.c index ab7f642..729bd85 100644 --- a/gcc/c-family/c-common.c +++ b/gcc/c-family/c-common.c @@ -6133,11 +6133,18 @@ check_builtin_function_arguments (location_t loc, vec<location_t> arg_loc, } else if (TYPE_READONLY (TREE_TYPE (TREE_TYPE (args[2])))) { - error_at (ARG_LOCATION (2), "argument 3 in call to function %qE " - "has pointer to %<const%> type (%qT)", fndecl, + error_at (ARG_LOCATION (2), "argument %u in call to function %qE " + "has pointer to %qs type (%qT)", 3, fndecl, "const", TREE_TYPE (args[2])); return false; } + else if (TYPE_ATOMIC (TREE_TYPE (TREE_TYPE (args[2])))) + { + error_at (ARG_LOCATION (2), "argument %u in call to function %qE " + "has pointer to %qs type (%qT)", 3, fndecl, + "_Atomic", TREE_TYPE (args[2])); + return false; + } return true; } return false; |