c++: Add warning about missing 'requires'

I noticed that concepts-lambda14.C had two useless requires-expressions:

  static_assert(requires { C<T>; });

always succeeds, because C<T> is always a valid expression for any type,
regardless of whether C is satisfied for a particular type.  Presumably the
user means

  static_assert(requires { requires C<T>; });

to make the C<T> a nested-requirement.  Of course,

  static_assert(C<T>);

is much simpler and means the same thing; this is more relevant in the
middle of a longer requires-expression, such as the bug this warning found
in cmcstl2:

  template<class I>
  META_CONCEPT input_iterator =
	  input_or_output_iterator<I> &&
	  readable<I> &&
	  requires(I& i, const I& ci) {
		  typename iterator_category_t<I>;
		  derived_from<iterator_category_t<I>, input_iterator_tag>;
		  i++;
	  };

where 'requires' is missing before 'derived_from'.

gcc/ChangeLog:

	* doc/invoke.texi: Document -Wmissing-requires.

gcc/c-family/ChangeLog:

	* c.opt: Add -Wmissing-requires.

gcc/cp/ChangeLog:

	* parser.c (cp_parser_simple_requirement): Warn about missing
	requires.

gcc/testsuite/ChangeLog:

	* g++.dg/cpp2a/concepts-lambda14.C: Add expected warnings.

1 files changed, 4 insertions, 0 deletions

diff --git a/gcc/c-family/c.opt b/gcc/c-family/c.opt
index 9192970..c5fe900 100644
--- a/gcc/c-family/c.opt
+++ b/gcc/c-family/c.opt
@@ -839,6 +839,10 @@ Wmissing-field-initializers
 C ObjC C++ ObjC++ Var(warn_missing_field_initializers) Warning EnabledBy(Wextra)
 Warn about missing fields in struct initializers.
 
+Wmissing-requires
+C++ ObjC++ Var(warn_missing_requires) Init(1) Warning
+Warn about likely missing requires keyword.
+
 Wmultistatement-macros
 C ObjC C++ ObjC++ Var(warn_multistatement_macros) Warning LangEnabledBy(C ObjC C++ ObjC++,Wall)
 Warn about unsafe macros expanding to multiple statements used as a body of a clause such as if, else, while, switch, or for.