diff options
author | David Malcolm <dmalcolm@redhat.com> | 2021-01-05 20:54:50 -0500 |
---|---|---|
committer | David Malcolm <dmalcolm@redhat.com> | 2021-01-05 20:54:50 -0500 |
commit | ac3966e315ada63eb379d560a012fa77c3909155 (patch) | |
tree | 0a12bca0d543f8bcd8b12e8ea831ba644af08f9a /gcc/analyzer/region-model-reachability.cc | |
parent | 23fc2be633c61f24a4fbd4096c669e7147ca44ae (diff) | |
download | gcc-ac3966e315ada63eb379d560a012fa77c3909155.zip gcc-ac3966e315ada63eb379d560a012fa77c3909155.tar.gz gcc-ac3966e315ada63eb379d560a012fa77c3909155.tar.bz2 |
analyzer: fix false leaks when writing through unknown ptrs [PR97072]
gcc/analyzer/ChangeLog:
PR analyzer/97072
* region-model-reachability.cc (reachable_regions::init_cluster):
Convert symbolic region handling to a switch statement. Add cases
to handle SK_UNKNOWN and SK_CONJURED.
gcc/testsuite/ChangeLog:
PR analyzer/97072
* gcc.dg/analyzer/pr97072.c: New test.
Diffstat (limited to 'gcc/analyzer/region-model-reachability.cc')
-rw-r--r-- | gcc/analyzer/region-model-reachability.cc | 36 |
1 files changed, 27 insertions, 9 deletions
diff --git a/gcc/analyzer/region-model-reachability.cc b/gcc/analyzer/region-model-reachability.cc index daf7852..a988ffc 100644 --- a/gcc/analyzer/region-model-reachability.cc +++ b/gcc/analyzer/region-model-reachability.cc @@ -88,20 +88,38 @@ reachable_regions::init_cluster (const region *base_reg) if (m_store->escaped_p (base_reg)) add (base_reg, true); - /* If BASE_REG is *INIT_VAL(REG) for some other REG, see if REG is - unbound and untouched. If so, then add BASE_REG as a root. */ if (const symbolic_region *sym_reg = base_reg->dyn_cast_symbolic_region ()) { const svalue *ptr = sym_reg->get_pointer (); - if (const initial_svalue *init_sval = ptr->dyn_cast_initial_svalue ()) + switch (ptr->get_kind ()) { - const region *init_sval_reg = init_sval->get_region (); - const region *other_base_reg = init_sval_reg->get_base_region (); - const binding_cluster *other_cluster - = m_store->get_cluster (other_base_reg); - if (other_cluster == NULL - || !other_cluster->touched_p ()) + default: + break; + case SK_INITIAL: + { + /* If BASE_REG is *INIT_VAL(REG) for some other REG, see if REG is + unbound and untouched. If so, then add BASE_REG as a root. */ + const initial_svalue *init_sval + = as_a <const initial_svalue *> (ptr); + const region *init_sval_reg = init_sval->get_region (); + const region *other_base_reg = init_sval_reg->get_base_region (); + const binding_cluster *other_cluster + = m_store->get_cluster (other_base_reg); + if (other_cluster == NULL + || !other_cluster->touched_p ()) + add (base_reg, true); + } + break; + + case SK_UNKNOWN: + case SK_CONJURED: + { + /* If this cluster is due to dereferencing an unknown/conjured + pointer, any values written through the pointer could still + be live. */ add (base_reg, true); + } + break; } } } |