aboutsummaryrefslogtreecommitdiff
path: root/gcc/ada/libgnat
diff options
context:
space:
mode:
authorPascal Obry <obry@adacore.com>2020-05-22 18:37:17 +0200
committerPierre-Marie de Rodat <derodat@adacore.com>2020-07-10 05:16:21 -0400
commit002f8329d208e3c3f032bf2ce914a70cfe02ef9f (patch)
treeccd895eac32019c2aff02ae16ee87a4b114b974e /gcc/ada/libgnat
parent715aea70f359a97a28aaa5e6fb4d3688cebbbcd6 (diff)
downloadgcc-002f8329d208e3c3f032bf2ce914a70cfe02ef9f.zip
gcc-002f8329d208e3c3f032bf2ce914a70cfe02ef9f.tar.gz
gcc-002f8329d208e3c3f032bf2ce914a70cfe02ef9f.tar.bz2
[Ada] Fix memory leak in routine Wait_On_Socket
gcc/ada/ * libgnat/g-socket.adb (Wait_On_Socket): Fix memory leaks and file descriptor leaks. A memory leak was created each time the routine was called without a selector (Selector = Null). Also, in case of exception in the routine a memory leak and descriptor leak was created as the created file selector was not closed.
Diffstat (limited to 'gcc/ada/libgnat')
-rw-r--r--gcc/ada/libgnat/g-socket.adb22
1 files changed, 15 insertions, 7 deletions
diff --git a/gcc/ada/libgnat/g-socket.adb b/gcc/ada/libgnat/g-socket.adb
index 8f65aea..da631e3 100644
--- a/gcc/ada/libgnat/g-socket.adb
+++ b/gcc/ada/libgnat/g-socket.adb
@@ -2028,7 +2028,11 @@ package body GNAT.Sockets is
type Local_Selector_Access is access Selector_Type;
for Local_Selector_Access'Storage_Size use Selector_Type'Size;
- S : Selector_Access;
+ procedure Unchecked_Free is new Ada.Unchecked_Deallocation
+ (Selector_Type, Local_Selector_Access);
+
+ Local_S : Local_Selector_Access;
+ S : Selector_Access;
-- Selector to use for waiting
R_Fd_Set : Socket_Set_Type;
@@ -2038,12 +2042,9 @@ package body GNAT.Sockets is
-- Create selector if not provided by the user
if Selector = null then
- declare
- Local_S : constant Local_Selector_Access := new Selector_Type;
- begin
- S := Local_S.all'Unchecked_Access;
- Create_Selector (S.all);
- end;
+ Local_S := new Selector_Type;
+ S := Local_S.all'Unchecked_Access;
+ Create_Selector (S.all);
else
S := Selector.all'Access;
@@ -2059,7 +2060,14 @@ package body GNAT.Sockets is
if Selector = null then
Close_Selector (S.all);
+ Unchecked_Free (Local_S);
end if;
+ exception
+ when others =>
+ if Selector = null then
+ Close_Selector (S.all);
+ Unchecked_Free (Local_S);
+ end if;
end Wait_On_Socket;
-----------------