diff options
| author | Eric Botcazou <ebotcazou@adacore.com> | 2024-01-22 23:56:37 +0100 |
|---|---|---|
| committer | Marc Poulhiès <poulhies@adacore.com> | 2024-05-21 09:27:44 +0200 |
| commit | 15ac30dbe8e80453b980b6d242f5b1f9a025e2ca (patch) | |
| tree | 3769ebcbbd119df078298b62132b244281b4e720 /gcc/ada/gcc-interface/decl.cc | |
| parent | 0967e06caaa606eec7b2f222bb9926ec6523ea02 (diff) | |
| download | gcc-15ac30dbe8e80453b980b6d242f5b1f9a025e2ca.zip gcc-15ac30dbe8e80453b980b6d242f5b1f9a025e2ca.tar.gz gcc-15ac30dbe8e80453b980b6d242f5b1f9a025e2ca.tar.bz2 | |
ada: Fix assembler error for gigantic library-level object on 64-bit Windows
Most small 64-bit code models have a limit of 2 GB on the span of binaries,
so we also use the limit for the size of the largest statically allocatable
object by the compiler. If the limit is topped, the compiler switches over
to a dynamic allocation (if not forbidden) after giving a warning.
gcc/ada/
* gcc-interface/decl.cc (gnat_to_gnu_entity) <E_Variable>: Give a
warning for a statically allocated object whose size is constant,
valid but too large.
(allocatable_size_p): In the static case, return false for a size
that is constant, valid but too large.
Diffstat (limited to 'gcc/ada/gcc-interface/decl.cc')
| -rw-r--r-- | gcc/ada/gcc-interface/decl.cc | 27 |
1 files changed, 21 insertions, 6 deletions
diff --git a/gcc/ada/gcc-interface/decl.cc b/gcc/ada/gcc-interface/decl.cc index 41d5c29..e16ee6e 100644 --- a/gcc/ada/gcc-interface/decl.cc +++ b/gcc/ada/gcc-interface/decl.cc @@ -1415,10 +1415,22 @@ gnat_to_gnu_entity (Entity_Id gnat_entity, tree gnu_expr, bool definition) false); } - if (TREE_CODE (TYPE_SIZE_UNIT (gnu_alloc_type)) == INTEGER_CST - && !valid_constant_size_p (TYPE_SIZE_UNIT (gnu_alloc_type))) - post_error ("??Storage_Error will be raised at run time!", - gnat_entity); + /* Give a warning if the size is constant but too large. */ + if (TREE_CODE (TYPE_SIZE_UNIT (gnu_alloc_type)) == INTEGER_CST) + { + if (valid_constant_size_p (TYPE_SIZE_UNIT (gnu_alloc_type))) + { + post_error + ("??too large object cannot be allocated statically", + gnat_entity); + post_error ("\\?dynamic allocation will be used instead", + gnat_entity); + } + + else + post_error ("??Storage_Error will be raised at run time!", + gnat_entity); + } gnu_expr = build_allocator (gnu_alloc_type, gnu_expr, gnu_type, @@ -6822,9 +6834,12 @@ constructor_address_p (tree gnu_expr) static bool allocatable_size_p (tree gnu_size, bool static_p) { - /* We can allocate a fixed size if it is a valid for the middle-end. */ + /* We can allocate a fixed size if it is a valid for the middle-end but, for + a static allocation, we do not allocate more than 2 GB because this would + very likely be unintended and problematic for usual code models. */ if (TREE_CODE (gnu_size) == INTEGER_CST) - return valid_constant_size_p (gnu_size); + return valid_constant_size_p (gnu_size) + && (!static_p || tree_to_uhwi (gnu_size) <= INT_MAX); /* We can allocate a variable size if this isn't a static allocation. */ else |