diff options
| author | Jason Merrill <jason@redhat.com> | 2020-10-15 12:54:16 -0400 |
|---|---|---|
| committer | Jason Merrill <jason@redhat.com> | 2020-10-15 13:27:37 -0400 |
| commit | f3ee94724686b82556c07b4d33821ae973eb9aba (patch) | |
| tree | c95ec49d46d3521bd44cd22bdc5bb386ea2fb5cd | |
| parent | 782ebeaa681163cfd0c59f03cd850fdd52287b79 (diff) | |
| download | gcc-f3ee94724686b82556c07b4d33821ae973eb9aba.zip gcc-f3ee94724686b82556c07b4d33821ae973eb9aba.tar.gz gcc-f3ee94724686b82556c07b4d33821ae973eb9aba.tar.bz2 | |
c++: Fix [[deprecated]] and implicit operator==. [PR97358]
Trying to diagnose the problem with an implicit copy function breaks if the
function isn't actually a copy function.
gcc/cp/ChangeLog:
PR c++/95844
* decl.c (copy_fn_p): Return false for a function that is neither a
constructor nor an assignment operator.
(move_signature_fn_p): Likewise.
gcc/testsuite/ChangeLog:
PR c++/95844
* g++.dg/cpp2a/spaceship-eq10.C: New test.
| -rw-r--r-- | gcc/cp/decl.c | 8 | ||||
| -rw-r--r-- | gcc/testsuite/g++.dg/cpp2a/spaceship-eq10.C | 11 |
2 files changed, 19 insertions, 0 deletions
diff --git a/gcc/cp/decl.c b/gcc/cp/decl.c index 2f1a2f0..5f370e6 100644 --- a/gcc/cp/decl.c +++ b/gcc/cp/decl.c @@ -14169,6 +14169,10 @@ copy_fn_p (const_tree d) accept those as copy functions. */ return 0; + if (!DECL_CONSTRUCTOR_P (d) + && DECL_NAME (d) != assign_op_identifier) + return 0; + args = FUNCTION_FIRST_USER_PARMTYPE (d); if (!args) return 0; @@ -14242,6 +14246,10 @@ move_signature_fn_p (const_tree d) tree arg_type; bool result = false; + if (!DECL_CONSTRUCTOR_P (d) + && DECL_NAME (d) != assign_op_identifier) + return 0; + args = FUNCTION_FIRST_USER_PARMTYPE (d); if (!args) return 0; diff --git a/gcc/testsuite/g++.dg/cpp2a/spaceship-eq10.C b/gcc/testsuite/g++.dg/cpp2a/spaceship-eq10.C new file mode 100644 index 0000000..93f5e253 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp2a/spaceship-eq10.C @@ -0,0 +1,11 @@ +// PR c++/95844 +// { dg-do compile { target c++20 } } + +#include <compare> + +struct F { + [[deprecated("oh no")]] std::strong_ordering operator<=>(const F&) const = default; // { dg-message "" } +}; +void use_f(F f) { + void(f == f); // { dg-warning "deprecated" } +} |