diff options
| author | Owen Avery <powerboat9.gamer@gmail.com> | 2025-03-25 18:18:21 -0400 |
|---|---|---|
| committer | Arthur Cohen <arthur.cohen@embecosm.com> | 2025-03-31 21:07:16 +0200 |
| commit | f100bd794c26126c37ef7e3e9cb023a06735f429 (patch) | |
| tree | af5bb892ba0b185d9e68477b12abba78370a1007 | |
| parent | bca80539a2b340ac67090d615b8901ca75818390 (diff) | |
| download | gcc-f100bd794c26126c37ef7e3e9cb023a06735f429.zip gcc-f100bd794c26126c37ef7e3e9cb023a06735f429.tar.gz gcc-f100bd794c26126c37ef7e3e9cb023a06735f429.tar.bz2 | |
gccrs: Fix validation of constant items
gcc/rust/ChangeLog:
* checks/errors/rust-ast-validation.cc
(ASTValidation::visit): Allow constant items lacking expressions
if and only if they're associated with a trait definition, not a
trait implementation.
gcc/testsuite/ChangeLog:
* rust/compile/issue-3541-1.rs: New test.
* rust/compile/issue-3541-2.rs: Likewise.
Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
| -rw-r--r-- | gcc/rust/checks/errors/rust-ast-validation.cc | 2 | ||||
| -rw-r--r-- | gcc/testsuite/rust/compile/issue-3541-1.rs | 5 | ||||
| -rw-r--r-- | gcc/testsuite/rust/compile/issue-3541-2.rs | 3 |
3 files changed, 9 insertions, 1 deletions
diff --git a/gcc/rust/checks/errors/rust-ast-validation.cc b/gcc/rust/checks/errors/rust-ast-validation.cc index 59b2805..0f4bdeb 100644 --- a/gcc/rust/checks/errors/rust-ast-validation.cc +++ b/gcc/rust/checks/errors/rust-ast-validation.cc @@ -56,7 +56,7 @@ ASTValidation::visit (AST::LoopLabel &label) void ASTValidation::visit (AST::ConstantItem &const_item) { - if (!const_item.has_expr () && ctx.peek () != Kind::TRAIT_IMPL) + if (!const_item.has_expr () && ctx.peek () != Kind::TRAIT) { rust_error_at (const_item.get_locus (), "associated constant in %<impl%> without body"); diff --git a/gcc/testsuite/rust/compile/issue-3541-1.rs b/gcc/testsuite/rust/compile/issue-3541-1.rs new file mode 100644 index 0000000..6b47b7e --- /dev/null +++ b/gcc/testsuite/rust/compile/issue-3541-1.rs @@ -0,0 +1,5 @@ +impl B for u32 { + const BAR: i32; // { dg-error "associated constant in .impl." } +} + +trait B {} diff --git a/gcc/testsuite/rust/compile/issue-3541-2.rs b/gcc/testsuite/rust/compile/issue-3541-2.rs new file mode 100644 index 0000000..9f17eed --- /dev/null +++ b/gcc/testsuite/rust/compile/issue-3541-2.rs @@ -0,0 +1,3 @@ +trait B { + const BAR: i32; +} |