diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2024-02-15 13:55:49 +0100 |
|---|---|---|
| committer | Jakub Jelinek <jakub@redhat.com> | 2024-02-15 13:55:49 +0100 |
| commit | f0b1cf01782ba975cfda32800c91076df78058d6 (patch) | |
| tree | 6b2ef9623c21c6152d885343a3a5da91c4b13701 | |
| parent | 5329b94188206e9f8c96d9a63931c415fa5d39d7 (diff) | |
| download | gcc-f0b1cf01782ba975cfda32800c91076df78058d6.zip gcc-f0b1cf01782ba975cfda32800c91076df78058d6.tar.gz gcc-f0b1cf01782ba975cfda32800c91076df78058d6.tar.bz2 | |
gccrs: Avoid *.bak suffixed tests - use dg-skip-if instead
On Fri, Feb 09, 2024 at 11:03:38AM +0100, Jakub Jelinek wrote:
> On Wed, Feb 07, 2024 at 12:43:59PM +0100, arthur.cohen@embecosm.com wrote:
> > This patch introduces one regression because generics are getting better
> > understood over time. The code here used to apply generics with the same
> > symbol from previous segments which was a bit of a hack with out limited
> > inference variable support. The regression looks like it will be related
> > to another issue which needs to default integer inference variables much
> > more aggresivly to default integer.
> >
> > Fixes #2723
> > * rust/compile/issue-1773.rs: Moved to...
> > * rust/compile/issue-1773.rs.bak: ...here.
>
> Please don't use such suffixes in the testsuite.
> Either delete the testcase, or xfail it somehow until the bug is fixed.
To be precise, I have scripts to look for backup files in the tree (*~,
*.bak, *.orig, *.rej etc.) and this stands in the way several times a day.
Here is a fix for that in patch form, tested on x86_64-linux with
make check-rust RUNTESTFLAGS='compile.exp=issue-1773.rs'
2024-02-15 Jakub Jelinek <jakub@redhat.com>
* rust/compile/issue-1773.rs.bak: Rename to ...
* rust/compile/issue-1773.rs: ... this. Add dg-skip-if directive.
| -rw-r--r-- | gcc/testsuite/rust/compile/issue-1773.rs (renamed from gcc/testsuite/rust/compile/issue-1773.rs.bak) | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/gcc/testsuite/rust/compile/issue-1773.rs.bak b/gcc/testsuite/rust/compile/issue-1773.rs index a4542aea0..468497a 100644 --- a/gcc/testsuite/rust/compile/issue-1773.rs.bak +++ b/gcc/testsuite/rust/compile/issue-1773.rs @@ -1,4 +1,5 @@ #[lang = "sized"] +// { dg-skip-if "" { *-*-* } } pub trait Sized {} trait Foo<T> { |