diff options
| author | Feng Xue <fxue@os.amperecomputing.com> | 2024-06-16 13:33:52 +0800 |
|---|---|---|
| committer | Feng Xue <fxue@os.amperecomputing.com> | 2024-06-20 10:37:00 +0800 |
| commit | ecbc96bb2873e453b0bd33d602ce34ad0d9d9cfd (patch) | |
| tree | 04c64799093c0326b601c5bee3b74ad522bb4e5a | |
| parent | b9c369d900ccfbd2271028611af3f08b5cf6f998 (diff) | |
| download | gcc-ecbc96bb2873e453b0bd33d602ce34ad0d9d9cfd.zip gcc-ecbc96bb2873e453b0bd33d602ce34ad0d9d9cfd.tar.gz gcc-ecbc96bb2873e453b0bd33d602ce34ad0d9d9cfd.tar.bz2 | |
vect: Tighten an assertion for lane-reducing in transform
According to logic of code nearby the assertion, all lane-reducing operations
should not appear, not just DOT_PROD_EXPR. Since "use_mask_by_cond_expr_p"
treats SAD_EXPR same as DOT_PROD_EXPR, and WIDEN_SUM_EXPR should not be allowed
by the following assertion "gcc_assert (commutative_binary_op_p (...))", so
tighten the assertion.
2024-06-16 Feng Xue <fxue@os.amperecomputing.com>
gcc/
* tree-vect-loop.cc (vect_transform_reduction): Change assertion to
cover all lane-reducing ops.
| -rw-r--r-- | gcc/tree-vect-loop.cc | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/gcc/tree-vect-loop.cc b/gcc/tree-vect-loop.cc index 1d60ac4..347dac9 100644 --- a/gcc/tree-vect-loop.cc +++ b/gcc/tree-vect-loop.cc @@ -8618,7 +8618,8 @@ vect_transform_reduction (loop_vec_info loop_vinfo, } bool single_defuse_cycle = STMT_VINFO_FORCE_SINGLE_CYCLE (reduc_info); - gcc_assert (single_defuse_cycle || lane_reducing_op_p (code)); + bool lane_reducing = lane_reducing_op_p (code); + gcc_assert (single_defuse_cycle || lane_reducing); /* Create the destination vector */ tree scalar_dest = gimple_get_lhs (stmt_info->stmt); @@ -8674,8 +8675,9 @@ vect_transform_reduction (loop_vec_info loop_vinfo, tree vop[3] = { vec_oprnds[0][i], vec_oprnds[1][i], NULL_TREE }; if (masked_loop_p && !mask_by_cond_expr) { - /* No conditional ifns have been defined for dot-product yet. */ - gcc_assert (code != DOT_PROD_EXPR); + /* No conditional ifns have been defined for lane-reducing op + yet. */ + gcc_assert (!lane_reducing); /* Make sure that the reduction accumulator is vop[0]. */ if (reduc_index == 1) |