aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaolo Carlini <paolo.carlini@oracle.com>2015-03-25 09:57:06 +0000
committerPaolo Carlini <paolo@gcc.gnu.org>2015-03-25 09:57:06 +0000
commitea348bbe596297d82466a2000dc4c14d2ddc5eac (patch)
treed7759bc38009521bb22033d00f4537a6f506d17f
parentc09a3914dc36c1046280b591cb468712b0782ea8 (diff)
downloadgcc-ea348bbe596297d82466a2000dc4c14d2ddc5eac.zip
gcc-ea348bbe596297d82466a2000dc4c14d2ddc5eac.tar.gz
gcc-ea348bbe596297d82466a2000dc4c14d2ddc5eac.tar.bz2
re PR libstdc++/65543 (rvalue stream insertion and extraction operators incorrectly implemented)
2015-03-25 Paolo Carlini <paolo.carlini@oracle.com> PR libstdc++/65543 * include/std/istream (operator>>(basic_istream<>&&, _Tp&): Revert thinko in r150387. * include/std/ostream (operator<<(basic_ostream<>&&, const _Tp&): Likewise. * testsuite/27_io/rvalue_streams-2.cc: New. From-SVN: r221655
-rw-r--r--libstdc++-v3/ChangeLog9
-rw-r--r--libstdc++-v3/include/std/istream5
-rw-r--r--libstdc++-v3/include/std/ostream5
-rw-r--r--libstdc++-v3/testsuite/27_io/rvalue_streams-2.cc35
4 files changed, 52 insertions, 2 deletions
diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog
index 4758be2..d4611b8 100644
--- a/libstdc++-v3/ChangeLog
+++ b/libstdc++-v3/ChangeLog
@@ -1,3 +1,12 @@
+2015-03-25 Paolo Carlini <paolo.carlini@oracle.com>
+
+ PR libstdc++/65543
+ * include/std/istream (operator>>(basic_istream<>&&, _Tp&): Revert
+ thinko in r150387.
+ * include/std/ostream (operator<<(basic_ostream<>&&, const _Tp&):
+ Likewise.
+ * testsuite/27_io/rvalue_streams-2.cc: New.
+
2015-03-24 Jonathan Wakely <jwakely@redhat.com>
PR libstdc++/33394
diff --git a/libstdc++-v3/include/std/istream b/libstdc++-v3/include/std/istream
index 9deef43..74c0d81 100644
--- a/libstdc++-v3/include/std/istream
+++ b/libstdc++-v3/include/std/istream
@@ -922,7 +922,10 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
template<typename _CharT, typename _Traits, typename _Tp>
inline basic_istream<_CharT, _Traits>&
operator>>(basic_istream<_CharT, _Traits>&& __is, _Tp& __x)
- { return (__is >> __x); }
+ {
+ __is >> __x;
+ return __is;
+ }
#endif // C++11
_GLIBCXX_END_NAMESPACE_VERSION
diff --git a/libstdc++-v3/include/std/ostream b/libstdc++-v3/include/std/ostream
index decb29a..151c42be 100644
--- a/libstdc++-v3/include/std/ostream
+++ b/libstdc++-v3/include/std/ostream
@@ -626,7 +626,10 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
template<typename _CharT, typename _Traits, typename _Tp>
inline basic_ostream<_CharT, _Traits>&
operator<<(basic_ostream<_CharT, _Traits>&& __os, const _Tp& __x)
- { return (__os << __x); }
+ {
+ __os << __x;
+ return __os;
+ }
#endif // C++11
_GLIBCXX_END_NAMESPACE_VERSION
diff --git a/libstdc++-v3/testsuite/27_io/rvalue_streams-2.cc b/libstdc++-v3/testsuite/27_io/rvalue_streams-2.cc
new file mode 100644
index 0000000..d9b6146
--- /dev/null
+++ b/libstdc++-v3/testsuite/27_io/rvalue_streams-2.cc
@@ -0,0 +1,35 @@
+// { dg-options "-std=gnu++11" }
+// { dg-do compile }
+
+// Copyright (C) 2015 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library. This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3. If not see
+// <http://www.gnu.org/licenses/>.
+
+#include <sstream>
+
+struct A {};
+
+void operator<<(std::ostream&, const A&) { }
+void operator>>(std::istream&, A&) { }
+
+// PR libstdc++/65543
+int main()
+{
+ A a;
+
+ std::ostringstream() << a;
+ std::istringstream() >> a;
+}