diff options
author | Jakub Jelinek <jakub@redhat.com> | 2012-03-22 20:25:36 +0100 |
---|---|---|
committer | Jakub Jelinek <jakub@gcc.gnu.org> | 2012-03-22 20:25:36 +0100 |
commit | c140ddf3923d59603aa2ceb834085ab159b77972 (patch) | |
tree | 939527349ade70d1f8b4bee64cb898cba3de8246 | |
parent | e75b54a2d932929a9b2e940c5aad1ef33a86c008 (diff) | |
download | gcc-c140ddf3923d59603aa2ceb834085ab159b77972.zip gcc-c140ddf3923d59603aa2ceb834085ab159b77972.tar.gz gcc-c140ddf3923d59603aa2ceb834085ab159b77972.tar.bz2 |
re PR middle-end/52547 (ICE with openmp with nested function which requires a trampoline)
PR middle-end/52547
* tree-nested.c (convert_tramp_reference_stmt): Call declare_vars
on any new_local_var_chain vars declared during recursing on
GIMPLE_OMP_PARALLEL or GIMPLE_OMP_TASK body.
* testsuite/libgomp.c/pr52547.c: New test.
From-SVN: r185707
-rw-r--r-- | gcc/ChangeLog | 7 | ||||
-rw-r--r-- | gcc/tree-nested.c | 24 | ||||
-rw-r--r-- | libgomp/ChangeLog | 5 | ||||
-rw-r--r-- | libgomp/testsuite/libgomp.c/pr52547.c | 36 |
4 files changed, 69 insertions, 3 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 3dde73b..c27c721 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2012-03-22 Jakub Jelinek <jakub@redhat.com> + + PR middle-end/52547 + * tree-nested.c (convert_tramp_reference_stmt): Call declare_vars + on any new_local_var_chain vars declared during recursing on + GIMPLE_OMP_PARALLEL or GIMPLE_OMP_TASK body. + 2012-03-22 Uros Bizjak <ubizjak@gmail.com> * config/alpha/alpha.h (ASM_OUTPUT_ALIGN): Move to config/alpha/elf.h diff --git a/gcc/tree-nested.c b/gcc/tree-nested.c index ae3a8dd..8851f3c 100644 --- a/gcc/tree-nested.c +++ b/gcc/tree-nested.c @@ -1954,6 +1954,7 @@ static tree convert_tramp_reference_stmt (gimple_stmt_iterator *gsi, bool *handled_ops_p, struct walk_stmt_info *wi) { + struct nesting_info *info = (struct nesting_info *) wi->info; gimple stmt = gsi_stmt (*gsi); switch (gimple_code (stmt)) @@ -1966,16 +1967,33 @@ convert_tramp_reference_stmt (gimple_stmt_iterator *gsi, bool *handled_ops_p, for (i = 0; i < nargs; i++) walk_tree (gimple_call_arg_ptr (stmt, i), convert_tramp_reference_op, wi, NULL); + break; + } - *handled_ops_p = true; - return NULL_TREE; + case GIMPLE_OMP_PARALLEL: + case GIMPLE_OMP_TASK: + { + tree save_local_var_chain; + walk_gimple_op (stmt, convert_tramp_reference_op, wi); + save_local_var_chain = info->new_local_var_chain; + info->new_local_var_chain = NULL; + walk_body (convert_tramp_reference_stmt, convert_tramp_reference_op, + info, gimple_omp_body (stmt)); + if (info->new_local_var_chain) + declare_vars (info->new_local_var_chain, + gimple_seq_first_stmt (gimple_omp_body (stmt)), + false); + info->new_local_var_chain = save_local_var_chain; } + break; default: + *handled_ops_p = false; + return NULL_TREE; break; } - *handled_ops_p = false; + *handled_ops_p = true; return NULL_TREE; } diff --git a/libgomp/ChangeLog b/libgomp/ChangeLog index e227ebf..5bed2c6 100644 --- a/libgomp/ChangeLog +++ b/libgomp/ChangeLog @@ -1,3 +1,8 @@ +2012-03-22 Jakub Jelinek <jakub@redhat.com> + + PR middle-end/52547 + * testsuite/libgomp.c/pr52547.c: New test. + 2012-03-16 Bernhard Reutner-Fischer <aldot@gcc.gnu.org> * testsuite/lib/libgomp.exp: load fortran-modules.exp diff --git a/libgomp/testsuite/libgomp.c/pr52547.c b/libgomp/testsuite/libgomp.c/pr52547.c new file mode 100644 index 0000000..f746e2e --- /dev/null +++ b/libgomp/testsuite/libgomp.c/pr52547.c @@ -0,0 +1,36 @@ +/* PR middle-end/52547 */ +/* { dg-do run } */ + +extern void abort (void); + +__attribute__((noinline, noclone)) int +baz (int *x, int (*fn) (int *)) +{ + return fn (x); +} + +__attribute__((noinline, noclone)) int +foo (int x, int *y) +{ + int i, e = 0; +#pragma omp parallel for reduction(|:e) + for (i = 0; i < x; ++i) + { + __label__ lab; + int bar (int *z) { return z - y; } + if (baz (&y[i], bar) != i) + e |= 1; + } + return e; +} + +int +main () +{ + int a[100], i; + for (i = 0; i < 100; i++) + a[i] = i; + if (foo (100, a)) + abort (); + return 0; +} |