diff options
author | Nathan Sidwell <nathan@codesourcery.com> | 2010-09-09 14:12:57 +0000 |
---|---|---|
committer | Nathan Sidwell <nathan@gcc.gnu.org> | 2010-09-09 14:12:57 +0000 |
commit | ba885ec559ca39e0dc23641dbbe67cc0072378f3 (patch) | |
tree | da6907a1c5c815841942c5773bfc6c02f7b889e8 | |
parent | e3cdb7cf9a0d934b9cdc24d40d730141e5752f60 (diff) | |
download | gcc-ba885ec559ca39e0dc23641dbbe67cc0072378f3.zip gcc-ba885ec559ca39e0dc23641dbbe67cc0072378f3.tar.gz gcc-ba885ec559ca39e0dc23641dbbe67cc0072378f3.tar.bz2 |
configure.ac (gnu_indirect_function): New test.
* configure.ac (gnu_indirect_function): New test.
* configure: Rebuilt.
* config.in (HAVE_GAS_INDIRECT_FUNCTION): New.
* defaults.h (IFUNC_ASM_TYPE): Provide default.
* doc/extend.texi (Function Attributes): Document ifunc.
* varasm.c (do_assemble_alias): Deal with ifuncs too.
c-family/
* c-common.c (handle_alias_ifunc_attribute): New, broken out of ...
(handle_alias_attribute): ... here.
(handle_ifunc_attribute): New.
testsuite/
* lib/target-supports-dg.exp (dg-require-ifunc): New.
* lib/target-supports.exp (check_ifunc_available): New.
* gcc.dg/attr-ifunc-1.c: New.
* gcc.dg/attr-ifunc-2.c: New.
* gcc.dg/attr-ifunc-3.c: New.
* gcc.dg/attr-ifunc-4.c: New.
* gcc.dg/attr-ifunc-5.c: New.
* testsuite/g++.dg/ext/attr-ifunc-1.C
* testsuite/g++.dg/ext/attr-ifunc-2.C
* testsuite/g++.dg/ext/attr-ifunc-3.C
* testsuite/g++.dg/ext/attr-ifunc-4.C
From-SVN: r164110
-rw-r--r-- | gcc/ChangeLog | 10 | ||||
-rw-r--r-- | gcc/c-family/ChangeLog | 6 | ||||
-rw-r--r-- | gcc/c-family/c-common.c | 67 | ||||
-rw-r--r-- | gcc/config.in | 3 | ||||
-rwxr-xr-x | gcc/configure | 42 | ||||
-rw-r--r-- | gcc/configure.ac | 13 | ||||
-rw-r--r-- | gcc/defaults.h | 4 | ||||
-rw-r--r-- | gcc/doc/extend.texi | 60 | ||||
-rw-r--r-- | gcc/testsuite/ChangeLog | 14 | ||||
-rw-r--r-- | gcc/testsuite/g++.dg/ext/attr-ifunc-1.C | 34 | ||||
-rw-r--r-- | gcc/testsuite/g++.dg/ext/attr-ifunc-2.C | 38 | ||||
-rw-r--r-- | gcc/testsuite/g++.dg/ext/attr-ifunc-3.C | 39 | ||||
-rw-r--r-- | gcc/testsuite/g++.dg/ext/attr-ifunc-4.C | 44 | ||||
-rw-r--r-- | gcc/testsuite/gcc.dg/attr-ifunc-1.c | 23 | ||||
-rw-r--r-- | gcc/testsuite/gcc.dg/attr-ifunc-2.c | 28 | ||||
-rw-r--r-- | gcc/testsuite/gcc.dg/attr-ifunc-3.c | 27 | ||||
-rw-r--r-- | gcc/testsuite/gcc.dg/attr-ifunc-4.c | 23 | ||||
-rw-r--r-- | gcc/testsuite/gcc.dg/attr-ifunc-5.c | 23 | ||||
-rw-r--r-- | gcc/testsuite/lib/target-supports-dg.exp | 15 | ||||
-rw-r--r-- | gcc/testsuite/lib/target-supports.exp | 50 | ||||
-rw-r--r-- | gcc/varasm.c | 14 |
21 files changed, 562 insertions, 15 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 5aeade6..c8bce53 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,13 @@ +2010-09-09 Nathan Sidwell <nathan@codesourcery.com> + + * configure.ac (gnu_indirect_function): New test. + * configure: Rebuilt. + * config.in (HAVE_GAS_INDIRECT_FUNCTION): New. + * defaults.h (IFUNC_ASM_TYPE): Provide default. + + * doc/extend.texi (Function Attributes): Document ifunc. + * varasm.c (do_assemble_alias): Deal with ifuncs too. + 2010-09-09 Hariharan Sandanagobalane <hariharan@picochip.com> * config/picochip/picochip.c (picochip_reorg): Check for note_p for diff --git a/gcc/c-family/ChangeLog b/gcc/c-family/ChangeLog index 50c4ea1..6d3b024 100644 --- a/gcc/c-family/ChangeLog +++ b/gcc/c-family/ChangeLog @@ -1,3 +1,9 @@ +2010-09-09 Nathan Sidwell <nathan@codesourcery.com> + + * c-common.c (handle_alias_ifunc_attribute): New, broken out of ... + (handle_alias_attribute): ... here. + (handle_ifunc_attribute): New. + 2010-09-06 Mark Mitchell <mark@codesourcery.com> * c-common.h (do_warn_double_promotion): Declare. diff --git a/gcc/c-family/c-common.c b/gcc/c-family/c-common.c index 48c67b4..a3a332b 100644 --- a/gcc/c-family/c-common.c +++ b/gcc/c-family/c-common.c @@ -327,6 +327,8 @@ static tree handle_mode_attribute (tree *, tree, tree, int, bool *); static tree handle_section_attribute (tree *, tree, tree, int, bool *); static tree handle_aligned_attribute (tree *, tree, tree, int, bool *); static tree handle_weak_attribute (tree *, tree, tree, int, bool *) ; +static tree handle_alias_ifunc_attribute (bool, tree *, tree, tree, bool *); +static tree handle_ifunc_attribute (tree *, tree, tree, int, bool *); static tree handle_alias_attribute (tree *, tree, tree, int, bool *); static tree handle_weakref_attribute (tree *, tree, tree, int, bool *) ; static tree handle_visibility_attribute (tree *, tree, tree, int, @@ -599,6 +601,8 @@ const struct attribute_spec c_common_attribute_table[] = handle_aligned_attribute }, { "weak", 0, 0, true, false, false, handle_weak_attribute }, + { "ifunc", 1, 1, true, false, false, + handle_ifunc_attribute }, { "alias", 1, 1, true, false, false, handle_alias_attribute }, { "weakref", 0, 1, true, false, false, @@ -6595,6 +6599,12 @@ handle_weak_attribute (tree *node, tree name, error ("inline function %q+D cannot be declared weak", *node); *no_add_attrs = true; } + else if (lookup_attribute ("ifunc", DECL_ATTRIBUTES (*node))) + { + error ("indirect function %q+D cannot be declared weak", *node); + *no_add_attrs = true; + return NULL_TREE; + } else if (TREE_CODE (*node) == FUNCTION_DECL || TREE_CODE (*node) == VAR_DECL) declare_weak (*node); @@ -6604,16 +6614,18 @@ handle_weak_attribute (tree *node, tree name, return NULL_TREE; } -/* Handle an "alias" attribute; arguments as in - struct attribute_spec.handler. */ +/* Handle an "alias" or "ifunc" attribute; arguments as in + struct attribute_spec.handler, except that IS_ALIAS tells us + whether this is an alias as opposed to ifunc attribute. */ static tree -handle_alias_attribute (tree *node, tree name, tree args, - int ARG_UNUSED (flags), bool *no_add_attrs) +handle_alias_ifunc_attribute (bool is_alias, tree *node, tree name, tree args, + bool *no_add_attrs) { tree decl = *node; - if (TREE_CODE (decl) != FUNCTION_DECL && TREE_CODE (decl) != VAR_DECL) + if (TREE_CODE (decl) != FUNCTION_DECL + && (!is_alias || TREE_CODE (decl) != VAR_DECL)) { warning (OPT_Wattributes, "%qE attribute ignored", name); *no_add_attrs = true; @@ -6626,9 +6638,18 @@ handle_alias_attribute (tree *node, tree name, tree args, || (TREE_CODE (decl) != FUNCTION_DECL && ! TREE_PUBLIC (decl) && DECL_INITIAL (decl))) { - error ("%q+D defined both normally and as an alias", decl); + error ("%q+D defined both normally and as %qE attribute", decl, name); *no_add_attrs = true; + return NULL_TREE; } + else if (!is_alias + && (lookup_attribute ("weak", DECL_ATTRIBUTES (decl)) + || lookup_attribute ("weakref", DECL_ATTRIBUTES (decl)))) + { + error ("weak %q+D cannot be defined %qE", decl, name); + *no_add_attrs = true; + return NULL_TREE; + } /* Note that the very first time we process a nested declaration, decl_function_context will not be set. Indeed, *would* never @@ -6642,7 +6663,7 @@ handle_alias_attribute (tree *node, tree name, tree args, id = TREE_VALUE (args); if (TREE_CODE (id) != STRING_CST) { - error ("alias argument not a string"); + error ("attribute %qE argument not a string", name); *no_add_attrs = true; return NULL_TREE; } @@ -6660,6 +6681,11 @@ handle_alias_attribute (tree *node, tree name, tree args, DECL_EXTERNAL (decl) = 0; TREE_STATIC (decl) = 1; } + + if (!is_alias) + /* ifuncs are also aliases, so set that attribute too. */ + DECL_ATTRIBUTES (decl) + = tree_cons (get_identifier ("alias"), args, DECL_ATTRIBUTES (decl)); } else { @@ -6670,6 +6696,26 @@ handle_alias_attribute (tree *node, tree name, tree args, return NULL_TREE; } +/* Handle an "alias" or "ifunc" attribute; arguments as in + struct attribute_spec.handler. */ + +static tree +handle_ifunc_attribute (tree *node, tree name, tree args, + int ARG_UNUSED (flags), bool *no_add_attrs) +{ + return handle_alias_ifunc_attribute (false, node, name, args, no_add_attrs); +} + +/* Handle an "alias" or "ifunc" attribute; arguments as in + struct attribute_spec.handler. */ + +static tree +handle_alias_attribute (tree *node, tree name, tree args, + int ARG_UNUSED (flags), bool *no_add_attrs) +{ + return handle_alias_ifunc_attribute (true, node, name, args, no_add_attrs); +} + /* Handle a "weakref" attribute; arguments as in struct attribute_spec.handler. */ @@ -6691,6 +6737,13 @@ handle_weakref_attribute (tree *node, tree ARG_UNUSED (name), tree args, return NULL_TREE; } + if (lookup_attribute ("ifunc", DECL_ATTRIBUTES (*node))) + { + error ("indirect function %q+D cannot be declared weakref", *node); + *no_add_attrs = true; + return NULL_TREE; + } + /* The idea here is that `weakref("name")' mutates into `weakref, alias("name")', and weakref without arguments, in turn, implicitly adds weak. */ diff --git a/gcc/config.in b/gcc/config.in index c451c53..a03b653 100644 --- a/gcc/config.in +++ b/gcc/config.in @@ -968,6 +968,9 @@ /* Define if your assembler and linker support .hidden. */ #undef HAVE_GAS_HIDDEN +/* Define if your assembler supports indirect function type. */ +#undef HAVE_GAS_INDIRECT_FUNCTION + /* Define if your assembler supports .lcomm with an alignment field. */ #ifndef USED_FOR_TARGET #undef HAVE_GAS_LCOMM_WITH_ALIGNMENT diff --git a/gcc/configure b/gcc/configure index 240a876..ebbead2 100755 --- a/gcc/configure +++ b/gcc/configure @@ -21327,6 +21327,48 @@ fi $as_echo "$gcc_cv_as_hidden" >&6; } +# gnu_indirect_function type is an extension proposed at +# http://groups.google/com/group/generic-abi/files. It allows dynamic runtime +# selection of function implementation +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking assembler for gnu_indirect_function" >&5 +$as_echo_n "checking assembler for gnu_indirect_function... " >&6; } +if test "${gcc_cv_as_indirect_function+set}" = set; then : + $as_echo_n "(cached) " >&6 +else + gcc_cv_as_indirect_function=no + if test $in_tree_gas = yes; then + if test $in_tree_gas_is_elf = yes \ + && test $gcc_cv_gas_vers -ge `expr \( \( 2 \* 1000 \) + 20 \) \* 1000 + 1` + then gcc_cv_as_indirect_function=yes +fi + elif test x$gcc_cv_as != x; then + echo ' .type Foo, @gnu_indirect_function +Foo:' > conftest.s + if { ac_try='$gcc_cv_as $gcc_cv_as_flags -o conftest.o conftest.s >&5' + { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 + (eval $ac_try) 2>&5 + ac_status=$? + $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5 + test $ac_status = 0; }; } + then + gcc_cv_as_indirect_function=yes + else + echo "configure: failed program was" >&5 + cat conftest.s >&5 + fi + rm -f conftest.o conftest.s + fi +fi +{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $gcc_cv_as_indirect_function" >&5 +$as_echo "$gcc_cv_as_indirect_function" >&6; } + + +if test $gcc_cv_as_indirect_function = yes ; then + +$as_echo "#define HAVE_GAS_INDIRECT_FUNCTION 1" >>confdefs.h + +fi + if test $in_tree_ld != yes ; then ld_ver=`$gcc_cv_ld --version 2>/dev/null | sed 1q` if test x"$ld_is_gold" = xyes; then diff --git a/gcc/configure.ac b/gcc/configure.ac index 75cded6..e39ab87 100644 --- a/gcc/configure.ac +++ b/gcc/configure.ac @@ -2158,6 +2158,19 @@ EOF ;; esac]) +# gnu_indirect_function type is an extension proposed at +# http://groups.google/com/group/generic-abi/files. It allows dynamic runtime +# selection of function implementation +gcc_GAS_CHECK_FEATURE(gnu_indirect_function, gcc_cv_as_indirect_function, + [elf,2,20,1],, +[ .type Foo, @gnu_indirect_function +Foo:]) +GCC_TARGET_TEMPLATE([HAVE_GAS_INDIRECT_FUNCTION]) +if test $gcc_cv_as_indirect_function = yes ; then + AC_DEFINE(HAVE_GAS_INDIRECT_FUNCTION, 1, + [Define if your assembler supports indirect function type.]) +fi + changequote(,)dnl if test $in_tree_ld != yes ; then ld_ver=`$gcc_cv_ld --version 2>/dev/null | sed 1q` diff --git a/gcc/defaults.h b/gcc/defaults.h index e30ec17..62b8228 100644 --- a/gcc/defaults.h +++ b/gcc/defaults.h @@ -142,6 +142,10 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see #endif #endif +#ifndef IFUNC_ASM_TYPE +#define IFUNC_ASM_TYPE "gnu_indirect_function" +#endif + #ifndef TLS_COMMON_ASM_OP #define TLS_COMMON_ASM_OP ".tls_common" #endif diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi index de6a30d..4f2cc07 100644 --- a/gcc/doc/extend.texi +++ b/gcc/doc/extend.texi @@ -1912,6 +1912,7 @@ the enclosing block. @cindex functions that do not pop the argument stack on the 386 @cindex functions that have different compilation options on the 386 @cindex functions that have different optimization options +@cindex functions that are dynamically resolved In GNU C, you declare certain things about functions called in your program which help the compiler optimize function calls and check your code more @@ -1927,13 +1928,13 @@ attributes are currently defined for functions on all targets: @code{nothrow}, @code{sentinel}, @code{format}, @code{format_arg}, @code{no_instrument_function}, @code{section}, @code{constructor}, @code{destructor}, @code{used}, @code{unused}, @code{deprecated}, -@code{weak}, @code{malloc}, @code{alias}, @code{warn_unused_result}, -@code{nonnull}, @code{gnu_inline}, @code{externally_visible}, -@code{hot}, @code{cold}, @code{artificial}, @code{error} and -@code{warning}. Several other attributes are defined for functions on -particular target systems. Other attributes, including @code{section} -are supported for variables declarations (@pxref{Variable Attributes}) -and for types (@pxref{Type Attributes}). +@code{weak}, @code{malloc}, @code{alias}, @code{ifunc}, +@code{warn_unused_result}, @code{nonnull}, @code{gnu_inline}, +@code{externally_visible}, @code{hot}, @code{cold}, @code{artificial}, +@code{error} and @code{warning}. Several other attributes are defined +for functions on particular target systems. Other attributes, +including @code{section} are supported for variables declarations +(@pxref{Variable Attributes}) and for types (@pxref{Type Attributes}). GCC plugins may provide their own attributes. @@ -2585,6 +2586,51 @@ void __attribute__ ((interrupt, use_shadow_register_set, use_debug_exception_return)) v7 (); @end smallexample +@item ifunc ("@var{resolver}") +@cindex @code{ifunc} attribute +The @code{ifunc} attribute is used to mark a function as an indirect +function using the STT_GNU_IFUNC symbol type extension to the ELF +standard. This allows the resolution of the symbol value to be +determined dynamically at load time, and an optimized version of the +routine can be selected for the particular processor or other system +characteristics determined then. To use this attribute, first define +the implementation functions available, and a resolver function that +returns a pointer to the selected implementation function. The +implementation functions' declarations must match the API of the +function being implemented, the resolver's declaration is be a +function returning pointer to void function returning void: + +@smallexample +void *my_memcpy (void *dst, const void *src, size_t len) +@{ + @dots{} +@} + +static void (*resolve_memcpy (void)) (void) +@{ + return my_memcpy; // we'll just always select this routine +@} +@end smallexample + +The exported header file declaring the function the user calls would +contain: + +@smallexample +extern void *memcpy (void *, const void *, size_t); +@end smallexample + +allowing the user to call this as a regular function, unaware of the +implementation. Finally, the indirect function needs to be defined in +the same translation unit as the resolver function: + +@smallexample +void *memcpy (void *, const void *, size_t) + __attribute__ ((ifunc ("resolve_memcpy"))); +@end smallexample + +Indirect functions cannot be weak, and require a recent binutils (at +least version 2.20.1), and GNU C library (at least version 2.11.1). + @item interrupt_handler @cindex interrupt handler functions on the Blackfin, m68k, H8/300 and SH processors Use this attribute on the Blackfin, m68k, H8/300, H8/300H, H8S, and SH to diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index cf6aa57..c252a1fb 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,17 @@ +2010-09-09 Nathan Sidwell <nathan@codesourcery.com> + + * lib/target-supports-dg.exp (dg-require-ifunc): New. + * lib/target-supports.exp (check_ifunc_available): New. + * gcc.dg/attr-ifunc-1.c: New. + * gcc.dg/attr-ifunc-2.c: New. + * gcc.dg/attr-ifunc-3.c: New. + * gcc.dg/attr-ifunc-4.c: New. + * gcc.dg/attr-ifunc-5.c: New. + * testsuite/g++.dg/ext/attr-ifunc-1.C: New. + * testsuite/g++.dg/ext/attr-ifunc-2.C: New. + * testsuite/g++.dg/ext/attr-ifunc-3.C: New. + * testsuite/g++.dg/ext/attr-ifunc-4.C: New. + 2010-09-09 Vladimir Makarov <vmakarov@redhat.com> PR middle-end/40386 diff --git a/gcc/testsuite/g++.dg/ext/attr-ifunc-1.C b/gcc/testsuite/g++.dg/ext/attr-ifunc-1.C new file mode 100644 index 0000000..d41fa7d --- /dev/null +++ b/gcc/testsuite/g++.dg/ext/attr-ifunc-1.C @@ -0,0 +1,34 @@ +/* { dg-do run } */ +/* { dg-require-ifunc "" } */ +/* { dg-options "-Wno-pmf-conversions" } */ + +#include <stdio.h> + +struct Klass +{ + int implementation (); + int magic (); + static void *resolver (); +}; + +int Klass::implementation (void) +{ + printf ("'ere I am JH\n"); + return 0; +} + +void *Klass::resolver (void) +{ + int (Klass::*pmf) () = &Klass::implementation; + + return (void *)(int (*)(Klass *))(((Klass *)0)->*pmf); +} + +int Klass::magic (void) __attribute__ ((ifunc ("_ZN5Klass8resolverEv"))); + +int main () +{ + Klass obj; + + return obj.magic () != 0; +} diff --git a/gcc/testsuite/g++.dg/ext/attr-ifunc-2.C b/gcc/testsuite/g++.dg/ext/attr-ifunc-2.C new file mode 100644 index 0000000..e205a2a --- /dev/null +++ b/gcc/testsuite/g++.dg/ext/attr-ifunc-2.C @@ -0,0 +1,38 @@ +/* { dg-do run } */ +/* { dg-require-ifunc "" } */ +/* { dg-options "-Wno-pmf-conversions" } */ + +#include <stdio.h> + +struct Klass +{ + int implementation (); + int magic (); + static void *resolver (); +}; + +int Klass::implementation (void) +{ + printf ("'ere I am JH\n"); + return 0; +} + +void *Klass::resolver (void) +{ + int (Klass::*pmf) () = &Klass::implementation; + + return (void *)(int (*)(Klass *))(((Klass *)0)->*pmf); +} + +int Klass::magic (void) __attribute__ ((ifunc ("_ZN5Klass8resolverEv"))); + +struct Klassier : Klass +{ +}; + +int main () +{ + Klassier obj; + + return obj.magic () != 0; +} diff --git a/gcc/testsuite/g++.dg/ext/attr-ifunc-3.C b/gcc/testsuite/g++.dg/ext/attr-ifunc-3.C new file mode 100644 index 0000000..ba65976 --- /dev/null +++ b/gcc/testsuite/g++.dg/ext/attr-ifunc-3.C @@ -0,0 +1,39 @@ +/* { dg-do run } */ +/* { dg-require-ifunc "" } */ +/* { dg-options "-Wno-pmf-conversions" } */ + +#include <stdio.h> + +struct Klass +{ + int implementation (); + int magic (); + static void *resolver (); +}; + +int Klass::implementation (void) +{ + printf ("'ere I am JH\n"); + return 0; +} + +void *Klass::resolver (void) +{ + int (Klass::*pmf) () = &Klass::implementation; + + return (void *)(int (*)(Klass *))(((Klass *)0)->*pmf); +} + +int Klass::magic (void) __attribute__ ((ifunc ("_ZN5Klass8resolverEv"))); + +int Foo (Klass &obj, int (Klass::*pmf) ()) +{ + return (obj.*pmf) (); +} + +int main () +{ + Klass obj; + + return Foo (obj, &Klass::magic) != 0; +} diff --git a/gcc/testsuite/g++.dg/ext/attr-ifunc-4.C b/gcc/testsuite/g++.dg/ext/attr-ifunc-4.C new file mode 100644 index 0000000..0cae410 --- /dev/null +++ b/gcc/testsuite/g++.dg/ext/attr-ifunc-4.C @@ -0,0 +1,44 @@ +/* { dg-do run } */ +/* { dg-require-ifunc "" } */ +/* { dg-options "-Wno-pmf-conversions" } */ + +#include <stdio.h> + +struct Klass +{ + virtual int magic () = 0; +}; + +struct Klassier : Klass +{ + int implementation (); + int magic (); + static void *resolver (); +}; + +int Klassier::implementation (void) +{ + printf ("'ere I am JH\n"); + return 0; +} + +void *Klassier::resolver (void) +{ + int (Klassier::*pmf) () = &Klassier::implementation; + + return (void *)(int (*)(Klassier *))(((Klassier *)0)->*pmf); +} + +int Klassier::magic (void) __attribute__ ((ifunc ("_ZN8Klassier8resolverEv"))); + +int __attribute__ ((weak)) Foo (Klass &base) +{ + return base.magic (); +} + +int main () +{ + Klassier obj; + + return Foo (obj) != 0; +} diff --git a/gcc/testsuite/gcc.dg/attr-ifunc-1.c b/gcc/testsuite/gcc.dg/attr-ifunc-1.c new file mode 100644 index 0000000..f9c6482 --- /dev/null +++ b/gcc/testsuite/gcc.dg/attr-ifunc-1.c @@ -0,0 +1,23 @@ +/* { dg-do run } */ +/* { dg-require-ifunc "" } */ +/* { dg-options "" } */ + +#include <stdio.h> + +static int implementation (void) +{ + printf ("'ere I am JH\n"); + return 0; +} + +static void *resolver (void) +{ + return (void *)implementation; +} + +extern int magic (void) __attribute__ ((ifunc ("resolver"))); + +int main () +{ + return magic () != 0; +} diff --git a/gcc/testsuite/gcc.dg/attr-ifunc-2.c b/gcc/testsuite/gcc.dg/attr-ifunc-2.c new file mode 100644 index 0000000..f717315 --- /dev/null +++ b/gcc/testsuite/gcc.dg/attr-ifunc-2.c @@ -0,0 +1,28 @@ +/* { dg-require-ifunc "" } */ + +static void *resolver () +{ + return 0; +} + +extern int magic (void) /* { dg-message "previous definition" } */ + __attribute__ ((ifunc ("resolver"))); +extern int magic (void) /* { dg-error "redefinition" "" } */ + __attribute__ ((alias ("resolver"))); + +extern int spell (void) /* { dg-message "previous definition" } */ +{ + return 0; +} +extern int spell (void) /* { dg-error "redefinition" "" } */ + __attribute__ ((ifunc ("resolver"))); + +extern int mantra (void) /* { dg-message "previous definition" } */ + __attribute__ ((alias ("resolver"))); +extern int mantra (void) /* { dg-error "redefinition" "" } */ + __attribute__ ((ifunc ("resolver"))); + +extern int saying (void) /* { dg-error "weak .* cannot be defined" "" } */ + __attribute__ ((weak,ifunc ("resolver"))); +extern int maxim (void) /* { dg-error "indirect function .* cannot be declared weak" "" } */ + __attribute__ ((ifunc ("resolver"),weak)); diff --git a/gcc/testsuite/gcc.dg/attr-ifunc-3.c b/gcc/testsuite/gcc.dg/attr-ifunc-3.c new file mode 100644 index 0000000..fbd972d --- /dev/null +++ b/gcc/testsuite/gcc.dg/attr-ifunc-3.c @@ -0,0 +1,27 @@ +/* { dg-do run } */ +/* { dg-require-ifunc "" } */ +/* { dg-options "" } */ + +#include <stdio.h> + +static int __attribute__((noinline)) + implementation (void *ptr) +{ + if (ptr) + return ((int (*) (void *))ptr) (0); + + printf ("'ere I am JH\n"); + return 0; +} + +static void *resolver (void) +{ + return (void *)implementation; +} + +extern int magic (void *) __attribute__ ((ifunc ("resolver"))); + +int main () +{ + return magic ((void *)magic); +} diff --git a/gcc/testsuite/gcc.dg/attr-ifunc-4.c b/gcc/testsuite/gcc.dg/attr-ifunc-4.c new file mode 100644 index 0000000..698c06b --- /dev/null +++ b/gcc/testsuite/gcc.dg/attr-ifunc-4.c @@ -0,0 +1,23 @@ +/* { dg-do run } */ +/* { dg-require-ifunc "" } */ +/* { dg-options "" } */ + +#include <stdio.h> + +static void *implementation (void) +{ + printf ("'ere I am JH\n"); + return 0; +} + +static void *resolver (void) +{ + return (void *)implementation; +} + +static int magic (void) __attribute__ ((ifunc ("resolver"))); + +int main () +{ + return magic () != 0; +} diff --git a/gcc/testsuite/gcc.dg/attr-ifunc-5.c b/gcc/testsuite/gcc.dg/attr-ifunc-5.c new file mode 100644 index 0000000..4dddec4 --- /dev/null +++ b/gcc/testsuite/gcc.dg/attr-ifunc-5.c @@ -0,0 +1,23 @@ +/* { dg-do run } */ +/* { dg-require-ifunc "" } */ +/* { dg-options "" } */ + +#include <stdio.h> + +static void *implementation (void) +{ + printf ("'ere I am JH\n"); + return 0; +} + +static void *resolver (void) +{ + return (void *)implementation; +} + +extern int magic (void) __attribute__ ((ifunc ("resolver"),visibility ("hidden"))); + +int main () +{ + return magic () != 0; +} diff --git a/gcc/testsuite/lib/target-supports-dg.exp b/gcc/testsuite/lib/target-supports-dg.exp index 02f0bc1..ac5e872 100644 --- a/gcc/testsuite/lib/target-supports-dg.exp +++ b/gcc/testsuite/lib/target-supports-dg.exp @@ -90,6 +90,21 @@ proc dg-require-alias { args } { } } +# If this target does not support the "ifunc" attribute, skip this +# test. + +proc dg-require-ifunc { args } { + set ifunc_available [ check_ifunc_available ] + if { $ifunc_available == -1 } { + upvar name name + unresolved "$name" + } + if { $ifunc_available < 2 } { + upvar dg-do-what dg-do-what + set dg-do-what [list [lindex ${dg-do-what} 0] "N" "P"] + } +} + # If this target's linker does not support the --gc-sections flag, # skip this test. diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp index 638c9ee..fc24b78 100644 --- a/gcc/testsuite/lib/target-supports.exp +++ b/gcc/testsuite/lib/target-supports.exp @@ -368,6 +368,56 @@ proc check_alias_available { } { return $alias_available_saved } +############################### +# proc check_ifunc_available { } +############################### + +# Determine if the target toolchain supports the alias attribute. + +# Returns 2 if the target supports aliases. Returns 1 if the target +# only supports weak aliased. Returns 0 if the target does not +# support aliases at all. Returns -1 if support for aliases could not +# be determined. + +proc check_ifunc_available { } { + global ifunc_available_saved + global tool + + if [info exists ifunc_available_saved] { + verbose "check_ifunc_available returning saved $ifunc_available_saved" 2 + } else { + set src ifunc[pid].c + set obj ifunc[pid].o + verbose "check_ifunc_available compiling testfile $src" 2 + set f [open $src "w"] + # Compile a small test program. The definition of "g" is + # necessary to keep the Solaris assembler from complaining + # about the program. + puts $f "#ifdef __cplusplus\nextern \"C\"\n#endif\n" + puts $f "void g() {} void f() __attribute__((ifunc(\"g\")));" + close $f + set lines [${tool}_target_compile $src $obj object ""] + file delete $src + remote_file build delete $obj + + if [string match "" $lines] then { + # No error messages, everything is OK. + set ifunc_available_saved 2 + } else { + if [regexp "ifunc is not supported" $lines] { + verbose "check_ifunc_available target does not support ifunc" 2 + set ifunc_available_saved 0 + } else { + set ifunc_available_saved -1 + } + } + + verbose "check_ifunc_available returning $ifunc_available_saved" 2 + } + + return $ifunc_available_saved +} + # Returns true if --gc-sections is supported on the target. proc check_gc_sections_available { } { diff --git a/gcc/varasm.c b/gcc/varasm.c index c509219..9c2593f 100644 --- a/gcc/varasm.c +++ b/gcc/varasm.c @@ -993,7 +993,8 @@ use_blocks_for_decl_p (tree decl) if (DECL_INITIAL (decl) == decl) return false; - /* If this decl is an alias, then we don't want to emit a definition. */ + /* If this decl is an alias, then we don't want to emit a + definition. */ if (lookup_attribute ("alias", DECL_ATTRIBUTES (decl))) return false; @@ -5354,6 +5355,17 @@ do_assemble_alias (tree decl, tree target) globalize_decl (decl); maybe_assemble_visibility (decl); } + if (lookup_attribute ("ifunc", DECL_ATTRIBUTES (decl))) + { +#if defined (ASM_OUTPUT_TYPE_DIRECTIVE) && HAVE_GAS_INDIRECT_FUNCTION + ASM_OUTPUT_TYPE_DIRECTIVE + (asm_out_file, IDENTIFIER_POINTER (DECL_ASSEMBLER_NAME (decl)), + IFUNC_ASM_TYPE); +#else + error_at (DECL_SOURCE_LOCATION (decl), + "ifunc is not supported in this configuration"); +#endif + } # ifdef ASM_OUTPUT_DEF_FROM_DECLS ASM_OUTPUT_DEF_FROM_DECLS (asm_out_file, decl, target); |