diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2020-12-07 19:20:25 +0100 |
|---|---|---|
| committer | Jakub Jelinek <jakub@redhat.com> | 2020-12-07 19:20:25 +0100 |
| commit | b737b70fad398728f6006e8397d1bb31ccea4ce7 (patch) | |
| tree | 2a6658e3df17c11dd8d74d9c7403c9bc69678010 | |
| parent | c3a1b3e6fb24ccf6f45e7d6ce904d5549bba01d6 (diff) | |
| download | gcc-b737b70fad398728f6006e8397d1bb31ccea4ce7.zip gcc-b737b70fad398728f6006e8397d1bb31ccea4ce7.tar.gz gcc-b737b70fad398728f6006e8397d1bb31ccea4ce7.tar.bz2 | |
builtins: Avoid ICE with __builtin_clear_padding on POINTERS_EXTEND_UNSIGNED targets [PR98147]
The function that calls targetm.emit_call_builtin___clear_cache
asserts that each of the begin and end operands has either ptr_mode or
Pmode.
On most targets that is the same mode, but e.g. on aarch64 -mabi=ilp32
or a few others it is different. When a target has a clear cache
non-library handler, it will use create_address_operand which will do the
conversion to the right mode automatically, but when emitting a library
call, we just say the operands are ptr_mode even when they can be Pmode
too; in that case we need to convert explicitly.
2020-12-07 Jakub Jelinek <jakub@redhat.com>
PR target/98147
* builtins.c (default_emit_call_builtin___clear_cache): Call
convert_memory_address to ptr_mode on both begin and end.
* gcc.dg/pr98147.c: New test.
| -rw-r--r-- | gcc/builtins.c | 4 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/pr98147.c | 10 |
2 files changed, 12 insertions, 2 deletions
diff --git a/gcc/builtins.c b/gcc/builtins.c index bd12659..faa5030 100644 --- a/gcc/builtins.c +++ b/gcc/builtins.c @@ -7790,8 +7790,8 @@ default_emit_call_builtin___clear_cache (rtx begin, rtx end) emit_library_call (callee, LCT_NORMAL, VOIDmode, - begin, ptr_mode, - end, ptr_mode); + convert_memory_address (ptr_mode, begin), ptr_mode, + convert_memory_address (ptr_mode, end), ptr_mode); } /* Emit a call to __builtin___clear_cache, unless the target specifies diff --git a/gcc/testsuite/gcc.dg/pr98147.c b/gcc/testsuite/gcc.dg/pr98147.c new file mode 100644 index 0000000..3edc798 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr98147.c @@ -0,0 +1,10 @@ +/* PR target/98147 */ + +char buffer[32] = "foo bar"; + +int +main () +{ + __builtin___clear_cache (buffer, buffer + 32); + return 0; +} |