aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPiotr Trojanek <trojanek@adacore.com>2022-06-14 13:47:27 +0200
committerPierre-Marie de Rodat <derodat@adacore.com>2022-07-06 13:29:48 +0000
commitb65a875a7c1a728ddb5d58fb97777394a6f773e2 (patch)
treef5725f1ed88ef60d7318ab6d2927fbab250adb48
parent35e0aa2df74f2ce1e6d593e699cd7b9e81b9e2ee (diff)
downloadgcc-b65a875a7c1a728ddb5d58fb97777394a6f773e2.zip
gcc-b65a875a7c1a728ddb5d58fb97777394a6f773e2.tar.gz
gcc-b65a875a7c1a728ddb5d58fb97777394a6f773e2.tar.bz2
[Ada] Cleanup use of local scalars in GNAT.Socket.Get_Address_Info
A cleanup opportunity spotted while working on improved detection of uninitialised local scalar objects. gcc/ada/ * libgnat/g-socket.adb (Get_Address_Info): Reduce scope of the Found variable; avoid repeated assignment inside the loop.
-rw-r--r--gcc/ada/libgnat/g-socket.adb8
1 files changed, 4 insertions, 4 deletions
diff --git a/gcc/ada/libgnat/g-socket.adb b/gcc/ada/libgnat/g-socket.adb
index 4267d9f..86ce3b8 100644
--- a/gcc/ada/libgnat/g-socket.adb
+++ b/gcc/ada/libgnat/g-socket.adb
@@ -1036,7 +1036,6 @@ package body GNAT.Sockets is
R : C.int;
Iter : Addrinfo_Access;
- Found : Boolean;
function To_Array return Address_Info_Array;
-- Convert taken from OS addrinfo list A into Address_Info_Array
@@ -1046,8 +1045,6 @@ package body GNAT.Sockets is
--------------
function To_Array return Address_Info_Array is
- Result : Address_Info_Array (1 .. 8);
-
procedure Unsupported;
-- Calls Unknown callback if defiend
@@ -1066,6 +1063,9 @@ package body GNAT.Sockets is
end if;
end Unsupported;
+ Found : Boolean;
+ Result : Address_Info_Array (1 .. 8);
+
-- Start of processing for To_Array
begin
@@ -1087,8 +1087,8 @@ package body GNAT.Sockets is
if Result (J).Addr.Family = Family_Unspec then
Unsupported;
else
+ Found := False;
for M in Modes'Range loop
- Found := False;
if Modes (M) = Iter.ai_socktype then
Result (J).Mode := M;
Found := True;