aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJakub Jelinek <jakub@redhat.com>2016-01-27 12:40:04 +0100
committerJakub Jelinek <jakub@gcc.gnu.org>2016-01-27 12:40:04 +0100
commitb1652ddea99943a7a6df4be25e3a35e4eeeeb86d (patch)
treebce699e60643f9feadb835a3de8da891519c2eca
parentdfa654c8cf28dc2f85ccb45b85de3ee26edcc580 (diff)
downloadgcc-b1652ddea99943a7a6df4be25e3a35e4eeeeb86d.zip
gcc-b1652ddea99943a7a6df4be25e3a35e4eeeeb86d.tar.gz
gcc-b1652ddea99943a7a6df4be25e3a35e4eeeeb86d.tar.bz2
re PR tree-optimization/69399 (wrong code with -O and int128)
PR tree-optimization/69399 * wide-int.h (wi::lrshift): For larger precisions, only use fast path if shift is known to be < HOST_BITS_PER_WIDE_INT. * gcc.dg/torture/pr69399.c: New test. From-SVN: r232869
-rw-r--r--gcc/ChangeLog6
-rw-r--r--gcc/testsuite/ChangeLog5
-rw-r--r--gcc/testsuite/gcc.dg/torture/pr69399.c18
-rw-r--r--gcc/wide-int.h4
4 files changed, 32 insertions, 1 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index a66eee5..12a2583 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2016-01-27 Jakub Jelinek <jakub@redhat.com>
+
+ PR tree-optimization/69399
+ * wide-int.h (wi::lrshift): For larger precisions, only
+ use fast path if shift is known to be < HOST_BITS_PER_WIDE_INT.
+
2016-01-27 Claudiu Zissulescu <claziss@synopsys.com>
* config/arc/predicates.md (proper_comparison_operator): Reject
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index b7e6dac..aa3d51b 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2016-01-27 Jakub Jelinek <jakub@redhat.com>
+
+ PR tree-optimization/69399
+ * gcc.dg/torture/pr69399.c: New test.
+
2016-01-27 Eric Botcazou <ebotcazou@adacore.com>
* gcc.dg/tree-ssa/ssa-dom-cse-2.c: XFAIL on SPARC 64-bit.
diff --git a/gcc/testsuite/gcc.dg/torture/pr69399.c b/gcc/testsuite/gcc.dg/torture/pr69399.c
new file mode 100644
index 0000000..24fa48c
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/torture/pr69399.c
@@ -0,0 +1,18 @@
+/* { dg-do run { target int128 } } */
+
+static unsigned __attribute__((noinline, noclone))
+foo (unsigned long long u)
+{
+ unsigned __int128 v = u | 0xffffff81U;
+ v >>= 64;
+ return v;
+}
+
+int
+main ()
+{
+ unsigned x = foo (27);
+ if (x != 0)
+ __builtin_abort ();
+ return 0;
+}
diff --git a/gcc/wide-int.h b/gcc/wide-int.h
index 56cf582..fa133f0 100644
--- a/gcc/wide-int.h
+++ b/gcc/wide-int.h
@@ -2909,7 +2909,9 @@ wi::lrshift (const T1 &x, const T2 &y)
For variable-precision integers like wide_int, handle HWI
and sub-HWI integers inline. */
if (STATIC_CONSTANT_P (xi.precision > HOST_BITS_PER_WIDE_INT)
- ? xi.len == 1 && xi.val[0] >= 0
+ ? (shift < HOST_BITS_PER_WIDE_INT
+ && xi.len == 1
+ && xi.val[0] >= 0)
: xi.precision <= HOST_BITS_PER_WIDE_INT)
{
val[0] = xi.to_uhwi () >> shift;