diff options
| author | Thomas Schwinge <thomas@codesourcery.com> | 2014-05-23 13:07:57 +0200 |
|---|---|---|
| committer | Thomas Schwinge <tschwinge@gcc.gnu.org> | 2014-05-23 13:07:57 +0200 |
| commit | a5a5434f7b594a05a910fdee97ca569cc318a221 (patch) | |
| tree | b00af30d7df221299a0d0a4ed4b9ce7429275a04 | |
| parent | edbba2ceb53e6ebf98357d6036ee27b18cf5082c (diff) | |
| download | gcc-a5a5434f7b594a05a910fdee97ca569cc318a221.zip gcc-a5a5434f7b594a05a910fdee97ca569cc318a221.tar.gz gcc-a5a5434f7b594a05a910fdee97ca569cc318a221.tar.bz2 | |
Be more explicit.
gcc/
* gimplify.c (omp_notice_variable) <case OMP_CLAUSE_DEFAULT_NONE>:
Explicitly enumerate the expected region types.
From-SVN: r210852
| -rw-r--r-- | gcc/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/gimplify.c | 15 |
2 files changed, 14 insertions, 6 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index aedf2d0..d351c0b 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2014-05-23 Thomas Schwinge <thomas@codesourcery.com> + + * gimplify.c (omp_notice_variable) <case OMP_CLAUSE_DEFAULT_NONE>: + Explicitly enumerate the expected region types. + 2014-05-23 Paul Eggert <eggert@cs.ucla.edu> PR other/56955 diff --git a/gcc/gimplify.c b/gcc/gimplify.c index 3241633..39b2750 100644 --- a/gcc/gimplify.c +++ b/gcc/gimplify.c @@ -5683,7 +5683,14 @@ omp_notice_variable (struct gimplify_omp_ctx *ctx, tree decl, bool in_code) switch (default_kind) { case OMP_CLAUSE_DEFAULT_NONE: - if ((ctx->region_type & ORT_TASK) != 0) + if (ctx->region_type == ORT_PARALLEL + || ctx->region_type == ORT_COMBINED_PARALLEL) + { + error ("%qE not specified in enclosing parallel", + DECL_NAME (lang_hooks.decls.omp_report_decl (decl))); + error_at (ctx->location, "enclosing parallel"); + } + else if ((ctx->region_type & ORT_TASK) != 0) { error ("%qE not specified in enclosing task", DECL_NAME (lang_hooks.decls.omp_report_decl (decl))); @@ -5696,11 +5703,7 @@ omp_notice_variable (struct gimplify_omp_ctx *ctx, tree decl, bool in_code) error_at (ctx->location, "enclosing teams construct"); } else - { - error ("%qE not specified in enclosing parallel", - DECL_NAME (lang_hooks.decls.omp_report_decl (decl))); - error_at (ctx->location, "enclosing parallel"); - } + gcc_unreachable (); /* FALLTHRU */ case OMP_CLAUSE_DEFAULT_SHARED: flags |= GOVD_SHARED; |