diff options
| author | Richard Biener <rguenther@suse.de> | 2014-10-16 10:13:52 +0000 |
|---|---|---|
| committer | Richard Biener <rguenth@gcc.gnu.org> | 2014-10-16 10:13:52 +0000 |
| commit | 93a95abe925edc98131056a6b716e7a9e15f72cc (patch) | |
| tree | 20fc664da392c7860ee5505c631575ae25f7fc13 | |
| parent | 0c49f2ed839ba727b236e97e5be03239fd81256c (diff) | |
| download | gcc-93a95abe925edc98131056a6b716e7a9e15f72cc.zip gcc-93a95abe925edc98131056a6b716e7a9e15f72cc.tar.gz gcc-93a95abe925edc98131056a6b716e7a9e15f72cc.tar.bz2 | |
re PR tree-optimization/63168 (loop header copying fails - not vectorized: latch block not empty)
2014-10-16 Richard Biener <rguenther@suse.de>
PR tree-optimization/63168
* tree-cfg.c (gimple_can_merge_blocks_p): Only protect
latches if after merging they are no longer simple.
* cfghooks.c (merge_blocks): Handle merging a latch block
into another block.
* gcc.dg/tree-ssa/loop-40.c: New testcase.
From-SVN: r216304
| -rw-r--r-- | gcc/ChangeLog | 8 | ||||
| -rw-r--r-- | gcc/cfghooks.c | 5 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/tree-ssa/loop-40.c | 14 | ||||
| -rw-r--r-- | gcc/tree-cfg.c | 8 |
5 files changed, 38 insertions, 2 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 349b303..d38d62a 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,11 @@ +2014-10-16 Richard Biener <rguenther@suse.de> + + PR tree-optimization/63168 + * tree-cfg.c (gimple_can_merge_blocks_p): Only protect + latches if after merging they are no longer simple. + * cfghooks.c (merge_blocks): Handle merging a latch block + into another block. + 2014-10-16 Alexander Ivchenko <alexander.ivchenko@intel.com> Maxim Kuznetsov <maxim.kuznetsov@intel.com> Anna Tikhonova <anna.tikhonova@intel.com> diff --git a/gcc/cfghooks.c b/gcc/cfghooks.c index fa18214..09c7f6d 100644 --- a/gcc/cfghooks.c +++ b/gcc/cfghooks.c @@ -766,6 +766,11 @@ merge_blocks (basic_block a, basic_block b) add_bb_to_loop (a, b->loop_father); a->loop_father->header = a; } + /* If we merge a loop latch into its predecessor, update the loop + structure. */ + if (b->loop_father->latch + && b->loop_father->latch == b) + b->loop_father->latch = a; remove_bb_from_loops (b); } diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index b283b94..e281e8c 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2014-10-16 Richard Biener <rguenther@suse.de> + + PR tree-optimization/63168 + * gcc.dg/tree-ssa/loop-40.c: New testcase. + 2014-10-16 Andreas Schwab <schwab@suse.de> * gcc.target/m68k/crash1.c: Fix implicit declaration. diff --git a/gcc/testsuite/gcc.dg/tree-ssa/loop-40.c b/gcc/testsuite/gcc.dg/tree-ssa/loop-40.c new file mode 100644 index 0000000..803e5b6 --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/loop-40.c @@ -0,0 +1,14 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -fdump-tree-ch-details" } */ + +int mymax2(int *it, int *end) +{ + int max = *it; + while (++it != end) + if (*it > max) + max = *it; + return max; +} + +/* { dg-final { scan-tree-dump "Duplicating header" "ch" } } */ +/* { dg-final { cleanup-tree-dump "ch" } } */ diff --git a/gcc/tree-cfg.c b/gcc/tree-cfg.c index cdab639..ff72601 100644 --- a/gcc/tree-cfg.c +++ b/gcc/tree-cfg.c @@ -1674,8 +1674,12 @@ gimple_can_merge_blocks_p (basic_block a, basic_block b) return false; } - /* Protect the loop latches. */ - if (current_loops && b->loop_father->latch == b) + /* Protect simple loop latches. We only want to avoid merging + the latch with the loop header in this case. */ + if (current_loops + && b->loop_father->latch == b + && loops_state_satisfies_p (LOOPS_HAVE_SIMPLE_LATCHES) + && b->loop_father->header == a) return false; /* It must be possible to eliminate all phi nodes in B. If ssa form |