aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJan Hubicka <jh@suse.cz>2010-05-16 23:49:36 +0200
committerJan Hubicka <hubicka@gcc.gnu.org>2010-05-16 21:49:36 +0000
commit91fbf0c7c60930152acf7ec888ffa08383a20453 (patch)
treeb941299e1cca65763fc24db9b4af875a72897cdf
parentcdc6637d7c78ec66bff42ef5a38c1f5a4cd2074d (diff)
downloadgcc-91fbf0c7c60930152acf7ec888ffa08383a20453.zip
gcc-91fbf0c7c60930152acf7ec888ffa08383a20453.tar.gz
gcc-91fbf0c7c60930152acf7ec888ffa08383a20453.tar.bz2
cgraph.c (cgraph_clone_node): Take decl argument and insert clone into hash when it is different from orig.
* cgraph.c (cgraph_clone_node): Take decl argument and insert clone into hash when it is different from orig. (cgraph_create_virtual_clone): Update use of cgraph_clone_node. * cgraph.h (cgraph_clone_node): Update prototype. * lto-cgrpah.c (lto_cgraph_encoder_new): Create body map. (lto_cgraph_encoder_delete): Delete body map. (lto_cgraph_encoder_size): Move to header. (lto_cgraph_encoder_encode_body_p, lto_set_cgraph_encoder_encode_body): New. (lto_output_node): Do not take written_decls argument; output clone_of pointer. (add_node_to): Add include_body_argument; call lto_set_cgraph_encoder_encode_body on master of the clone. (add_references): Update use of add_node_to. (compute_ltrans_boundary): Likewise. (output_cgraph): Do not create written_decls bitmap. (input_node): Take nodes argument; stream in clone_of correctly. (input_cgraph_1): Update use of input_node. * lto-streamer-out.c (lto_output): Use encoder info to decide what bodies to output. * ipa-inline.c (cgraph_clone_inlined_nodes, cgraph_decide_recursive_inlining): Update call of cgraph_clone_node. * lto-streamer.h (lto_cgraph_encoder_d): Add body. (lto_cgraph_encoder_size): Define here. (lto_cgraph_encoder_encode_body_p, lto_varpool_encoder_encode_body_p): Declare. From-SVN: r159466
-rw-r--r--gcc/ChangeLog28
-rw-r--r--gcc/cgraph.c41
-rw-r--r--gcc/cgraph.h2
-rw-r--r--gcc/ipa-inline.c6
-rw-r--r--gcc/lto-cgraph.c83
-rw-r--r--gcc/lto-streamer-out.c15
-rw-r--r--gcc/lto-streamer.h17
7 files changed, 132 insertions, 60 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 225cdda..6053f00 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,31 @@
+2010-05-16 Jan Hubicka <jh@suse.cz>
+
+ * cgraph.c (cgraph_clone_node): Take decl argument and insert
+ clone into hash when it is different from orig.
+ (cgraph_create_virtual_clone): Update use of cgraph_clone_node.
+ * cgraph.h (cgraph_clone_node): Update prototype.
+ * lto-cgrpah.c (lto_cgraph_encoder_new): Create body map.
+ (lto_cgraph_encoder_delete): Delete body map.
+ (lto_cgraph_encoder_size): Move to header.
+ (lto_cgraph_encoder_encode_body_p, lto_set_cgraph_encoder_encode_body): New.
+ (lto_output_node): Do not take written_decls argument; output clone_of
+ pointer.
+ (add_node_to): Add include_body_argument; call
+ lto_set_cgraph_encoder_encode_body on master of the clone.
+ (add_references): Update use of add_node_to.
+ (compute_ltrans_boundary): Likewise.
+ (output_cgraph): Do not create written_decls bitmap.
+ (input_node): Take nodes argument; stream in clone_of correctly.
+ (input_cgraph_1): Update use of input_node.
+ * lto-streamer-out.c (lto_output): Use encoder info to decide
+ what bodies to output.
+ * ipa-inline.c (cgraph_clone_inlined_nodes,
+ cgraph_decide_recursive_inlining): Update call of cgraph_clone_node.
+ * lto-streamer.h (lto_cgraph_encoder_d): Add body.
+ (lto_cgraph_encoder_size): Define here.
+ (lto_cgraph_encoder_encode_body_p, lto_varpool_encoder_encode_body_p):
+ Declare.
+
2010-05-16 Richard Guenther <rguenther@suse.de>
* doc/invoke.texi (-fipa-struct-reorg): Do not mention
diff --git a/gcc/cgraph.c b/gcc/cgraph.c
index 82ce0e8..6e30ec1 100644
--- a/gcc/cgraph.c
+++ b/gcc/cgraph.c
@@ -2051,7 +2051,7 @@ cgraph_clone_edge (struct cgraph_edge *e, struct cgraph_node *n,
function's profile to reflect the fact that part of execution is handled
by node. */
struct cgraph_node *
-cgraph_clone_node (struct cgraph_node *n, gcov_type count, int freq,
+cgraph_clone_node (struct cgraph_node *n, tree decl, gcov_type count, int freq,
int loop_nest, bool update_original,
VEC(cgraph_edge_p,heap) *redirect_callers)
{
@@ -2060,7 +2060,7 @@ cgraph_clone_node (struct cgraph_node *n, gcov_type count, int freq,
gcov_type count_scale;
unsigned i;
- new_node->decl = n->decl;
+ new_node->decl = decl;
new_node->origin = n->origin;
if (new_node->origin)
{
@@ -2118,6 +2118,24 @@ cgraph_clone_node (struct cgraph_node *n, gcov_type count, int freq,
new_node->clone_of = n;
cgraph_call_node_duplication_hooks (n, new_node);
+ if (n->decl != decl)
+ {
+ struct cgraph_node **slot;
+ slot = (struct cgraph_node **) htab_find_slot (cgraph_hash, new_node, INSERT);
+ gcc_assert (!*slot);
+ *slot = new_node;
+ if (assembler_name_hash)
+ {
+ void **aslot;
+ tree name = DECL_ASSEMBLER_NAME (decl);
+
+ aslot = htab_find_slot_with_hash (assembler_name_hash, name,
+ decl_assembler_name_hash (name),
+ INSERT);
+ gcc_assert (!*aslot);
+ *aslot = new_node;
+ }
+ }
return new_node;
}
@@ -2159,7 +2177,6 @@ cgraph_create_virtual_clone (struct cgraph_node *old_node,
tree old_decl = old_node->decl;
struct cgraph_node *new_node = NULL;
tree new_decl;
- struct cgraph_node key, **slot;
size_t i;
struct ipa_replace_map *map;
@@ -2177,10 +2194,9 @@ cgraph_create_virtual_clone (struct cgraph_node *old_node,
SET_DECL_ASSEMBLER_NAME (new_decl, DECL_NAME (new_decl));
SET_DECL_RTL (new_decl, NULL);
- new_node = cgraph_clone_node (old_node, old_node->count,
+ new_node = cgraph_clone_node (old_node, new_decl, old_node->count,
CGRAPH_FREQ_BASE, 0, false,
redirect_callers);
- new_node->decl = new_decl;
/* Update the properties.
Make clone visible only within this translation unit. Make sure
that is not weak also.
@@ -2243,21 +2259,6 @@ cgraph_create_virtual_clone (struct cgraph_node *old_node,
new_node->lowered = true;
new_node->reachable = true;
- key.decl = new_decl;
- slot = (struct cgraph_node **) htab_find_slot (cgraph_hash, &key, INSERT);
- gcc_assert (!*slot);
- *slot = new_node;
- if (assembler_name_hash)
- {
- void **aslot;
- tree name = DECL_ASSEMBLER_NAME (new_decl);
-
- aslot = htab_find_slot_with_hash (assembler_name_hash, name,
- decl_assembler_name_hash (name),
- INSERT);
- gcc_assert (!*aslot);
- *aslot = new_node;
- }
return new_node;
}
diff --git a/gcc/cgraph.h b/gcc/cgraph.h
index 6348033..d0f7e9a 100644
--- a/gcc/cgraph.h
+++ b/gcc/cgraph.h
@@ -544,7 +544,7 @@ const char * cgraph_node_name (struct cgraph_node *);
struct cgraph_edge * cgraph_clone_edge (struct cgraph_edge *,
struct cgraph_node *, gimple,
unsigned, gcov_type, int, int, bool);
-struct cgraph_node * cgraph_clone_node (struct cgraph_node *, gcov_type, int,
+struct cgraph_node * cgraph_clone_node (struct cgraph_node *, tree, gcov_type, int,
int, bool, VEC(cgraph_edge_p,heap) *);
void cgraph_redirect_edge_callee (struct cgraph_edge *, struct cgraph_node *);
diff --git a/gcc/ipa-inline.c b/gcc/ipa-inline.c
index 6f189a6..e1de7ce 100644
--- a/gcc/ipa-inline.c
+++ b/gcc/ipa-inline.c
@@ -268,7 +268,8 @@ cgraph_clone_inlined_nodes (struct cgraph_edge *e, bool duplicate,
else
{
struct cgraph_node *n;
- n = cgraph_clone_node (e->callee, e->count, e->frequency, e->loop_nest,
+ n = cgraph_clone_node (e->callee, e->callee->decl,
+ e->count, e->frequency, e->loop_nest,
update_original, NULL);
cgraph_redirect_edge_callee (e, n);
}
@@ -808,7 +809,8 @@ cgraph_decide_recursive_inlining (struct cgraph_node *node,
cgraph_node_name (node));
/* We need original clone to copy around. */
- master_clone = cgraph_clone_node (node, node->count, CGRAPH_FREQ_BASE, 1,
+ master_clone = cgraph_clone_node (node, node->decl,
+ node->count, CGRAPH_FREQ_BASE, 1,
false, NULL);
master_clone->needed = true;
for (e = master_clone->callees; e; e = e->next_callee)
diff --git a/gcc/lto-cgraph.c b/gcc/lto-cgraph.c
index acac0e0..c6ef21f 100644
--- a/gcc/lto-cgraph.c
+++ b/gcc/lto-cgraph.c
@@ -71,6 +71,7 @@ lto_cgraph_encoder_new (void)
lto_cgraph_encoder_t encoder = XCNEW (struct lto_cgraph_encoder_d);
encoder->map = pointer_map_create ();
encoder->nodes = NULL;
+ encoder->body = pointer_set_create ();
return encoder;
}
@@ -82,6 +83,7 @@ lto_cgraph_encoder_delete (lto_cgraph_encoder_t encoder)
{
VEC_free (cgraph_node_ptr, heap, encoder->nodes);
pointer_map_destroy (encoder->map);
+ pointer_set_destroy (encoder->body);
free (encoder);
}
@@ -137,12 +139,22 @@ lto_cgraph_encoder_deref (lto_cgraph_encoder_t encoder, int ref)
}
-/* Return number of encoded nodes in ENCODER. */
+/* Return TRUE if we should encode initializer of NODE (if any). */
-static int
-lto_cgraph_encoder_size (lto_cgraph_encoder_t encoder)
+bool
+lto_cgraph_encoder_encode_body_p (lto_cgraph_encoder_t encoder,
+ struct cgraph_node *node)
+{
+ return pointer_set_contains (encoder->body, node);
+}
+
+/* Return TRUE if we should encode body of NODE (if any). */
+
+static void
+lto_set_cgraph_encoder_encode_body (lto_cgraph_encoder_t encoder,
+ struct cgraph_node *node)
{
- return VEC_length (cgraph_node_ptr, encoder->nodes);
+ pointer_set_insert (encoder->body, node);
}
/* Create a new varpool encoder. */
@@ -394,17 +406,16 @@ reachable_from_this_partition_p (struct cgraph_node *node, cgraph_node_set set)
static void
lto_output_node (struct lto_simple_output_block *ob, struct cgraph_node *node,
lto_cgraph_encoder_t encoder, cgraph_node_set set,
- varpool_node_set vset,
- bitmap written_decls)
+ varpool_node_set vset)
{
unsigned int tag;
struct bitpack_d *bp;
- bool boundary_p, wrote_decl_p;
+ bool boundary_p;
intptr_t ref;
bool in_other_partition = false;
+ struct cgraph_node *clone_of;
boundary_p = !cgraph_node_in_set_p (node, set);
- wrote_decl_p = bitmap_bit_p (written_decls, DECL_UID (node->decl));
if (node->analyzed && !boundary_p)
tag = LTO_cgraph_analyzed_node;
@@ -436,10 +447,18 @@ lto_output_node (struct lto_simple_output_block *ob, struct cgraph_node *node,
in_other_partition = 1;
}
- lto_output_uleb128_stream (ob->main_stream, wrote_decl_p);
+ clone_of = node->clone_of;
+ while (clone_of
+ && (ref = lto_cgraph_encoder_lookup (encoder, node->clone_of)) == LCC_NOT_FOUND)
+ if (clone_of->prev_sibling_clone)
+ clone_of = clone_of->prev_sibling_clone;
+ else
+ clone_of = clone_of->clone_of;
+ if (!clone_of)
+ lto_output_sleb128_stream (ob->main_stream, LCC_NOT_FOUND);
+ else
+ lto_output_sleb128_stream (ob->main_stream, ref);
- if (!wrote_decl_p)
- bitmap_set_bit (written_decls, DECL_UID (node->decl));
lto_output_fn_decl_index (ob->decl_state, ob->main_stream, node->decl);
lto_output_sleb128_stream (ob->main_stream, node->count);
@@ -636,11 +655,15 @@ output_profile_summary (struct lto_simple_output_block *ob)
/* Add NODE into encoder as well as nodes it is cloned from.
Do it in a way so clones appear first. */
+
static void
-add_node_to (lto_cgraph_encoder_t encoder, struct cgraph_node *node)
+add_node_to (lto_cgraph_encoder_t encoder, struct cgraph_node *node,
+ bool include_body)
{
if (node->clone_of)
- add_node_to (encoder, node->clone_of);
+ add_node_to (encoder, node->clone_of, include_body);
+ else if (include_body)
+ lto_set_cgraph_encoder_encode_body (encoder, node);
lto_cgraph_encoder_encode (encoder, node);
}
@@ -655,7 +678,7 @@ add_references (lto_cgraph_encoder_t encoder,
struct ipa_ref *ref;
for (i = 0; ipa_ref_list_reference_iterate (list, i, ref); i++)
if (ref->refered_type == IPA_REF_CGRAPH)
- add_node_to (encoder, ipa_ref_node (ref));
+ add_node_to (encoder, ipa_ref_node (ref), false);
else
{
struct varpool_node *vnode = ipa_ref_varpool_node (ref);
@@ -757,7 +780,7 @@ compute_ltrans_boundary (struct lto_out_decl_state *state,
for (csi = csi_start (set); !csi_end_p (csi); csi_next (&csi))
{
node = csi_node (csi);
- add_node_to (encoder, node);
+ add_node_to (encoder, node, true);
add_references (encoder, varpool_encoder, &node->ref_list);
}
for (vsi = vsi_start (vset); !vsi_end_p (vsi); vsi_next (&vsi))
@@ -797,7 +820,7 @@ compute_ltrans_boundary (struct lto_out_decl_state *state,
{
/* We should have moved all the inlines. */
gcc_assert (!callee->global.inlined_to);
- add_node_to (encoder, callee);
+ add_node_to (encoder, callee, false);
}
}
}
@@ -812,7 +835,6 @@ output_cgraph (cgraph_node_set set, varpool_node_set vset)
struct lto_simple_output_block *ob;
cgraph_node_set_iterator csi;
int i, n_nodes;
- bitmap written_decls;
lto_cgraph_encoder_t encoder;
lto_varpool_encoder_t varpool_encoder;
struct cgraph_asm_node *can;
@@ -828,11 +850,6 @@ output_cgraph (cgraph_node_set set, varpool_node_set vset)
encoder = ob->decl_state->cgraph_node_encoder;
varpool_encoder = ob->decl_state->varpool_node_encoder;
- /* The FUNCTION_DECLs for which we have written a node. The first
- node found is written as the "original" node, the remaining nodes
- are considered its clones. */
- written_decls = lto_bitmap_alloc ();
-
/* Write out the nodes. We must first output a node and then its clones,
otherwise at a time reading back the node there would be nothing to clone
from. */
@@ -840,11 +857,9 @@ output_cgraph (cgraph_node_set set, varpool_node_set vset)
for (i = 0; i < n_nodes; i++)
{
node = lto_cgraph_encoder_deref (encoder, i);
- lto_output_node (ob, node, encoder, set, vset, written_decls);
+ lto_output_node (ob, node, encoder, set, vset);
}
- lto_bitmap_free (written_decls);
-
/* Go over the nodes in SET again to write edges. */
for (csi = csi_start (set); !csi_end_p (csi); csi_next (&csi))
{
@@ -950,30 +965,32 @@ output_varpool (cgraph_node_set set, varpool_node_set vset)
static struct cgraph_node *
input_node (struct lto_file_decl_data *file_data,
struct lto_input_block *ib,
- enum LTO_cgraph_tags tag)
+ enum LTO_cgraph_tags tag,
+ VEC(cgraph_node_ptr, heap) *nodes)
{
tree fn_decl;
struct cgraph_node *node;
struct bitpack_d *bp;
int stack_size = 0;
unsigned decl_index;
- bool clone_p;
int ref = LCC_NOT_FOUND, ref2 = LCC_NOT_FOUND;
int self_time = 0;
int self_size = 0;
int time_inlining_benefit = 0;
int size_inlining_benefit = 0;
unsigned long same_body_count = 0;
+ int clone_ref;
- clone_p = (lto_input_uleb128 (ib) != 0);
+ clone_ref = lto_input_sleb128 (ib);
decl_index = lto_input_uleb128 (ib);
fn_decl = lto_file_decl_data_get_fn_decl (file_data, decl_index);
- if (clone_p)
- node = cgraph_clone_node (cgraph_node (fn_decl), 0,
- CGRAPH_FREQ_BASE, 0, false, NULL);
-
+ if (clone_ref != LCC_NOT_FOUND)
+ {
+ node = cgraph_clone_node (VEC_index (cgraph_node_ptr, nodes, clone_ref), fn_decl,
+ 0, CGRAPH_FREQ_BASE, 0, false, NULL);
+ }
else
node = cgraph_node (fn_decl);
@@ -1214,7 +1231,7 @@ input_cgraph_1 (struct lto_file_decl_data *file_data,
input_edge (ib, nodes, true);
else
{
- node = input_node (file_data, ib, tag);
+ node = input_node (file_data, ib, tag,nodes);
if (node == NULL || node->decl == NULL_TREE)
internal_error ("bytecode stream: found empty cgraph node");
VEC_safe_push (cgraph_node_ptr, heap, nodes, node);
diff --git a/gcc/lto-streamer-out.c b/gcc/lto-streamer-out.c
index ede7c71..520f29a 100644
--- a/gcc/lto-streamer-out.c
+++ b/gcc/lto-streamer-out.c
@@ -2090,18 +2090,25 @@ lto_output (cgraph_node_set set, varpool_node_set vset)
{
struct cgraph_node *node;
struct lto_out_decl_state *decl_state;
- cgraph_node_set_iterator csi;
+#ifdef ENABLE_CHECKING
bitmap output = lto_bitmap_alloc ();
+#endif
+ int i, n_nodes;
+ lto_cgraph_encoder_t encoder = lto_get_out_decl_state ()->cgraph_node_encoder;
lto_writer_init ();
+ n_nodes = lto_cgraph_encoder_size (encoder);
/* Process only the functions with bodies. */
- for (csi = csi_start (set); !csi_end_p (csi); csi_next (&csi))
+ for (i = 0; i < n_nodes; i++)
{
- node = csi_node (csi);
- if (node->analyzed && !bitmap_bit_p (output, DECL_UID (node->decl)))
+ node = lto_cgraph_encoder_deref (encoder, i);
+ if (lto_cgraph_encoder_encode_body_p (encoder, node))
{
+#ifdef ENABLE_CHECKING
+ gcc_assert (!bitmap_bit_p (output, DECL_UID (node->decl)));
bitmap_set_bit (output, DECL_UID (node->decl));
+#endif
decl_state = lto_new_out_decl_state ();
lto_push_out_decl_state (decl_state);
if (!flag_wpa)
diff --git a/gcc/lto-streamer.h b/gcc/lto-streamer.h
index a0747dd..d86811a 100644
--- a/gcc/lto-streamer.h
+++ b/gcc/lto-streamer.h
@@ -467,10 +467,22 @@ struct lto_cgraph_encoder_d
/* Map reference number to node. */
VEC(cgraph_node_ptr,heap) *nodes;
+
+ /* Map of nodes where we want to output body. */
+ struct pointer_set_t *body;
};
typedef struct lto_cgraph_encoder_d *lto_cgraph_encoder_t;
+/* Return number of encoded nodes in ENCODER. */
+
+static inline int
+lto_cgraph_encoder_size (lto_cgraph_encoder_t encoder)
+{
+ return VEC_length (cgraph_node_ptr, encoder->nodes);
+}
+
+
/* Encoder data structure used to stream callgraph nodes. */
struct lto_varpool_encoder_d
{
@@ -851,6 +863,11 @@ int lto_cgraph_encoder_lookup (lto_cgraph_encoder_t, struct cgraph_node *);
lto_cgraph_encoder_t lto_cgraph_encoder_new (void);
int lto_cgraph_encoder_encode (lto_cgraph_encoder_t, struct cgraph_node *);
void lto_cgraph_encoder_delete (lto_cgraph_encoder_t);
+bool lto_cgraph_encoder_encode_body_p (lto_cgraph_encoder_t,
+ struct cgraph_node *);
+
+bool lto_varpool_encoder_encode_body_p (lto_varpool_encoder_t,
+ struct varpool_node *);
struct varpool_node *lto_varpool_encoder_deref (lto_varpool_encoder_t, int);
int lto_varpool_encoder_lookup (lto_varpool_encoder_t, struct varpool_node *);
lto_varpool_encoder_t lto_varpool_encoder_new (void);