aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNathan Sidwell <nathan@codesourcery.com>2002-10-18 08:09:58 +0000
committerNathan Sidwell <nathan@gcc.gnu.org>2002-10-18 08:09:58 +0000
commit8a188e24900cfb30734df5e40cfb0e1ee88750b6 (patch)
tree338aa389ed355ded202d085305820a23b45a64eb
parente6ffac8ac0122ad5ee19e88b10243b96076e5ddc (diff)
downloadgcc-8a188e24900cfb30734df5e40cfb0e1ee88750b6.zip
gcc-8a188e24900cfb30734df5e40cfb0e1ee88750b6.tar.gz
gcc-8a188e24900cfb30734df5e40cfb0e1ee88750b6.tar.bz2
class.c (add_method): Compare template parms too.
cp: * class.c (add_method): Compare template parms too. testsuite: * g++.dg/overload/member2.C: New test. From-SVN: r58278
-rw-r--r--gcc/cp/ChangeLog4
-rw-r--r--gcc/cp/class.c7
-rw-r--r--gcc/testsuite/ChangeLog4
-rw-r--r--gcc/testsuite/g++.dg/overload/member2.C41
4 files changed, 56 insertions, 0 deletions
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index b6836ee..e2a0976 100644
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,7 @@
+2002-10-17 Nathan Sidwell <nathan@codesourcery.com>
+
+ * class.c (add_method): Compare template parms too.
+
2002-10-17 Mark Mitchell <mark@codesourcery.com>
PR c++/7584
diff --git a/gcc/cp/class.c b/gcc/cp/class.c
index 90d7ef2..7c66098 100644
--- a/gcc/cp/class.c
+++ b/gcc/cp/class.c
@@ -950,6 +950,13 @@ add_method (type, method, error_p)
&& (TYPE_QUALS (TREE_TYPE (TREE_VALUE (parms1)))
!= TYPE_QUALS (TREE_TYPE (TREE_VALUE (parms2)))))
same = 0;
+
+ /* For templates, the template parms must be identical. */
+ if (TREE_CODE (fn) == TEMPLATE_DECL
+ && !comp_template_parms (DECL_TEMPLATE_PARMS (fn),
+ DECL_TEMPLATE_PARMS (method)))
+ same = 0;
+
if (! DECL_STATIC_FUNCTION_P (fn))
parms1 = TREE_CHAIN (parms1);
if (! DECL_STATIC_FUNCTION_P (method))
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index f718424..20fda9f 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2002-10-17 Nathan Sidwell <nathan@codesourcery.com>
+
+ * g++.dg/overload/member2.C: New test.
+
2002-10-17 Janis Johnson <janis187@us.ibm.com>
* g++.dg/README: Describe new compat directory.
diff --git a/gcc/testsuite/g++.dg/overload/member2.C b/gcc/testsuite/g++.dg/overload/member2.C
new file mode 100644
index 0000000..b891414
--- /dev/null
+++ b/gcc/testsuite/g++.dg/overload/member2.C
@@ -0,0 +1,41 @@
+// { dg-do run }
+
+// Copyright (C) 2001 Free Software Foundation, Inc.
+// Contributed by Nathan Sidwell 17 Oct 2002 <nathan@codesourcery.com>
+
+// PR 7676. We didn't notice template members were different.
+
+struct foo
+{
+ template<class T>
+ int bar() {return 1;}
+
+ template<int I>
+ int bar() {return 2;}
+
+};
+
+struct baz : foo
+{
+ using foo::bar;
+ template<int I>
+ int bar () {return 3;}
+};
+
+int main ()
+{
+ baz b;
+ foo f;
+
+ if (f.bar<1> () != 2)
+ return 1;
+ if (f.bar<int> () != 1)
+ return 2;
+
+ if (b.bar<1> () != 3)
+ return 1;
+ if (b.bar<int> () != 1)
+ return 2;
+
+ return 0;
+}