diff options
| author | Andrew Pinski <apinski@marvell.com> | 2023-05-13 22:25:21 +0000 |
|---|---|---|
| committer | Andrew Pinski <apinski@marvell.com> | 2023-05-14 19:58:50 +0000 |
| commit | 82502b5c3463bde98d4b7ffb9ecef9b123799ed1 (patch) | |
| tree | 0f5c205cfbbebf0547be5ecfc2a6e8fa405c87a0 | |
| parent | aed51e2051b24a6a2127c6626f451641557a571a (diff) | |
| download | gcc-82502b5c3463bde98d4b7ffb9ecef9b123799ed1.zip gcc-82502b5c3463bde98d4b7ffb9ecef9b123799ed1.tar.gz gcc-82502b5c3463bde98d4b7ffb9ecef9b123799ed1.tar.bz2 | |
MATCH: Add pattern for `signbit(x) ? x : -x` into abs (and swapped)
This adds a simple pattern to match.pd for `signbit(x) ? x : -x`
into abs<x>. This can be done for all types even ones that honor
signed zeros and NaNs because both signbit and - are considered
only looking at/touching the sign bit of those types and does
not trap either.
OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions.
PR tree-optimization/109829
gcc/ChangeLog:
* match.pd: Add pattern for `signbit(x) !=/== 0 ? x : -x`.
gcc/testsuite/ChangeLog:
* gcc.dg/tree-ssa/abs-3.c: New test.
* gcc.dg/tree-ssa/abs-4.c: New test.
| -rw-r--r-- | gcc/match.pd | 10 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/tree-ssa/abs-3.c | 13 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/tree-ssa/abs-4.c | 13 |
3 files changed, 36 insertions, 0 deletions
diff --git a/gcc/match.pd b/gcc/match.pd index 2639588..b025fb8 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -7439,6 +7439,16 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) && TREE_CODE (@0) != INTEGER_CST) (op @0 (ext @1 @2))))) +/* signbit(x) != 0 ? -x : x -> abs(x) + signbit(x) == 0 ? -x : x -> -abs(x) */ +(for sign (SIGNBIT) + (for neeq (ne eq) + (simplify + (cond (neeq (sign @0) integer_zerop) (negate @0) @0) + (if (neeq == NE_EXPR) + (abs @0) + (negate (abs @0)))))) + (simplify /* signbit(x) -> 0 if x is nonnegative. */ (SIGNBIT tree_expr_nonnegative_p@0) diff --git a/gcc/testsuite/gcc.dg/tree-ssa/abs-3.c b/gcc/testsuite/gcc.dg/tree-ssa/abs-3.c new file mode 100644 index 0000000..d2638e8 --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/abs-3.c @@ -0,0 +1,13 @@ +/* { dg-do compile } */ +/* { dg-options "-O1 -fdump-tree-optimized" } */ +/* PR tree-optimization/109829 */ + +float abs_f(float x) { return __builtin_signbit(x) ? -x : x; } +double abs_d(double x) { return __builtin_signbit(x) ? -x : x; } +long double abs_ld(long double x) { return __builtin_signbit(x) ? -x : x; } + + +/* __builtin_signbit(x) ? -x : x. Should be convert into ABS_EXP<x> */ +/* { dg-final { scan-tree-dump-not "signbit" "optimized"} } */ +/* { dg-final { scan-tree-dump-not "= -" "optimized"} } */ +/* { dg-final { scan-tree-dump-times "= ABS_EXPR" 3 "optimized"} } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/abs-4.c b/gcc/testsuite/gcc.dg/tree-ssa/abs-4.c new file mode 100644 index 0000000..6197519 --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/abs-4.c @@ -0,0 +1,13 @@ +/* { dg-do compile } */ +/* { dg-options "-O1 -fdump-tree-optimized" } */ +/* PR tree-optimization/109829 */ + +float abs_f(float x) { return __builtin_signbit(x) ? x : -x; } +double abs_d(double x) { return __builtin_signbit(x) ? x : -x; } +long double abs_ld(long double x) { return __builtin_signbit(x) ? x : -x; } + + +/* __builtin_signbit(x) ? x : -x. Should be convert into - ABS_EXP<x> */ +/* { dg-final { scan-tree-dump-not "signbit" "optimized"} } */ +/* { dg-final { scan-tree-dump-times "= ABS_EXPR" 3 "optimized"} } */ +/* { dg-final { scan-tree-dump-times "= -" 3 "optimized"} } */ |