diff options
author | Jason Merrill <jason@redhat.com> | 2024-11-19 21:59:40 +0100 |
---|---|---|
committer | Jason Merrill <jason@redhat.com> | 2024-11-21 19:37:23 +0100 |
commit | 819f67a2f633d2000f09119f0e19b784ea0a4bd8 (patch) | |
tree | 07f117d0ca70b2ddb43d4bde1b55d4d9f6e85abf | |
parent | 74498be0e6041d2abcd17cf2c0eed6cb034ce6a3 (diff) | |
download | gcc-819f67a2f633d2000f09119f0e19b784ea0a4bd8.zip gcc-819f67a2f633d2000f09119f0e19b784ea0a4bd8.tar.gz gcc-819f67a2f633d2000f09119f0e19b784ea0a4bd8.tar.bz2 |
c++: inline variables and modules
We weren't writing out the definition of an inline variable, so the importer
either got an undefined symbol or 0.
gcc/cp/ChangeLog:
* module.cc (has_definition): Also true for inline vars.
gcc/testsuite/ChangeLog:
* g++.dg/modules/inline-1_a.C: New test.
* g++.dg/modules/inline-1_b.C: New test.
-rw-r--r-- | gcc/cp/module.cc | 3 | ||||
-rw-r--r-- | gcc/testsuite/g++.dg/modules/inline-1_a.C | 11 | ||||
-rw-r--r-- | gcc/testsuite/g++.dg/modules/inline-1_b.C | 8 |
3 files changed, 21 insertions, 1 deletions
diff --git a/gcc/cp/module.cc b/gcc/cp/module.cc index 3b25f95..617bf4c 100644 --- a/gcc/cp/module.cc +++ b/gcc/cp/module.cc @@ -11919,7 +11919,8 @@ has_definition (tree decl) since there's no TU to emit them in otherwise. */ return true; - if (!decl_maybe_constant_var_p (decl)) + if (!decl_maybe_constant_var_p (decl) + && !DECL_INLINE_VAR_P (decl)) return false; return true; diff --git a/gcc/testsuite/g++.dg/modules/inline-1_a.C b/gcc/testsuite/g++.dg/modules/inline-1_a.C new file mode 100644 index 0000000..eafd450 --- /dev/null +++ b/gcc/testsuite/g++.dg/modules/inline-1_a.C @@ -0,0 +1,11 @@ +// { dg-additional-options -fmodules } +// { dg-module-do run } +export module M; + +inline int b = 42; +struct A +{ + static inline int a = 4200; +}; + +export inline int f() { return b+A::a; } diff --git a/gcc/testsuite/g++.dg/modules/inline-1_b.C b/gcc/testsuite/g++.dg/modules/inline-1_b.C new file mode 100644 index 0000000..af319b1 --- /dev/null +++ b/gcc/testsuite/g++.dg/modules/inline-1_b.C @@ -0,0 +1,8 @@ +// { dg-additional-options -fmodules } +import M; + +int main() +{ + if (f() != 4242) + __builtin_abort (); +} |