diff options
| author | Robert Dubner <rdubner@symas.com> | 2025-07-31 07:45:26 -0400 |
|---|---|---|
| committer | Robert Dubner <rdubner@symas.com> | 2025-08-15 15:40:07 -0400 |
| commit | 810340f9fed56dc2a0e7e1db3f19b383f6e4cb95 (patch) | |
| tree | c2f757b4a0bb10ab9a275e693cc5be184dff84fa | |
| parent | f5696e9b1113b0a8e464cabb8cc26c871b1d9289 (diff) | |
| download | gcc-810340f9fed56dc2a0e7e1db3f19b383f6e4cb95.zip gcc-810340f9fed56dc2a0e7e1db3f19b383f6e4cb95.tar.gz gcc-810340f9fed56dc2a0e7e1db3f19b383f6e4cb95.tar.bz2 | |
real: Eliminate access to uninitialized memory.
When compiling this program with gcobol:
identification division.
program-id. prog.
data division.
working-storage section.
01 val pic v9(5) value .001.
procedure division.
display val
goback.
the rounding up of .99999...9999 to 1.000...0000 causes a read of the
first byte of the output buffer. Although harmless, it generates a
valgrind warning. The following change clears that warning.
gcc/ChangeLog:
* real.cc (real_to_decimal_for_mode): Set str[0] to known value.
| -rw-r--r-- | gcc/real.cc | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/gcc/real.cc b/gcc/real.cc index 1f987d4..43d2524 100644 --- a/gcc/real.cc +++ b/gcc/real.cc @@ -1629,6 +1629,11 @@ real_to_decimal_for_mode (char *str, const REAL_VALUE_TYPE *r_orig, strcpy (str, (r.sign ? "-0.0" : "0.0")); return; case rvc_normal: + /* When r_orig is a positive value that converts to all nines and is + rounded up to 1.0, str[0] is harmlessly accessed before being set to + '1'. That read access triggers a valgrind warning. Setting str[0] + to any value quiets the warning. */ + str[0] = ' '; break; case rvc_inf: strcpy (str, (r.sign ? "-Inf" : "+Inf")); |