diff options
| author | Mark Mitchell <mark@codesourcery.com> | 2006-12-04 18:00:32 +0000 |
|---|---|---|
| committer | Mark Mitchell <mmitchel@gcc.gnu.org> | 2006-12-04 18:00:32 +0000 |
| commit | 7b5d1e27361c3442fdf553f7384d68f3ce57fe8e (patch) | |
| tree | 84d362165d7df88f2085057ef825f84b056d9687 | |
| parent | 7f575bf6d48e70be2184a4f7d19dd7c78c6f5113 (diff) | |
| download | gcc-7b5d1e27361c3442fdf553f7384d68f3ce57fe8e.zip gcc-7b5d1e27361c3442fdf553f7384d68f3ce57fe8e.tar.gz gcc-7b5d1e27361c3442fdf553f7384d68f3ce57fe8e.tar.bz2 | |
re PR c++/29632 (ICE on invalid code: regenerate_decl_from_template, at cp/pt.c:10969)
PR c++/29632
* call.c (add_builtin_candidate): Do not permit NULL pointer
constants to be compared with template parameters.
PR c++/29632
* g++.dg/template/error23.C: New test.
From-SVN: r119499
| -rw-r--r-- | gcc/cp/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/cp/call.c | 11 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/g++.dg/template/error23.C | 17 |
4 files changed, 36 insertions, 3 deletions
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index cf577f0..a4c1a11 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,9 @@ +2006-12-04 Mark Mitchell <mark@codesourcery.com> + + PR c++/29632 + * call.c (add_builtin_candidate): Do not permit NULL pointer + constants to be compared with template parameters. + 2006-12-04 Eric Botcazou <ebotcazou@adacore.com> * pt.c (for_each_template_parm_r) <INTEGER_TYPE>: New case. diff --git a/gcc/cp/call.c b/gcc/cp/call.c index cfb566b..3418703 100644 --- a/gcc/cp/call.c +++ b/gcc/cp/call.c @@ -1811,14 +1811,19 @@ add_builtin_candidate (struct z_candidate **candidates, enum tree_code code, break; if (TYPE_PTR_P (type1) && TYPE_PTR_P (type2)) break; - if (TREE_CODE (type1) == ENUMERAL_TYPE && TREE_CODE (type2) == ENUMERAL_TYPE) + if (TREE_CODE (type1) == ENUMERAL_TYPE + && TREE_CODE (type2) == ENUMERAL_TYPE) break; - if (TYPE_PTR_P (type1) && null_ptr_cst_p (args[1])) + if (TYPE_PTR_P (type1) + && null_ptr_cst_p (args[1]) + && !uses_template_parms (type1)) { type2 = type1; break; } - if (null_ptr_cst_p (args[0]) && TYPE_PTR_P (type2)) + if (null_ptr_cst_p (args[0]) + && TYPE_PTR_P (type2) + && !uses_template_parms (type2)) { type1 = type2; break; diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index e50bc59..3e0e641 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2006-12-04 Mark Mitchell <mark@codesourcery.com> + + PR c++/29632 + * g++.dg/template/error23.C: New test. + 2006-12-04 Uros Bizjak <ubizjak@gmail.com> * gcc.target/i386/sse-18.c: Pass if CPU has no SSE2 support. diff --git a/gcc/testsuite/g++.dg/template/error23.C b/gcc/testsuite/g++.dg/template/error23.C new file mode 100644 index 0000000..8e5dee7 --- /dev/null +++ b/gcc/testsuite/g++.dg/template/error23.C @@ -0,0 +1,17 @@ +// PR c++/29632 + +struct nullptr_type { + + nullptr_type ( void ) {} + + template < typename T > + operator T* ( void ) const { + return ( 0 ); + } +} const nullptr; + +int main ( void ) { + 0 == nullptr; // { dg-error "match" } +} + + |