diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2023-02-03 21:37:27 +0100 |
|---|---|---|
| committer | Jakub Jelinek <jakub@redhat.com> | 2023-02-03 21:38:41 +0100 |
| commit | 76f7f0eddcb7c418d1ec3dea3e2341ca99097301 (patch) | |
| tree | 84e0398c34b4bfd348390cd8fdfd2c1f5912a59a | |
| parent | e261fcefb71e1270673f0457fcc73711f13d3079 (diff) | |
| download | gcc-76f7f0eddcb7c418d1ec3dea3e2341ca99097301.zip gcc-76f7f0eddcb7c418d1ec3dea3e2341ca99097301.tar.gz gcc-76f7f0eddcb7c418d1ec3dea3e2341ca99097301.tar.bz2 | |
fortran: Fix up hash table usage in gfc_trans_use_stmts [PR108451]
The first testcase in the PR (which I haven't included in the patch because
it is unclear to me if it is supposed to be valid or not) ICEs since extra
hash table checking has been added recently. The problem is that
gfc_trans_use_stmts does
tree *slot = entry->decls->find_slot_with_hash (rent->use_name, hash,
INSERT);
if (*slot == NULL)
and later on doesn't store anything into *slot and continues. Another spot
a few lines later correctly clears the slot if it decides not to use the
slot, so the following patch does the same.
2023-02-03 Jakub Jelinek <jakub@redhat.com>
PR fortran/108451
* trans-decl.cc (gfc_trans_use_stmts): Call clear_slot before
doing continue.
| -rw-r--r-- | gcc/fortran/trans-decl.cc | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/gcc/fortran/trans-decl.cc b/gcc/fortran/trans-decl.cc index 6333007..7a077801 100644 --- a/gcc/fortran/trans-decl.cc +++ b/gcc/fortran/trans-decl.cc @@ -5350,7 +5350,11 @@ gfc_trans_use_stmts (gfc_namespace * ns) /* Sometimes, generic interfaces wind up being over-ruled by a local symbol (see PR41062). */ if (!st->n.sym->attr.use_assoc) - continue; + { + *slot = error_mark_node; + entry->decls->clear_slot (slot); + continue; + } if (st->n.sym->backend_decl && DECL_P (st->n.sym->backend_decl) |