diff options
author | Alexandre Oliva <oliva@adacore.com> | 2024-06-12 00:16:27 -0300 |
---|---|---|
committer | Alexandre Oliva <oliva@gnu.org> | 2024-06-12 00:16:27 -0300 |
commit | 66f48557e11a530646e5562c50a75b4b9839f171 (patch) | |
tree | d97a2b086ba7b92711368837be7269bc77e5430a | |
parent | 89a746f2a326ae83c51868271615fe5d7e249c50 (diff) | |
download | gcc-66f48557e11a530646e5562c50a75b4b9839f171.zip gcc-66f48557e11a530646e5562c50a75b4b9839f171.tar.gz gcc-66f48557e11a530646e5562c50a75b4b9839f171.tar.bz2 |
[tree-prof] skip if errors were seen [PR113681]
ipa_tree_profile asserts that the symtab is in IPA_SSA state, but we
don't reach that state and ICE if e.g. ipa-strub passes report errors.
Skip this pass if errors were seen.
for gcc/ChangeLog
PR tree-optimization/113681
* tree-profile.cc (pass_ipa_tree_profile::gate): Skip if
seen_errors.
for gcc/testsuite/ChangeLog
PR tree-optimization/113681
* c-c++-common/strub-pr113681.c: New.
-rw-r--r-- | gcc/testsuite/c-c++-common/strub-pr113681.c | 22 | ||||
-rw-r--r-- | gcc/tree-profile.cc | 3 |
2 files changed, 24 insertions, 1 deletions
diff --git a/gcc/testsuite/c-c++-common/strub-pr113681.c b/gcc/testsuite/c-c++-common/strub-pr113681.c new file mode 100644 index 0000000..3ef9017 --- /dev/null +++ b/gcc/testsuite/c-c++-common/strub-pr113681.c @@ -0,0 +1,22 @@ +/* { dg-do compile } */ +/* { dg-options "-fstrub=relaxed -fbranch-probabilities" } */ +/* { dg-require-effective-target strub } */ + +/* Same as torture/strub-inlineable1.c, but with -fbranch-probabilities, to + check that IPA tree-profiling won't ICE. It would when we refrained from + running passes that would take it to IPA_SSA, but ran the pass that asserted + for IPA_SSA. */ + +inline void __attribute__ ((strub ("internal"), always_inline)) +inl_int_ali (void) +{ + /* No internal wrapper, so this body ALWAYS gets inlined, + but it cannot be called from non-strub contexts. */ +} + +void +bat (void) +{ + /* Not allowed, not a strub context. */ + inl_int_ali (); /* { dg-error "context" } */ +} diff --git a/gcc/tree-profile.cc b/gcc/tree-profile.cc index b87c121..e4bb689 100644 --- a/gcc/tree-profile.cc +++ b/gcc/tree-profile.cc @@ -2070,7 +2070,8 @@ pass_ipa_tree_profile::gate (function *) disabled. */ return (!in_lto_p && !flag_auto_profile && (flag_branch_probabilities || flag_test_coverage - || profile_arc_flag || condition_coverage_flag)); + || profile_arc_flag || condition_coverage_flag) + && !seen_error ()); } } // anon namespace |