diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2023-02-06 09:05:56 +0100 |
|---|---|---|
| committer | Jakub Jelinek <jakub@redhat.com> | 2023-02-06 09:05:56 +0100 |
| commit | 5df573f76bb9b42231e722145033c548a5fcdf9a (patch) | |
| tree | f44c66b7d240ed18118d4390b7ad444fc59503f7 | |
| parent | 31924665c86d47af6b1f22a74f594f2e1dc0ed2d (diff) | |
| download | gcc-5df573f76bb9b42231e722145033c548a5fcdf9a.zip gcc-5df573f76bb9b42231e722145033c548a5fcdf9a.tar.gz gcc-5df573f76bb9b42231e722145033c548a5fcdf9a.tar.bz2 | |
ubsan: Fix up another spot that should have been BUILT_IN_UNREACHABLE_TRAPS [PR108655]
We ICE on the following testcase, because ivcanon calls
gimple_build_builtin_unreachable but doesn't expect it would need vops.
BUILT_IN_UNREACHABLE_TRAP I've introduced yesterday doesn't need
vops and should be used in that case instead of BUILT_IN_TRAP which
needs them.
2023-02-06 Jakub Jelinek <jakub@redhat.com>
PR tree-optimization/108655
* ubsan.cc (sanitize_unreachable_fn): For -funreachable-traps
or -fsanitize=unreachable -fsanitize-trap=unreachable return
BUILT_IN_UNREACHABLE_TRAP decl rather than BUILT_IN_TRAP.
* gcc.dg/pr108655.c: New test.
| -rw-r--r-- | gcc/testsuite/gcc.dg/pr108655.c | 15 | ||||
| -rw-r--r-- | gcc/ubsan.cc | 2 |
2 files changed, 16 insertions, 1 deletions
diff --git a/gcc/testsuite/gcc.dg/pr108655.c b/gcc/testsuite/gcc.dg/pr108655.c new file mode 100644 index 0000000..f407616 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr108655.c @@ -0,0 +1,15 @@ +/* PR tree-optimization/108655 */ +/* { dg-do compile } */ +/* { dg-options "-w -O1 -funreachable-traps" } */ + +void +foo (void) +{ + int i, j; + for (; i;) + ; + for (; i < 6;) + for (j = 0; j < 6; ++j) + i += j; + __builtin_trap (); +} diff --git a/gcc/ubsan.cc b/gcc/ubsan.cc index 6dec2c3..c2f2e75 100644 --- a/gcc/ubsan.cc +++ b/gcc/ubsan.cc @@ -649,7 +649,7 @@ sanitize_unreachable_fn (tree *data, location_t loc) ? (flag_sanitize_trap & SANITIZE_UNREACHABLE) : flag_unreachable_traps) { - fn = builtin_decl_explicit (BUILT_IN_TRAP); + fn = builtin_decl_explicit (BUILT_IN_UNREACHABLE_TRAP); *data = NULL_TREE; } else if (san) |