diff options
| author | Richard Biener <rguenther@suse.de> | 2023-05-24 12:36:28 +0200 |
|---|---|---|
| committer | Richard Biener <rguenther@suse.de> | 2023-05-24 13:17:10 +0200 |
| commit | 5476de2618ffb77f3a52e59e2c9f10b018329689 (patch) | |
| tree | 5c1c12fb0740946faf080c128b990518770fbe84 | |
| parent | aa8b363171a95b8f867a74f29c75f9577e9087e1 (diff) | |
| download | gcc-5476de2618ffb77f3a52e59e2c9f10b018329689.zip gcc-5476de2618ffb77f3a52e59e2c9f10b018329689.tar.gz gcc-5476de2618ffb77f3a52e59e2c9f10b018329689.tar.bz2 | |
tree-optimization/109849 - fix fallout of PRE hoisting change
The PR109849 fix made us no longer hoist some memory loads because
of the expression set intersection. We can still avoid to compute
the union by simply taking the first sets expressions and leave
the pruning of expressions with values not suitable for hoisting
to sorted_array_from_bitmap_set.
PR tree-optimization/109849
* tree-ssa-pre.cc (do_hoist_insertion): Do not intersect
expressions but take the first sets.
* gcc.dg/tree-ssa/ssa-hoist-9.c: New testcase.
| -rw-r--r-- | gcc/testsuite/gcc.dg/tree-ssa/ssa-hoist-9.c | 20 | ||||
| -rw-r--r-- | gcc/tree-ssa-pre.cc | 12 |
2 files changed, 24 insertions, 8 deletions
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-hoist-9.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-hoist-9.c new file mode 100644 index 0000000..388f79f --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-hoist-9.c @@ -0,0 +1,20 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -fdump-tree-pre-stats" } */ + +int foo (int flag, int * __restrict a, int * __restrict b) +{ + int res; + if (flag) + res = *a + *b; + else + { + res = *a; + *a = 1; + res += *b; + } + return res; +} + +/* { dg-final { scan-tree-dump "HOIST inserted: 3" "pre" } } */ +/* { dg-final { scan-tree-dump-times " = \\\*" 2 "pre" } } */ +/* { dg-final { scan-tree-dump-times " = \[^\r\n\]* \\\+ \[^\r\n\]*;" 1 "pre" } } */ diff --git a/gcc/tree-ssa-pre.cc b/gcc/tree-ssa-pre.cc index b1ceea9..7bbfa5a 100644 --- a/gcc/tree-ssa-pre.cc +++ b/gcc/tree-ssa-pre.cc @@ -3625,8 +3625,9 @@ do_hoist_insertion (basic_block block) /* We have multiple successors, compute ANTIC_OUT by taking the intersection of all of ANTIC_IN translating through PHI nodes. Note we do not have to - worry about iteration stability here so just intersect the expression sets - as well. This is a simplification of what we do in compute_antic_aux. */ + worry about iteration stability here so just use the expression set + from the first set and prune that by sorted_array_from_bitmap_set. + This is a simplification of what we do in compute_antic_aux. */ bitmap_set_t ANTIC_OUT = bitmap_set_new (); bool first = true; FOR_EACH_EDGE (e, ei, block->succs) @@ -3641,15 +3642,10 @@ do_hoist_insertion (basic_block block) bitmap_set_t tmp = bitmap_set_new (); phi_translate_set (tmp, ANTIC_IN (e->dest), e); bitmap_and_into (&ANTIC_OUT->values, &tmp->values); - bitmap_and_into (&ANTIC_OUT->expressions, &tmp->expressions); bitmap_set_free (tmp); } else - { - bitmap_and_into (&ANTIC_OUT->values, &ANTIC_IN (e->dest)->values); - bitmap_and_into (&ANTIC_OUT->expressions, - &ANTIC_IN (e->dest)->expressions); - } + bitmap_and_into (&ANTIC_OUT->values, &ANTIC_IN (e->dest)->values); } /* Compute the set of hoistable expressions from ANTIC_OUT. First compute |