diff options
| author | Christian Ehrhardt <ehrhardt@mathematik.uni-ulm.de> | 2003-01-21 08:02:31 +0000 |
|---|---|---|
| committer | Richard Henderson <rth@gcc.gnu.org> | 2003-01-21 00:02:31 -0800 |
| commit | 292e35a31bcfd1648b087a0de16c04fab0cb0d76 (patch) | |
| tree | 09ea707b673fd0e1fc779230f7640c7ce57a0811 | |
| parent | d8d0f5af818f3579df750e4bfad32e6b96f22b63 (diff) | |
| download | gcc-292e35a31bcfd1648b087a0de16c04fab0cb0d76.zip gcc-292e35a31bcfd1648b087a0de16c04fab0cb0d76.tar.gz gcc-292e35a31bcfd1648b087a0de16c04fab0cb0d76.tar.bz2 | |
re PR rtl-optimization/7507 (ICE (segfault) with -O2)
PR opt/7507
* calls.c (fix_unsafe_tree): Split out from ...
(expand_call): ... here. Use it on the function address too.
From-SVN: r61539
| -rw-r--r-- | gcc/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/calls.c | 56 |
2 files changed, 39 insertions, 23 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index b359032..ec08e1f 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2003-01-21 Christian Ehrhardt <ehrhardt@mathematik.uni-ulm.de> + + PR opt/7507 + * calls.c (fix_unsafe_tree): Split out from ... + (expand_call): ... here. Use it on the function address too. + 2003-01-20 Richard Henderson <rth@redhat.com> * expr.h (default_must_pass_in_stack): Move decl outside ifdef. diff --git a/gcc/calls.c b/gcc/calls.c index 8296b84..e911dda 100644 --- a/gcc/calls.c +++ b/gcc/calls.c @@ -2068,6 +2068,35 @@ check_sibcall_argument_overlap (insn, arg, mark_stored_args_map) return insn != NULL_RTX; } +static tree +fix_unsafe_tree (t) + tree t; +{ + switch (unsafe_for_reeval (t)) + { + case 0: /* Safe. */ + break; + + case 1: /* Mildly unsafe. */ + t = unsave_expr (t); + break; + + case 2: /* Wildly unsafe. */ + { + tree var = build_decl (VAR_DECL, NULL_TREE, + TREE_TYPE (t)); + SET_DECL_RTL (var, + expand_expr (t, NULL_RTX, VOIDmode, EXPAND_NORMAL)); + t = var; + } + break; + + default: + abort (); + } + return t; +} + /* Generate all the code for a function call and return an rtx for its value. Store the value in TARGET (specified as an rtx) if convenient. @@ -2516,35 +2545,16 @@ expand_call (exp, target, ignore) for (; i != end; i += inc) { - switch (unsafe_for_reeval (args[i].tree_value)) - { - case 0: /* Safe. */ - break; - - case 1: /* Mildly unsafe. */ - args[i].tree_value = unsave_expr (args[i].tree_value); - break; - - case 2: /* Wildly unsafe. */ - { - tree var = build_decl (VAR_DECL, NULL_TREE, - TREE_TYPE (args[i].tree_value)); - SET_DECL_RTL (var, - expand_expr (args[i].tree_value, NULL_RTX, - VOIDmode, EXPAND_NORMAL)); - args[i].tree_value = var; - } - break; - - default: - abort (); - } + args[i].tree_value = fix_unsafe_tree (args[i].tree_value); /* We need to build actparms for optimize_tail_recursion. We can safely trash away TREE_PURPOSE, since it is unused by this function. */ if (try_tail_recursion) actparms = tree_cons (NULL_TREE, args[i].tree_value, actparms); } + /* Do the same for the function address if it is an expression. */ + if (!fndecl) + TREE_OPERAND (exp, 0) = fix_unsafe_tree (TREE_OPERAND (exp, 0)); /* Expanding one of those dangerous arguments could have added cleanups, but otherwise give it a whirl. */ if (any_pending_cleanups (1)) |