diff options
author | Martin Sebor <msebor@redhat.com> | 2020-11-20 14:35:25 -0700 |
---|---|---|
committer | Martin Sebor <msebor@redhat.com> | 2020-11-20 14:35:25 -0700 |
commit | 27c5416fc8a4c2b33a0d6b6a26da2518791e0464 (patch) | |
tree | 793b046a37ba17a2477970f92ea36c6f07ce5eac | |
parent | ba23e045fcb820e8d32dee361c4d048604d8d599 (diff) | |
download | gcc-27c5416fc8a4c2b33a0d6b6a26da2518791e0464.zip gcc-27c5416fc8a4c2b33a0d6b6a26da2518791e0464.tar.gz gcc-27c5416fc8a4c2b33a0d6b6a26da2518791e0464.tar.bz2 |
PR middle-end/97861 - ICE on an invalid redeclaration of a function with attribute access
gcc/c-family/ChangeLog:
* c-warn.c (warn_parm_array_mismatch): Bail on invalid redeclarations
with fewer arguments.
gcc/testsuite/ChangeLog:
* gcc.dg/attr-access-4.c: New test.
-rw-r--r-- | gcc/c-family/c-warn.c | 16 | ||||
-rw-r--r-- | gcc/testsuite/gcc.dg/attr-access-4.c | 8 |
2 files changed, 17 insertions, 7 deletions
diff --git a/gcc/c-family/c-warn.c b/gcc/c-family/c-warn.c index 6d1f9a7..6d22a11 100644 --- a/gcc/c-family/c-warn.c +++ b/gcc/c-family/c-warn.c @@ -3374,18 +3374,20 @@ warn_parm_array_mismatch (location_t origloc, tree fndecl, tree newparms) for (tree curp = curparms, newp = newparms; curp; curp = TREE_CHAIN (curp), newp = TREE_CHAIN (newp), ++parmpos) { + if (!newp) + /* Bail on invalid redeclarations with fewer arguments. */ + return; + /* Only check pointers and C++ references. */ tree newptype = TREE_TYPE (newp); if (!POINTER_TYPE_P (newptype)) continue; - { - /* Skip mismatches in __builtin_va_list that is commonly - an array but that in declarations of built-ins decays - to a pointer. */ - if (builtin && TREE_TYPE (newptype) == TREE_TYPE (va_list_type_node)) - continue; - } + /* Skip mismatches in __builtin_va_list that is commonly + an array but that in declarations of built-ins decays + to a pointer. */ + if (builtin && TREE_TYPE (newptype) == TREE_TYPE (va_list_type_node)) + continue; /* Access specs for the argument on the current (previous) and new (to replace the current) declarations. Either may be null, diff --git a/gcc/testsuite/gcc.dg/attr-access-4.c b/gcc/testsuite/gcc.dg/attr-access-4.c new file mode 100644 index 0000000..7a2870a --- /dev/null +++ b/gcc/testsuite/gcc.dg/attr-access-4.c @@ -0,0 +1,8 @@ +/* PR middle-end/97861 - ICE on an invalid redeclaration of a function + with attribute access + { dg-do compile } + { dg-options "-Wall" } */ + +__attribute__ ((access (read_only, 2))) +void f (int, int*); +void f (int a) { } // { dg-error "conflicting types for 'f'" } |