diff options
| author | Richard Biener <rguenther@suse.de> | 2025-03-03 14:12:37 +0100 |
|---|---|---|
| committer | Richard Biener <rguenth@gcc.gnu.org> | 2025-03-04 09:24:31 +0100 |
| commit | 10e4107dfcf9fe324d0902f16411a75c596dab91 (patch) | |
| tree | df339b4f6fb5d02ab85e4a2887cc557e32337fd2 | |
| parent | bfb9276f344cbc6794379d61d0279dfc3a7441b3 (diff) | |
| download | gcc-10e4107dfcf9fe324d0902f16411a75c596dab91.zip gcc-10e4107dfcf9fe324d0902f16411a75c596dab91.tar.gz gcc-10e4107dfcf9fe324d0902f16411a75c596dab91.tar.bz2 | |
tree-optimization/119096 - bogus conditional reduction vectorization
When we vectorize a .COND_ADD reduction and apply the single-use-def
cycle optimization we can end up chosing the wrong else value for
subsequent .COND_ADD. The following rectifies this.
PR tree-optimization/119096
* tree-vect-loop.cc (vect_transform_reduction): Use the
correct else value for .COND_fn.
* gcc.dg/vect/pr119096.c: New testcase.
| -rw-r--r-- | gcc/testsuite/gcc.dg/vect/pr119096.c | 21 | ||||
| -rw-r--r-- | gcc/tree-vect-loop.cc | 2 |
2 files changed, 22 insertions, 1 deletions
diff --git a/gcc/testsuite/gcc.dg/vect/pr119096.c b/gcc/testsuite/gcc.dg/vect/pr119096.c new file mode 100644 index 0000000..2c03a59 --- /dev/null +++ b/gcc/testsuite/gcc.dg/vect/pr119096.c @@ -0,0 +1,21 @@ +#include "tree-vect.h" + +long __attribute__((noipa)) +sum(int* A, int* B) +{ + long total = 0; + for(int j = 0; j < 16; j++) + if((A[j] > 0) & (B[j] > 0)) + total += (long)A[j]; + return total; +} +int main() +{ + int A[16] = { 1,1,1,1, 1,1,1,1, 1,1,1,1, 1,1,1,1 }; + int B[16] = { }; + check_vect (); + if (sum (A, B) != 0) + abort (); + return 0; +} + diff --git a/gcc/tree-vect-loop.cc b/gcc/tree-vect-loop.cc index dc15b95..5253362 100644 --- a/gcc/tree-vect-loop.cc +++ b/gcc/tree-vect-loop.cc @@ -9064,7 +9064,7 @@ vect_transform_reduction (loop_vec_info loop_vinfo, new_stmt = gimple_build_call_internal (internal_fn (code), op.num_ops, vop[0], vop[1], vop[2], - vop[1]); + vop[reduc_index]); else new_stmt = gimple_build_assign (vec_dest, tree_code (op.code), vop[0], vop[1], vop[2]); |