aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAntoni Boucher <bouanto@zoho.com>2023-01-03 15:04:41 -0500
committerAntoni Boucher <bouanto@zoho.com>2024-01-19 16:02:46 -0500
commit07b392550f37bd9bb146dcef3d110111fb3ad114 (patch)
tree1842ff75702cfac40fd3968641afcc89715d0ca8
parent63736351ec4d1e49261a483ea55e0f5ecfc591c8 (diff)
downloadgcc-07b392550f37bd9bb146dcef3d110111fb3ad114.zip
gcc-07b392550f37bd9bb146dcef3d110111fb3ad114.tar.gz
gcc-07b392550f37bd9bb146dcef3d110111fb3ad114.tar.bz2
libgccjit: Add missing builtins needed by optimizations
gcc/jit/ChangeLog: * jit-builtins.cc (ensure_optimization_builtins_exist): Add popcount builtins. gcc/testsuite/ChangeLog: * jit.dg/all-non-failing-tests.h: New test. * jit.dg/test-popcount.c: New test.
-rw-r--r--gcc/jit/jit-builtins.cc3
-rw-r--r--gcc/testsuite/jit.dg/all-non-failing-tests.h10
-rw-r--r--gcc/testsuite/jit.dg/test-popcount.c84
3 files changed, 97 insertions, 0 deletions
diff --git a/gcc/jit/jit-builtins.cc b/gcc/jit/jit-builtins.cc
index bf82887..e0bb247 100644
--- a/gcc/jit/jit-builtins.cc
+++ b/gcc/jit/jit-builtins.cc
@@ -609,6 +609,9 @@ builtins_manager::ensure_optimization_builtins_exist ()
We can't loop through all of the builtin_data array, we don't
support all types yet. */
(void)get_builtin_function_by_id (BUILT_IN_TRAP);
+ (void)get_builtin_function_by_id (BUILT_IN_POPCOUNT);
+ (void)get_builtin_function_by_id (BUILT_IN_POPCOUNTL);
+ (void)get_builtin_function_by_id (BUILT_IN_POPCOUNTLL);
}
/* Playback support. */
diff --git a/gcc/testsuite/jit.dg/all-non-failing-tests.h b/gcc/testsuite/jit.dg/all-non-failing-tests.h
index a3bd035..d09a31e 100644
--- a/gcc/testsuite/jit.dg/all-non-failing-tests.h
+++ b/gcc/testsuite/jit.dg/all-non-failing-tests.h
@@ -286,6 +286,13 @@
/* test-nonnull-attribute.c: This can't be in the testcases array as it needs
the `-O2` flag. */
+/* test-popcount.c */
+#define create_code create_code_popcount
+#define verify_code verify_code_popcount
+#include "test-popcount.c"
+#undef create_code
+#undef verify_code
+
/* test-pr103562.c: We don't add this one, since it touches
the optimization level of the context as a whole. */
@@ -525,6 +532,9 @@ const struct testcase testcases[] = {
{"nested_loop",
create_code_nested_loop,
verify_code_nested_loop},
+ {"popcount",
+ create_code_popcount,
+ verify_code_popcount},
{"pr66700_observing_write_through_ptr",
create_code_pr66700_observing_write_through_ptr,
verify_code_pr66700_observing_write_through_ptr},
diff --git a/gcc/testsuite/jit.dg/test-popcount.c b/gcc/testsuite/jit.dg/test-popcount.c
new file mode 100644
index 0000000..6ad241f
--- /dev/null
+++ b/gcc/testsuite/jit.dg/test-popcount.c
@@ -0,0 +1,84 @@
+#include <stdlib.h>
+#include <stdio.h>
+#include <string.h>
+#include <stdint.h>
+
+#include "libgccjit.h"
+
+#include "harness.h"
+
+void
+create_code (gcc_jit_context *ctxt, void *user_data)
+{
+ /* Let's try to inject the equivalent of:
+int
+popcount (unsigned int x)
+{
+ int i = 0;
+ while (x)
+ {
+ x &= x - 1;
+ ++i;
+ }
+ return i;
+}
+ */
+ gcc_jit_type *int_type =
+ gcc_jit_context_get_type (ctxt, GCC_JIT_TYPE_INT);
+ gcc_jit_type *uint_type =
+ gcc_jit_context_get_type (ctxt, GCC_JIT_TYPE_UNSIGNED_INT);
+
+ gcc_jit_param *param_x =
+ gcc_jit_context_new_param (
+ ctxt,
+ NULL,
+ uint_type, "x");
+ gcc_jit_param *params[1] = {param_x};
+ gcc_jit_function *func =
+ gcc_jit_context_new_function (ctxt,
+ NULL,
+ GCC_JIT_FUNCTION_EXPORTED,
+ int_type,
+ "popcount",
+ 1, params, 0);
+
+ gcc_jit_lvalue *x = gcc_jit_param_as_lvalue (param_x);
+ gcc_jit_rvalue *x_rvalue = gcc_jit_lvalue_as_rvalue (x);
+ gcc_jit_lvalue *i =
+ gcc_jit_function_new_local (func, NULL, int_type, "i");
+ gcc_jit_rvalue *zero = gcc_jit_context_zero (ctxt, int_type);
+
+ gcc_jit_block *initial =
+ gcc_jit_function_new_block (func, "initial");
+ gcc_jit_block *while_block =
+ gcc_jit_function_new_block (func, "while");
+
+ gcc_jit_block_add_assignment (initial, NULL, i, zero);
+ gcc_jit_block_end_with_jump (initial, NULL, while_block);
+
+ gcc_jit_block *after =
+ gcc_jit_function_new_block (func, "after");
+
+ gcc_jit_block *while_body =
+ gcc_jit_function_new_block (func, "while_body");
+ gcc_jit_rvalue *uzero = gcc_jit_context_zero (ctxt, uint_type);
+ gcc_jit_rvalue *cmp =
+ gcc_jit_context_new_comparison (ctxt, NULL, GCC_JIT_COMPARISON_NE, x_rvalue, uzero);
+ gcc_jit_block_end_with_conditional (while_block, NULL, cmp, while_body, after);
+
+ gcc_jit_rvalue *uone = gcc_jit_context_one (ctxt, uint_type);
+ gcc_jit_rvalue *sub = gcc_jit_context_new_binary_op (ctxt, NULL, GCC_JIT_BINARY_OP_MINUS, uint_type, x_rvalue, uone);
+ gcc_jit_block_add_assignment_op (while_body, NULL, x, GCC_JIT_BINARY_OP_BITWISE_AND, sub);
+
+ gcc_jit_rvalue *one = gcc_jit_context_one (ctxt, int_type);
+ gcc_jit_block_add_assignment_op (while_body, NULL, i, GCC_JIT_BINARY_OP_PLUS, one);
+ gcc_jit_block_end_with_jump (while_body, NULL, while_block);
+
+ gcc_jit_block_end_with_return(after, NULL, gcc_jit_lvalue_as_rvalue (i));
+}
+
+void
+verify_code (gcc_jit_context *ctxt, gcc_jit_result *result)
+{
+ CHECK_NON_NULL (result);
+}