diff options
author | Mike Frysinger <vapier@gentoo.org> | 2022-10-26 21:53:30 +0545 |
---|---|---|
committer | Mike Frysinger <vapier@gentoo.org> | 2022-10-31 21:24:39 +0545 |
commit | 5b94c3808140206d3b5204a3780f294d590cc458 (patch) | |
tree | 4b5bea9bdc30a6ab503bd3d1c289b5e6f20af836 /sim/riscv/sim-main.c | |
parent | f2462532e24ebfc137598d73ee6541948121f040 (diff) | |
download | binutils-5b94c3808140206d3b5204a3780f294d590cc458.zip binutils-5b94c3808140206d3b5204a3780f294d590cc458.tar.gz binutils-5b94c3808140206d3b5204a3780f294d590cc458.tar.bz2 |
sim: common: change sim_read & sim_write to use void* buffers
When reading/writing arbitrary data to the system's memory, the unsigned
char pointer type doesn't make that much sense. Switch it to void so we
align a bit with standard C library read/write functions, and to avoid
having to sprinkle casts everywhere.
Diffstat (limited to 'sim/riscv/sim-main.c')
-rw-r--r-- | sim/riscv/sim-main.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/sim/riscv/sim-main.c b/sim/riscv/sim-main.c index 0156f79..5932c0d 100644 --- a/sim/riscv/sim-main.c +++ b/sim/riscv/sim-main.c @@ -1192,15 +1192,15 @@ initialize_env (SIM_DESC sd, const char * const *argv, const char * const *env) cpu->sp = sp; /* First push the argc value. */ - sim_write (sd, sp, (void *)&argc, sizeof (unsigned_word)); + sim_write (sd, sp, &argc, sizeof (unsigned_word)); sp += sizeof (unsigned_word); /* Then the actual argv strings so we know where to point argv[]. */ for (i = 0; i < argc; ++i) { unsigned len = strlen (argv[i]) + 1; - sim_write (sd, sp_flat, (void *)argv[i], len); - sim_write (sd, sp, (void *)&sp_flat, sizeof (address_word)); + sim_write (sd, sp_flat, argv[i], len); + sim_write (sd, sp, &sp_flat, sizeof (address_word)); sp_flat += len; sp += sizeof (address_word); } @@ -1211,8 +1211,8 @@ initialize_env (SIM_DESC sd, const char * const *argv, const char * const *env) for (i = 0; i < envc; ++i) { unsigned len = strlen (env[i]) + 1; - sim_write (sd, sp_flat, (void *)env[i], len); - sim_write (sd, sp, (void *)&sp_flat, sizeof (address_word)); + sim_write (sd, sp_flat, env[i], len); + sim_write (sd, sp, &sp_flat, sizeof (address_word)); sp_flat += len; sp += sizeof (address_word); } |