aboutsummaryrefslogtreecommitdiff
path: root/ld
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2020-06-06 11:58:09 +0930
committerAlan Modra <amodra@gmail.com>2020-06-06 14:44:32 +0930
commit1fc47f80893f810915a167ed554497f820cb2220 (patch)
tree9f74762507d63a5ccf8f312be4cb2a6adc8caf85 /ld
parent070558eb0deed3fc798c41ec75db75f99660a4e1 (diff)
downloadbinutils-1fc47f80893f810915a167ed554497f820cb2220.zip
binutils-1fc47f80893f810915a167ed554497f820cb2220.tar.gz
binutils-1fc47f80893f810915a167ed554497f820cb2220.tar.bz2
Re: PR13802, referred common symbol not UNDefined
It looks like this one was previously just swept under the rug. Prior to git commit c4b126b87a6c, the arm backend emitted an absolute dynamic symbol "foo" with value zero for what was originally a common symbol. That was just wrong. The patch also removes an xfail for bfin-linux-uclibc. PR 13802 * testsuite/ld-elf/comm-data.exp: Don't xfail arm or bfin-linux.
Diffstat (limited to 'ld')
-rw-r--r--ld/ChangeLog4
-rw-r--r--ld/testsuite/ld-elf/comm-data.exp5
2 files changed, 6 insertions, 3 deletions
diff --git a/ld/ChangeLog b/ld/ChangeLog
index c3b213f..6a0f30b 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,5 +1,9 @@
2020-06-06 Alan Modra <amodra@gmail.com>
+ * testsuite/ld-elf/comm-data.exp: Don't xfail arm or bfin-linux.
+
+2020-06-06 Alan Modra <amodra@gmail.com>
+
* lexsup.c (ld_options): Accept -plugin and -plugin-opt when
!ENABLE_PLUGINS.
* testsuite/lib/ld-lib.exp (check_plugin_api_available): Adjust.
diff --git a/ld/testsuite/ld-elf/comm-data.exp b/ld/testsuite/ld-elf/comm-data.exp
index c735fe2..87ae3b2 100644
--- a/ld/testsuite/ld-elf/comm-data.exp
+++ b/ld/testsuite/ld-elf/comm-data.exp
@@ -74,10 +74,9 @@ if [istarget "*-*-hpux*"] {
append AFLAGS " --defsym HPUX=1"
}
-# bfin does not currently support copy relocs.
+# bfin-elf does not currently support copy relocs.
setup_xfail "bfin-*-*"
-
-setup_xfail "arm*-*-*" "ld/13802"
+clear_xfail "bfin-*-linux-uclibc*"
# Verify that a common symbol has been converted to an undefined
# reference to the global symbol of the same name defined above