aboutsummaryrefslogtreecommitdiff
path: root/ld/testsuite/lib
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2021-02-13 09:51:17 +1030
committerAlan Modra <amodra@gmail.com>2021-02-14 22:34:27 +1030
commit5b1f6c95704da7128ca2a7c682a2e0ef533180ce (patch)
tree0b17c5490260475e9df6d86e756656257a926e16 /ld/testsuite/lib
parentf5b2658b0fbef02a855b7bb7288de051cc687237 (diff)
downloadbinutils-5b1f6c95704da7128ca2a7c682a2e0ef533180ce.zip
binutils-5b1f6c95704da7128ca2a7c682a2e0ef533180ce.tar.gz
binutils-5b1f6c95704da7128ca2a7c682a2e0ef533180ce.tar.bz2
ld testsuite: change unresolved to unsupported/fail
"unresolved" as a test result means runtest returns an error, which can be confusing when there is no apparent error unless you look in .log files. In particular many tests are skipped without reporting an error if no target C compiler is found, but if a target C compiler is found but won't compile a testcase for some reason we used to mark the test as unresolved. Which is no more worthy of an error than when lacking a C compiler entirely. * testsuite/ld-cdtest/cdtest.exp, * testsuite/ld-checks/checks.exp, * testsuite/ld-elf/binutils.exp, * testsuite/ld-elf/compress.exp, * testsuite/ld-elf/dwarf.exp, * testsuite/ld-elf/exclude.exp, * testsuite/ld-elf/frame.exp, * testsuite/ld-elf/indirect.exp, * testsuite/ld-elf/linux-x86.exp, * testsuite/ld-elf/sec-to-seg.exp, * testsuite/ld-elf/tls_common.exp, * testsuite/ld-elfcomm/elfcomm.exp, * testsuite/ld-elfvers/vers.exp, * testsuite/ld-elfvsb/elfvsb.exp, * testsuite/ld-elfweak/elfweak.exp, * testsuite/ld-ifunc/binutils.exp, * testsuite/ld-mips-elf/mips-elf-flags.exp, * testsuite/ld-misc/defsym.exp, * testsuite/ld-mn10300/mn10300.exp, * testsuite/ld-plugin/lto.exp, * testsuite/ld-plugin/plugin.exp, * testsuite/ld-scripts/align.exp, * testsuite/ld-scripts/assert.exp, * testsuite/ld-scripts/crossref.exp, * testsuite/ld-scripts/defined.exp, * testsuite/ld-scripts/extern.exp, * testsuite/ld-scripts/log2.exp, * testsuite/ld-scripts/map-address.exp, * testsuite/ld-scripts/phdrs.exp, * testsuite/ld-scripts/phdrs2.exp, * testsuite/ld-scripts/script.exp, * testsuite/ld-scripts/section-flags.exp, * testsuite/ld-scripts/sizeof.exp, * testsuite/ld-scripts/weak.exp, * testsuite/ld-selective/selective.exp, * testsuite/ld-sh/sh.exp, * testsuite/ld-shared/shared.exp, * testsuite/ld-srec/srec.exp, * testsuite/ld-tic6x/tic6x.exp, * testsuite/ld-undefined/undefined.exp, * testsuite/ld-undefined/weak-undef.exp, * testsuite/lib/ld-lib.exp: Don't use unresolved except after perror. Instead report "unsupported" or "fail".
Diffstat (limited to 'ld/testsuite/lib')
-rw-r--r--ld/testsuite/lib/ld-lib.exp15
1 files changed, 8 insertions, 7 deletions
diff --git a/ld/testsuite/lib/ld-lib.exp b/ld/testsuite/lib/ld-lib.exp
index 97b1ab3..4a08617 100644
--- a/ld/testsuite/lib/ld-lib.exp
+++ b/ld/testsuite/lib/ld-lib.exp
@@ -494,7 +494,7 @@ proc run_ld_link_tests { ldtests args } {
set binfile tmpdir/[lindex $testitem 6]
set cflags [lindex $testitem 7]
set objfiles {}
- set is_unresolved 0
+ set is_unsupported 0
set failed 0
set maybe_failed 0
set ld_output ""
@@ -523,7 +523,7 @@ proc run_ld_link_tests { ldtests args } {
catch "$unbzip2" exec_output
if ![string match "" $exec_output] then {
send_log "$exec_output\n"
- set is_unresolved 1
+ set is_unsupported 1
break
}
} else {
@@ -531,7 +531,7 @@ proc run_ld_link_tests { ldtests args } {
if { [file extension $src_file] == ".c" } {
set as_file "tmpdir/$fileroot.s"
if ![ld_compile "$CC -S $CFLAGS $cflags" $srcdir/$subdir/$src_file $as_file] {
- set is_unresolved 1
+ set is_unsupported 1
break
}
} else {
@@ -551,8 +551,8 @@ proc run_ld_link_tests { ldtests args } {
continue
}
# Catch compiler errors.
- if { $is_unresolved } {
- unresolved $testname
+ if { $is_unsupported } {
+ unsupported $testname
continue
}
@@ -567,6 +567,7 @@ proc run_ld_link_tests { ldtests args } {
set ld_output "$exec_output"
}
+ set is_unresolved 0
if { !$failed } {
foreach actionlist $actions {
set action [lindex $actionlist 0]
@@ -751,7 +752,7 @@ proc run_ld_link_exec_tests { ldtests args } {
}
}
if { $failed != 0 } {
- unresolved $testname
+ unsupported $testname
continue
}
@@ -941,7 +942,7 @@ proc run_cc_link_tests { ldtests } {
}
}
if { $failed != 0 } {
- unresolved $testname
+ unsupported $testname
continue
}