diff options
| author | Alan Modra <amodra@gmail.com> | 2021-04-14 12:42:27 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2021-04-14 15:06:11 +0930 |
| commit | 13acb58d42e7c66d0d69240cc6b7a0fbf8290da4 (patch) | |
| tree | d604a4a4ff4ed2999618405c5635f106e4b99e26 /gprof/utils.c | |
| parent | d20eb46617fc6170e144f80dcbaffbc3f4ff6090 (diff) | |
| download | binutils-13acb58d42e7c66d0d69240cc6b7a0fbf8290da4.zip binutils-13acb58d42e7c66d0d69240cc6b7a0fbf8290da4.tar.gz binutils-13acb58d42e7c66d0d69240cc6b7a0fbf8290da4.tar.bz2 | |
PR27716, build failure for msdosdjgpp: PATH_MAX undeclared
We shouldn't be using arbitrary limits like PATH_MAX in GNU programs.
This patch also fixes some memory leaks in readelf when processing
separate debug info.
PR 27716
binutils/
* objdump.c (show_line): Don't limit paths to PATH_MAX.
* readelf.c (struct filedata): Change program_interpreter from
a char array to a char pointer.
(process_program_headers): Sanity check PT_INTERP p_filesz.
Malloc program_interpreter using p_filesz and read directly from
file.
(process_dynamic_section): Check program_interpreter is non-NULL.
(free_filedata): New function, split out from..
(process_object): ..here.
(close_debug_file): Call free_filedata.
* sysdep.h: Don't include sys/param.h.
(PATH_MAX): Don't define.
* configure.ac: Don't check for sys/param.h.
* configure: Regenerate.
gprof/
* gprof.h (PATH_MAX): Don't define.
* corefile.c (core_create_line_syms): Don't use PATH_MAX for initial
file name size.
* source.c (annotate_source): Malloc file name buffer. Always
trim off "-ann" when dos 8.3 annotate file matches original.
* utils.c (print_name_only): Malloc file name buffer.
Diffstat (limited to 'gprof/utils.c')
| -rw-r--r-- | gprof/utils.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/gprof/utils.c b/gprof/utils.c index 76bc57d..2c04895 100644 --- a/gprof/utils.c +++ b/gprof/utils.c @@ -43,9 +43,7 @@ int print_name_only (Sym *self) { const char *name = self->name; - const char *filename; char *demangled = 0; - char buf[PATH_MAX]; int size = 0; if (name) @@ -60,7 +58,9 @@ print_name_only (Sym *self) size = strlen (name); if ((line_granularity || inline_file_names) && self->file) { - filename = self->file->name; + const char *filename = self->file->name; + char *buf; + if (!print_path) { filename = strrchr (filename, '/'); @@ -73,6 +73,7 @@ print_name_only (Sym *self) filename = self->file->name; } } + buf = xmalloc (strlen (filename) + 8 + 20 + 16); if (line_granularity) { sprintf (buf, " (%s:%d @ %lx)", filename, self->line_num, @@ -84,6 +85,7 @@ print_name_only (Sym *self) } printf ("%s", buf); size += strlen (buf); + free (buf); } free (demangled); DBG (DFNDEBUG, printf ("{%d} ", self->cg.top_order)); |