diff options
author | Simon Marchi <simon.marchi@polymtl.ca> | 2022-11-14 10:10:04 -0500 |
---|---|---|
committer | Simon Marchi <simon.marchi@efficios.com> | 2022-11-15 10:46:38 -0500 |
commit | 7e21379963c8be351a03693ce64d0a597ea0dbd7 (patch) | |
tree | 209b6cff4e72347b9f060a66b70f9b0d43d71703 /gdbsupport/common-debug.cc | |
parent | 4f4a46ba7c5f7e18218a4fcda5a38ee7dc819202 (diff) | |
download | binutils-7e21379963c8be351a03693ce64d0a597ea0dbd7.zip binutils-7e21379963c8be351a03693ce64d0a597ea0dbd7.tar.gz binutils-7e21379963c8be351a03693ce64d0a597ea0dbd7.tar.bz2 |
gdb/testsuite: get_set_option_choices: expect \r\n after each item
I get some random failures since commit 8d45c3a82a0e ("[gdb/testsuite]
Set completions to unlimited in get_set_option_choices"), which can be
reproduced with:
$ make check-read1 TESTS="gdb.base/parse_number.exp"
For instance:
set architecture A^M
Ambiguous item "A".^M
(gdb) FAIL: gdb.base/parse_number.exp: arch=A: set architecture A
The problem is the regexp in get_set_option_choices, it is possible that
is only matches part of a completion result. With check-read1, that is
always one letter.
Fix this by expecting the \r\n at the end of the line, so we only match
entire results. Use ^ in match patterns to ensure we don't miss any
output.
Approved-By: Tom de Vries <tdevries@suse.de>
Change-Id: Ib1733737feab7dde0f7095866e089081a891054e
Diffstat (limited to 'gdbsupport/common-debug.cc')
0 files changed, 0 insertions, 0 deletions