aboutsummaryrefslogtreecommitdiff
path: root/gdbserver
diff options
context:
space:
mode:
authorHannes Domani <ssbssa@yahoo.de>2020-09-23 18:16:24 +0200
committerHannes Domani <ssbssa@yahoo.de>2020-09-24 19:01:22 +0200
commit99bb393f1d107cf2c4016c486f85625d362027a7 (patch)
tree4f39cc9663e5066636eca71bdefffca999bda68b /gdbserver
parent6eee0315f6767ba932f19513af1ff432e5071bea (diff)
downloadbinutils-99bb393f1d107cf2c4016c486f85625d362027a7.zip
binutils-99bb393f1d107cf2c4016c486f85625d362027a7.tar.gz
binutils-99bb393f1d107cf2c4016c486f85625d362027a7.tar.bz2
Handle 64bit breakpoints of WOW64 processes as SIGINT
When a WOW64 process triggers a breakpoint exception in 64bit code (which happens when a 64bit gdb calls DebugBreakProcess for a 32bit target), gdb ignores the breakpoint (because Wow64GetThreadContext can only report the pc of 32bit code, and there is not int3 at this location). But if these 64bit breakpoint exceptions are handled as SIGINT, gdb doesn't check for int3, and always stops the target. gdb/ChangeLog: 2020-09-23 Hannes Domani <ssbssa@yahoo.de> * nat/windows-nat.c (handle_exception): Handle 64bit breakpoints in WOW64 processes as SIGINT. * nat/windows-nat.h: Make wow64_process a shared variable. * windows-nat.c: Remove static wow64_process variable. gdbserver/ChangeLog: 2020-09-23 Hannes Domani <ssbssa@yahoo.de> * win32-low.cc: Remove local wow64_process variable. * win32-low.h: Remove local wow64_process variable.
Diffstat (limited to 'gdbserver')
-rw-r--r--gdbserver/ChangeLog5
-rw-r--r--gdbserver/win32-low.cc4
-rw-r--r--gdbserver/win32-low.h2
3 files changed, 5 insertions, 6 deletions
diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog
index d47fcfd..c97d4b1 100644
--- a/gdbserver/ChangeLog
+++ b/gdbserver/ChangeLog
@@ -1,3 +1,8 @@
+2020-09-23 Hannes Domani <ssbssa@yahoo.de>
+
+ * win32-low.cc: Remove local wow64_process variable.
+ * win32-low.h: Remove local wow64_process variable.
+
2020-09-18 Tom Tromey <tromey@adacore.com>
* netbsd-low.h (class netbsd_process_target) <wait>: Update.
diff --git a/gdbserver/win32-low.cc b/gdbserver/win32-low.cc
index 9980986..e5f85a1 100644
--- a/gdbserver/win32-low.cc
+++ b/gdbserver/win32-low.cc
@@ -91,10 +91,6 @@ static int faked_breakpoint = 0;
/* True if current_process_handle needs to be closed. */
static bool open_process_used = false;
-#ifdef __x86_64__
-bool wow64_process = false;
-#endif
-
const struct target_desc *win32_tdesc;
#ifdef __x86_64__
const struct target_desc *wow64_win32_tdesc;
diff --git a/gdbserver/win32-low.h b/gdbserver/win32-low.h
index d4ad5d8..8c113f8 100644
--- a/gdbserver/win32-low.h
+++ b/gdbserver/win32-low.h
@@ -30,8 +30,6 @@ extern const struct target_desc *win32_tdesc;
#ifdef __x86_64__
extern const struct target_desc *wow64_win32_tdesc;
-extern bool wow64_process;
-
typedef BOOL (WINAPI *winapi_Wow64GetThreadContext) (HANDLE, PWOW64_CONTEXT);
extern winapi_Wow64GetThreadContext win32_Wow64GetThreadContext;
#endif