aboutsummaryrefslogtreecommitdiff
path: root/gdbserver
diff options
context:
space:
mode:
authorAndrew Burgess <andrew.burgess@embecosm.com>2020-11-20 17:23:03 +0000
committerAndrew Burgess <andrew.burgess@embecosm.com>2020-12-11 22:04:28 +0000
commit966484941738b7a474fb7e4fe29eb5693fc9096c (patch)
tree122e6dd4b2f7f7fe516f85ffc5db8aa54948494f /gdbserver
parent94ba44a68dccb5fa2a0a40a52efebdd1faeae43d (diff)
downloadbinutils-966484941738b7a474fb7e4fe29eb5693fc9096c.zip
binutils-966484941738b7a474fb7e4fe29eb5693fc9096c.tar.gz
binutils-966484941738b7a474fb7e4fe29eb5693fc9096c.tar.bz2
gdbsupport: make use of safe-ctype functions from libiberty
Make use of the safe-ctype replacements for the standard ctype character checking functions in gdbsupport/common-utils.cc. The gdbsupport library is included into both gdb and gdbserver, and on the gdbserver side there are two targets, gdbserver itself, and also libinproctrace.so. libiberty was already being included in the gdbserver link command, but was missing from the libinproctrace.so link. As a result, after changing gdbsupport/common-utils.cc to depend on libiberty, libinproctrace.so would no longer link until I modified its link line. gdbserver/ChangeLog: * Makefile.in (IPA_LIB): Include libiberty library. gdbsupport/ChangeLog: * gdbsupport/common-utils.cc: Change 'ctype.h' include to 'safe-ctype.h'. (extract_string_maybe_quoted): Use safe-ctype function versions. (is_digit_in_base): Likewise. (digit_to_int): Likewise. (strtoulst): Likewise. (skip_spaces): Likewise. (skip_to_space): Likewise.
Diffstat (limited to 'gdbserver')
-rw-r--r--gdbserver/ChangeLog4
-rw-r--r--gdbserver/Makefile.in2
2 files changed, 5 insertions, 1 deletions
diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog
index 700da6e..9756d4c 100644
--- a/gdbserver/ChangeLog
+++ b/gdbserver/ChangeLog
@@ -1,3 +1,7 @@
+2020-12-11 Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * Makefile.in (IPA_LIB): Include libiberty library.
+
2020-11-11 Andrew Burgess <andrew.burgess@embecosm.com>
* server.cc (gdbserver_usage): Add missing option to usage text.
diff --git a/gdbserver/Makefile.in b/gdbserver/Makefile.in
index 1969ed0..e12848c 100644
--- a/gdbserver/Makefile.in
+++ b/gdbserver/Makefile.in
@@ -395,7 +395,7 @@ $(IPA_LIB): $(sort $(IPA_OBJS)) ${CDEPS}
$(ECHO_CXXLD) $(CC_LD) -shared -fPIC -Wl,--soname=$(IPA_LIB) \
-Wl,--no-undefined $(INTERNAL_CFLAGS) $(INTERNAL_LDFLAGS) \
$(CXXFLAGS) \
- -o $(IPA_LIB) ${IPA_OBJS} -ldl -pthread
+ -o $(IPA_LIB) ${IPA_OBJS} $(LIBIBERTY) -ldl -pthread
# Put the proper machine-specific files first, so M-. on a machine
# specific routine gets the one for the correct machine.