diff options
| author | Hannes Domani <ssbssa@yahoo.de> | 2024-10-27 19:30:38 +0100 |
|---|---|---|
| committer | Hannes Domani <ssbssa@yahoo.de> | 2024-10-28 21:00:12 +0100 |
| commit | f951f2dbb8f57fa6469a6935116a31004c7e373a (patch) | |
| tree | ef6728c836c0c0002bb89b8b7b7c29c626327161 /gdb | |
| parent | 2930265f05600c1fd1ecdf2eb0889d977079ef78 (diff) | |
| download | binutils-f951f2dbb8f57fa6469a6935116a31004c7e373a.zip binutils-f951f2dbb8f57fa6469a6935116a31004c7e373a.tar.gz binutils-f951f2dbb8f57fa6469a6935116a31004c7e373a.tar.bz2 | |
Don't copy memory for arguments if there are none
If amd64_windows_push_arguments is called with no arguments, then ARGS
can be NULL, and inside the passed-by-pointer block, memcpy is called
with this NULL, which is undefined behavior.
So this just disable the passed-by-pointer block if there are no
arguments.
Fixes the following ubsan error:
C:/gdb/src/gdb.git/gdb/amd64-windows-tdep.c:244:12: runtime error: null pointer passed as argument 2, which is declared to never be null
Approved-By: Tom Tromey <tom@tromey.com>
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/amd64-windows-tdep.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/gdb/amd64-windows-tdep.c b/gdb/amd64-windows-tdep.c index 29a1f60..3ba2d1a 100644 --- a/gdb/amd64-windows-tdep.c +++ b/gdb/amd64-windows-tdep.c @@ -238,6 +238,7 @@ amd64_windows_push_arguments (struct regcache *regcache, int nargs, These arguments are replaced by pointers to a copy we are making in inferior memory. So use a copy of the ARGS table, to avoid modifying the original one. */ + if (nargs > 0) { struct value **args1 = XALLOCAVEC (struct value *, nargs); |