diff options
| author | Simon Marchi <simon.marchi@polymtl.ca> | 2020-01-12 11:06:21 -0500 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@polymtl.ca> | 2020-01-12 11:06:38 -0500 |
| commit | f5df0b5f0874598790a60f1462f67887868bd77f (patch) | |
| tree | 082b8e759af5de0506b6f4c8f6b50ad78e8aebd9 /gdb | |
| parent | 4ec89149dd83efecea15300bf425c9988f4cd5c0 (diff) | |
| download | binutils-f5df0b5f0874598790a60f1462f67887868bd77f.zip binutils-f5df0b5f0874598790a60f1462f67887868bd77f.tar.gz binutils-f5df0b5f0874598790a60f1462f67887868bd77f.tar.bz2 | |
gdbserver: include aarch32/aarch64 header file in corresponding source file
When building gdbserver for an aarch64 host with -Wmissing-declarations,
I see:
CXX linux-aarch32-tdesc.o
/home/simark/src/binutils-gdb/gdb/gdbserver/linux-aarch32-tdesc.c:28:1: error: no previous declaration for 'const target_desc* aarch32_linux_read_description()' [-Werror=missing-declarations]
aarch32_linux_read_description ()
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/simark/src/binutils-gdb/gdb/gdbserver/linux-aarch32-tdesc.c:43:1: error: no previous declaration for 'bool is_aarch32_linux_description(const target_desc*)' [-Werror=missing-declarations]
is_aarch32_linux_description (const target_desc *tdesc)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
CXX linux-aarch64-tdesc.o
/home/simark/src/binutils-gdb/gdb/gdbserver/linux-aarch64-tdesc.c:32:1: error: no previous declaration for 'const target_desc* aarch64_linux_read_description(uint64_t, bool)' [-Werror=missing-declarations]
aarch64_linux_read_description (uint64_t vq, bool pauth_p)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fix it by including linux-aarch32-tdesc.h in linux-aarch32-tdesc.c and
linux-aarch64-tdesc.h in linux-aarch64-tdesc.c.
gdb/gdbserver/ChangeLog:
* linux-aarch32-tdesc.c: Include linux-aarch32-tdesc.h.
* linux-aarch64-tdesc.c: Include linux-aarch64-tdesc.h.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/gdbserver/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/gdbserver/linux-aarch32-tdesc.c | 3 | ||||
| -rw-r--r-- | gdb/gdbserver/linux-aarch64-tdesc.c | 3 |
3 files changed, 11 insertions, 0 deletions
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index b62ed4c..40a765a 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,8 @@ +2020-01-12 Simon Marchi <simon.marchi@polymtl.ca> + + * linux-aarch32-tdesc.c: Include linux-aarch32-tdesc.h. + * linux-aarch64-tdesc.c: Include linux-aarch64-tdesc.h. + 2020-01-10 Pedro Alves <palves@redhat.com> * fork-child.c (post_fork_inferior): Pass target down to diff --git a/gdb/gdbserver/linux-aarch32-tdesc.c b/gdb/gdbserver/linux-aarch32-tdesc.c index 98d9ac8..b0dffe2 100644 --- a/gdb/gdbserver/linux-aarch32-tdesc.c +++ b/gdb/gdbserver/linux-aarch32-tdesc.c @@ -16,6 +16,9 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */ #include "server.h" + +#include "linux-aarch32-tdesc.h" + #include "tdesc.h" #include "arch/aarch32.h" #include <inttypes.h> diff --git a/gdb/gdbserver/linux-aarch64-tdesc.c b/gdb/gdbserver/linux-aarch64-tdesc.c index 85fe414..897fbb4 100644 --- a/gdb/gdbserver/linux-aarch64-tdesc.c +++ b/gdb/gdbserver/linux-aarch64-tdesc.c @@ -18,6 +18,9 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */ #include "server.h" + +#include "linux-aarch64-tdesc.h" + #include "tdesc.h" #include "arch/aarch64.h" #include "linux-aarch32-low.h" |