diff options
| author | Simon Marchi <simon.marchi@efficios.com> | 2025-03-25 16:32:19 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@efficios.com> | 2025-03-26 10:09:29 -0400 |
| commit | b2eb2b00dc5573f607647bb163f19d9f1e2c6f3d (patch) | |
| tree | bd1566ea3ff6df5a81f52da797d2315cdcff753c /gdb | |
| parent | 6d1823dc899bb0df45a79c32ea4ef571c1414fcb (diff) | |
| download | binutils-b2eb2b00dc5573f607647bb163f19d9f1e2c6f3d.zip binutils-b2eb2b00dc5573f607647bb163f19d9f1e2c6f3d.tar.gz binutils-b2eb2b00dc5573f607647bb163f19d9f1e2c6f3d.tar.bz2 | |
gdb/dwarf: remove redundant read of dwo_name
lookup_dwo_unit receives the name of the DWO unit to look up, as read
from the DW_AT_dwo_name attribute of the skeleton DIE. But then, it
doesn't use it:
/* Yeah, we look dwo_name up again, but it simplifies the code. */
dwo_name = dwarf2_dwo_name (comp_unit_die, cu);
Perhaps this comment made sense at some point, but with the code we have
today, I don't understand it. It should be fine to use the name passed
as a parameter, which the caller also obtained by calling
dwarf2_dwo_name.
Change-Id: I84723e12726f77e4202d042428ee0eed9962ceb8
Approved-By: Tom Tromey <tom@tromey.com>
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/dwarf2/read.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index ff4f388..bcfa254 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -2866,8 +2866,12 @@ lookup_dwo_id (struct dwarf2_cu *cu, struct die_info* comp_unit_die) } /* Subroutine of cutu_reader to simplify it. - Look up the DWO unit specified by COMP_UNIT_DIE of THIS_CU. - Returns NULL if the specified DWO unit cannot be found. */ + Look up the DWO unit specified by COMP_UNIT_DIE of CU. + + DWO_NAME is the name (DW_AT_dwo_name) of the DWO unit already read from + COMP_UNIT_DIE. + + Returns nullptr if the specified DWO unit cannot be found. */ static struct dwo_unit * lookup_dwo_unit (dwarf2_cu *cu, die_info *comp_unit_die, const char *dwo_name) @@ -2885,8 +2889,6 @@ lookup_dwo_unit (dwarf2_cu *cu, die_info *comp_unit_die, const char *dwo_name) gdb_assert (cu != NULL); - /* Yeah, we look dwo_name up again, but it simplifies the code. */ - dwo_name = dwarf2_dwo_name (comp_unit_die, cu); comp_dir = dwarf2_string_attr (comp_unit_die, DW_AT_comp_dir, cu); if (per_cu->is_debug_types) |