diff options
| author | Tom Tromey <tom@tromey.com> | 2021-02-26 17:25:38 -0700 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2021-02-26 17:32:42 -0700 |
| commit | 573dc0cc43f2c3ce4d28ec1aa1bf05fc43810cda (patch) | |
| tree | 68d3c38bd1b2eeaacf18b2eced4fe2f7be32861f /gdb | |
| parent | 0cf9ea0b163f4651f2d61252edc6765d98924fe8 (diff) | |
| download | binutils-573dc0cc43f2c3ce4d28ec1aa1bf05fc43810cda.zip binutils-573dc0cc43f2c3ce4d28ec1aa1bf05fc43810cda.tar.gz binutils-573dc0cc43f2c3ce4d28ec1aa1bf05fc43810cda.tar.bz2 | |
Minor fix in skip_ctf_tests
I noticed an oddity in skip_ctf_tests -- for me it ends up caching the
string "!0", because it ends with 'return ![...]'. In Tcl, this is
just string concatenation.
The result works because the users of this function have unbraced if
conditions, like:
if [skip_ctf_tests] {
... which works because "if" re-parses the returned string as an
expression, and evaluates that.
There's only a latent bug here, but this is also un-idiomatic, so I am
checking in this patch to fix it. This way, if someone in the future
uses a braced condition (which is what I normally recommend), it will
continue to work.
gdb/testsuite/ChangeLog
2021-02-26 Tom Tromey <tom@tromey.com>
* lib/gdb.exp (skip_ctf_tests): Use expr on result.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/testsuite/ChangeLog | 4 | ||||
| -rw-r--r-- | gdb/testsuite/lib/gdb.exp | 4 |
2 files changed, 7 insertions, 1 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index d29f6d4..625c4ec 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2021-02-26 Tom Tromey <tom@tromey.com> + + * lib/gdb.exp (skip_ctf_tests): Use expr on result. + 2021-02-26 Jan Vrany <jan.vrany@labware.com> * gdb.trace/mi-tsv-changed.exp (test_create_delete_modify_tsv): diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 1420512..7480bd5 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -7433,11 +7433,13 @@ gdb_caching_proc skip_ctf_tests { return 1 } - return ![gdb_can_simple_compile ctfdebug { + set can_ctf [gdb_can_simple_compile ctfdebug { int main () { return 0; } } executable "additional_flags=-gt"] + + return [expr {!$can_ctf}] } # Return 1 if compiler supports -gstatement-frontiers. Otherwise, |