diff options
| author | Sam James <sam@gentoo.org> | 2025-03-19 22:44:10 +0000 |
|---|---|---|
| committer | Sam James <sam@gentoo.org> | 2025-03-19 22:47:14 +0000 |
| commit | 3bed686102cb14552d2ed1b83336453d7ce0dd47 (patch) | |
| tree | 6fb31b8d50da3c6e96e8ef01012f00397c98b960 /gdb | |
| parent | d1da7bb43ecab2425a1135f09d6f62c9a7f63ae7 (diff) | |
| download | binutils-3bed686102cb14552d2ed1b83336453d7ce0dd47.zip binutils-3bed686102cb14552d2ed1b83336453d7ce0dd47.tar.gz binutils-3bed686102cb14552d2ed1b83336453d7ce0dd47.tar.bz2 | |
gdb-add-index: quote PKGVERSION
In Gentoo, we configure our gdb with `--with-pkgversion=` with
"Gentoo VERSION XXXX" where XXX depends on patching (not that we patch
gdb really these days) or vanilla.
Since 71f193a5c1cb02dcde6ac160cdab88e9725862bb, this goes wrong, yielding
```
/usr/bin/gdb-add-index: 25: Syntax error: "(" unexpected
```
with lines 25-26 being:
```
PKGVERSION=(Gentoo 9999 vanilla)
VERSION=17.0.50.20250319-git
```
Quote both assignments (PKGVERSION by necessity, VERSION for consistency
or symmetry).
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32325
Diffstat (limited to 'gdb')
| -rwxr-xr-x | gdb/contrib/gdb-add-index.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/contrib/gdb-add-index.sh b/gdb/contrib/gdb-add-index.sh index 4db1234..b299f83 100755 --- a/gdb/contrib/gdb-add-index.sh +++ b/gdb/contrib/gdb-add-index.sh @@ -22,8 +22,8 @@ GDB=${GDB:=gdb} OBJCOPY=${OBJCOPY:=objcopy} READELF=${READELF:=readelf} -PKGVERSION=@PKGVERSION@ -VERSION=@VERSION@ +PKGVERSION="@PKGVERSION@" +VERSION="@VERSION@" myname="${0##*/}" |