aboutsummaryrefslogtreecommitdiff
path: root/gdb
diff options
context:
space:
mode:
authorTom de Vries <tdevries@suse.de>2021-08-02 15:31:51 +0200
committerTom de Vries <tdevries@suse.de>2021-08-02 15:31:51 +0200
commit1df42e90836a542aa16b2f89b22810d264bb3882 (patch)
tree7993042bcca39b5fabd2a5796fa349da53b15467 /gdb
parent4d47cbdd29ba8c29876adcbb84dfba9efbd15f5f (diff)
downloadbinutils-1df42e90836a542aa16b2f89b22810d264bb3882.zip
binutils-1df42e90836a542aa16b2f89b22810d264bb3882.tar.gz
binutils-1df42e90836a542aa16b2f89b22810d264bb3882.tar.bz2
[gdb/testsuite] Fix gdb.dwarf2/per-bfd-sharing.exp with cc-with-gdb-index
When running with target board cc-with-gdb-index, we run into: ... rm: cannot remove '/tmp/tmp.JmYTeiuFjj/*.gdb-index': \ No such file or directory^M FAIL: gdb.dwarf2/per-bfd-sharing.exp: \ couldn't remove files in temporary cache dir ... Fix this, as in gdb.base/index-cache.exp, by only FAILing when $expecting_index_cache_use. Tested on x86_64-linux. gdb/testsuite/ChangeLog: 2021-08-02 Tom de Vries <tdevries@suse.de> * gdb.dwarf2/per-bfd-sharing.exp: Only expect index-cache files when $expecting_index_cache_use.
Diffstat (limited to 'gdb')
-rw-r--r--gdb/testsuite/gdb.dwarf2/per-bfd-sharing.exp6
1 files changed, 5 insertions, 1 deletions
diff --git a/gdb/testsuite/gdb.dwarf2/per-bfd-sharing.exp b/gdb/testsuite/gdb.dwarf2/per-bfd-sharing.exp
index 48a30fa..6891cd7 100644
--- a/gdb/testsuite/gdb.dwarf2/per-bfd-sharing.exp
+++ b/gdb/testsuite/gdb.dwarf2/per-bfd-sharing.exp
@@ -23,6 +23,10 @@ if { [build_executable "failed to prepare" $testfile $srcfile \
return
}
+set has_index_section [exec_has_index_section $binfile]
+set uses_readnow [expr [string first "-readnow" $GDBFLAGS] != -1]
+set expecting_index_cache_use [expr !$has_index_section && !$uses_readnow]
+
lassign [remote_exec host mktemp -d] ret cache_dir
# The output of mktemp contains an end of line, remove it.
@@ -93,7 +97,7 @@ foreach_with_prefix first $methods {
}
lassign [remote_exec host sh "-c \"rm $cache_dir/*.gdb-index\""] ret
-if { $ret != 0 } {
+if { $ret != 0 && $expecting_index_cache_use } {
fail "couldn't remove files in temporary cache dir"
return
}