diff options
author | Luis Machado <lgustavo@codesourcery.com> | 2016-10-24 17:44:56 -0500 |
---|---|---|
committer | Luis Machado <lgustavo@codesourcery.com> | 2016-10-24 17:44:56 -0500 |
commit | 010ece9c47f1ac08c9436b133a74472713dd709b (patch) | |
tree | 1435312cf422a4fccc9b9ed62380dc55086f41be /gdb | |
parent | b8d38ee4250fb6ad001c2f03fa2cef8c2bc06b57 (diff) | |
download | binutils-010ece9c47f1ac08c9436b133a74472713dd709b.zip binutils-010ece9c47f1ac08c9436b133a74472713dd709b.tar.gz binutils-010ece9c47f1ac08c9436b133a74472713dd709b.tar.bz2 |
Fix obvious gotcha in string comparison
This patch fixes a gotcha when comparing exception's messages in
exception_print_same. It should've used the statically-allocated
string versions msg1 and msg2 instead.
As is, it could lead to crashes.
gdb/ChangeLog:
2016-10-24 Luis Machado <lgustavo@codesourcery.com>
* exec.c (exception_print_same): Fix string comparison to use
statically-allocated ones.
Diffstat (limited to 'gdb')
-rw-r--r-- | gdb/ChangeLog | 5 | ||||
-rw-r--r-- | gdb/exec.c | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index be72369..388cc1f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2016-10-24 Luis Machado <lgustavo@codesourcery.com> + + * exec.c (exception_print_same): Fix string comparison to use + statically-allocated ones. + 2016-10-21 Tom Tromey <tom@tromey.com> * dwarf2expr.h (class dwarf_expr_context) @@ -152,7 +152,7 @@ exception_print_same (struct gdb_exception e1, struct gdb_exception e2) return (e1.reason == e2.reason && e1.error == e2.error - && strcmp (e1.message, e2.message) == 0); + && strcmp (msg1, msg2) == 0); } /* See gdbcore.h. */ |